pgsql: Correct several behavior descriptions in comments.

2020-08-15 Thread Noah Misch
Correct several behavior descriptions in comments. Reuse cautionary language from src/test/ssl/README in src/test/kerberos/README. SLRUs have had access to six-character segments names since commit 73c986adde5d73a5e2555da9b5c8facedb146dcd, and recovery stopped calling HeapTupleHeaderAdvanceLatest

pgsql: Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType.

2020-08-15 Thread Noah Misch
Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType. Several PGXN modules reference LockTagType values; renumbering would force a recompile of those modules. Oversight in back-patch of today's commit 566372b3d6435639e4cc4476d79b8505a0297c87. Back-patch to released branches, v12 throu

pgsql: Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType.

2020-08-15 Thread Noah Misch
Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType. Several PGXN modules reference LockTagType values; renumbering would force a recompile of those modules. Oversight in back-patch of today's commit 566372b3d6435639e4cc4476d79b8505a0297c87. Back-patch to released branches, v12 throu

pgsql: Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType.

2020-08-15 Thread Noah Misch
Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType. Several PGXN modules reference LockTagType values; renumbering would force a recompile of those modules. Oversight in back-patch of today's commit 566372b3d6435639e4cc4476d79b8505a0297c87. Back-patch to released branches, v12 throu

pgsql: Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType.

2020-08-15 Thread Noah Misch
Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType. Several PGXN modules reference LockTagType values; renumbering would force a recompile of those modules. Oversight in back-patch of today's commit 566372b3d6435639e4cc4476d79b8505a0297c87. Back-patch to released branches, v12 throu

pgsql: Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType.

2020-08-15 Thread Noah Misch
Move new LOCKTAG_DATABASE_FROZEN_IDS to end of enum LockTagType. Several PGXN modules reference LockTagType values; renumbering would force a recompile of those modules. Oversight in back-patch of today's commit 566372b3d6435639e4cc4476d79b8505a0297c87. Back-patch to released branches, v12 throu

Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Noah Misch
On Sat, Aug 15, 2020 at 04:39:05PM -0400, Tom Lane wrote: > Noah Misch writes: > > Prevent concurrent SimpleLruTruncate() for any given SLRU. > > I find it fairly scary that you've changed enum LockTagType in the > back branches. Are we quite certain that no extensions have compiled-in > values

Re: pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Tom Lane
Noah Misch writes: > Prevent concurrent SimpleLruTruncate() for any given SLRU. I find it fairly scary that you've changed enum LockTagType in the back branches. Are we quite certain that no extensions have compiled-in values of that enum? Safer from an ABI standpoint would be to add the new va

pgsql: Doc: various improvements for pg_basebackup reference page.

2020-08-15 Thread Tom Lane
Doc: various improvements for pg_basebackup reference page. Put the -r option in the right section (it certainly isn't an option controlling "the location and format of the output"). Clarify the behavior of the tablespace and waldir options (that part per gripe from [email protected]). Ma

pgsql: Doc: various improvements for pg_basebackup reference page.

2020-08-15 Thread Tom Lane
Doc: various improvements for pg_basebackup reference page. Put the -r option in the right section (it certainly isn't an option controlling "the location and format of the output"). Clarify the behavior of the tablespace and waldir options (that part per gripe from [email protected]). Ma

pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Noah Misch
Prevent concurrent SimpleLruTruncate() for any given SLRU. The SimpleLruTruncate() header comment states the new coding rule. To achieve this, add locktype "frozenid" and two LWLocks. This closes a rare opportunity for data loss, which manifested as "apparent wraparound" or "could not access sta

pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Noah Misch
Prevent concurrent SimpleLruTruncate() for any given SLRU. The SimpleLruTruncate() header comment states the new coding rule. To achieve this, add locktype "frozenid" and two LWLocks. This closes a rare opportunity for data loss, which manifested as "apparent wraparound" or "could not access sta

pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Noah Misch
Prevent concurrent SimpleLruTruncate() for any given SLRU. The SimpleLruTruncate() header comment states the new coding rule. To achieve this, add locktype "frozenid" and two LWLocks. This closes a rare opportunity for data loss, which manifested as "apparent wraparound" or "could not access sta

pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Noah Misch
Prevent concurrent SimpleLruTruncate() for any given SLRU. The SimpleLruTruncate() header comment states the new coding rule. To achieve this, add locktype "frozenid" and two LWLocks. This closes a rare opportunity for data loss, which manifested as "apparent wraparound" or "could not access sta

pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Noah Misch
Prevent concurrent SimpleLruTruncate() for any given SLRU. The SimpleLruTruncate() header comment states the new coding rule. To achieve this, add locktype "frozenid" and two LWLocks. This closes a rare opportunity for data loss, which manifested as "apparent wraparound" or "could not access sta

pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Noah Misch
Prevent concurrent SimpleLruTruncate() for any given SLRU. The SimpleLruTruncate() header comment states the new coding rule. To achieve this, add locktype "frozenid" and two LWLocks. This closes a rare opportunity for data loss, which manifested as "apparent wraparound" or "could not access sta

pgsql: Prevent concurrent SimpleLruTruncate() for any given SLRU.

2020-08-15 Thread Noah Misch
Prevent concurrent SimpleLruTruncate() for any given SLRU. The SimpleLruTruncate() header comment states the new coding rule. To achieve this, add locktype "frozenid" and two LWLocks. This closes a rare opportunity for data loss, which manifested as "apparent wraparound" or "could not access sta

pgsql: Remove no-longer-usable hstore--1.0--1.1.sql update script.

2020-08-15 Thread Tom Lane
Remove no-longer-usable hstore--1.0--1.1.sql update script. Since commit 865f14a2d made "=>" unusable as an operator name, it's been impossible either to install hstore 1.0 or to execute this update script. There's not much point in continuing to ship it. Discussion: https://postgr.es/m/653936.1

pgsql: Remove obsolete HAVE_BUGGY_SOLARIS_STRTOD

2020-08-15 Thread Peter Eisentraut
Remove obsolete HAVE_BUGGY_SOLARIS_STRTOD Fixed more than 10 years ago. Reviewed-by: Noah Misch Discussion: https://www.postgresql.org/message-id/flat/aa266ede-baaa-f4e6-06cf-5b1737610e9a%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bacda6a32

pgsql: Remove obsolete cygwin.h hack

2020-08-15 Thread Peter Eisentraut
Remove obsolete cygwin.h hack The version being checked for is 20 years old. Reviewed-by: Marco Atzeri Discussion: https://www.postgresql.org/message-id/flat/aa266ede-baaa-f4e6-06cf-5b1737610e9a%402ndquadrant.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/53