Re: pgsql: snapshot scalability: cache snapshots using a xact completion co

2020-08-17 Thread Tom Lane
Andres Freund writes: > I'd written to Tom that I was planning to revert unless the number of > failures were lower than initially indicated. But that actually seems to > have come to pass (the failures are quicker to report because they don't > run the subsequent tests, of course). I'd like to l

Re: pgsql: snapshot scalability: cache snapshots using a xact completion co

2020-08-17 Thread Andres Freund
On 2020-08-18 13:52:46 +0900, Michael Paquier wrote: > On Tue, Aug 18, 2020 at 04:30:21AM +, Andres Freund wrote: > spurfowl and more animals are telling us that this commit has broken > 2PC: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=spurfowl&dt=2020-08-18%2004%3A31%3A11 It loo

Re: pgsql: snapshot scalability: cache snapshots using a xact completion co

2020-08-17 Thread Andres Freund
Hi, On 2020-08-18 00:55:22 -0400, Tom Lane wrote: > Andres Freund writes: > > snapshot scalability: cache snapshots using a xact completion counter. > > buildfarm doesn't like this a bit ... Yea, looking already. Unless that turns out to be incredibly bad luck and only the first three animals f

Re: pgsql: snapshot scalability: cache snapshots using a xact completion co

2020-08-17 Thread Tom Lane
Andres Freund writes: > snapshot scalability: cache snapshots using a xact completion counter. buildfarm doesn't like this a bit ... regards, tom lane

Re: pgsql: snapshot scalability: cache snapshots using a xact completion co

2020-08-17 Thread Michael Paquier
On Tue, Aug 18, 2020 at 04:30:21AM +, Andres Freund wrote: > snapshot scalability: cache snapshots using a xact completion counter. > > Previous commits made it faster/more scalable to compute snapshots. But not > building a snapshot is still faster. Now that GetSnapshotData() does not > maint

pgsql: snapshot scalability: cache snapshots using a xact completion co

2020-08-17 Thread Andres Freund
snapshot scalability: cache snapshots using a xact completion counter. Previous commits made it faster/more scalable to compute snapshots. But not building a snapshot is still faster. Now that GetSnapshotData() does not maintain RecentGlobal* anymore, that is actually not too hard: This commit in

pgsql: Fix use-after-release issue in PL/Sample

2020-08-17 Thread Michael Paquier
Fix use-after-release issue in PL/Sample Introduced in adbe62d0. Per buildfarm member prion, when using RELCACHE_FORCE_RELEASE. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/51300b45db95b6fd29f88534ab0739fdc9df1699 Modified Files -- src/test/modules/

pgsql: Add PL/Sample to src/test/modules/

2020-08-17 Thread Michael Paquier
Add PL/Sample to src/test/modules/ PL/Sample is an example template of procedural-language handler. This can be used as a base to implement a custom PL, or as a facility to test APIs dedicated to PLs. Much more could be done in this module, like adding a simple validator, but this is left as fut

pgsql: Disable autovacuum for BRIN test table

2020-08-17 Thread Alvaro Herrera
Disable autovacuum for BRIN test table This should improve stability in the tests. Per buildfarm member hyrax (CLOBBER_CACHE_ALWAYS) via Tom Lane. Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: Disable autovacuum for BRIN test table

2020-08-17 Thread Alvaro Herrera
Disable autovacuum for BRIN test table This should improve stability in the tests. Per buildfarm member hyrax (CLOBBER_CACHE_ALWAYS) via Tom Lane. Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: Disable autovacuum for BRIN test table

2020-08-17 Thread Alvaro Herrera
Disable autovacuum for BRIN test table This should improve stability in the tests. Per buildfarm member hyrax (CLOBBER_CACHE_ALWAYS) via Tom Lane. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: Disable autovacuum for BRIN test table

2020-08-17 Thread Alvaro Herrera
Disable autovacuum for BRIN test table This should improve stability in the tests. Per buildfarm member hyrax (CLOBBER_CACHE_ALWAYS) via Tom Lane. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: Disable autovacuum for BRIN test table

2020-08-17 Thread Alvaro Herrera
Disable autovacuum for BRIN test table This should improve stability in the tests. Per buildfarm member hyrax (CLOBBER_CACHE_ALWAYS) via Tom Lane. Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: Disable autovacuum for BRIN test table

2020-08-17 Thread Alvaro Herrera
Disable autovacuum for BRIN test table This should improve stability in the tests. Per buildfarm member hyrax (CLOBBER_CACHE_ALWAYS) via Tom Lane. Discussion: https://postgr.es/m/[email protected] Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdif

pgsql: Disable autovacuum for BRIN test table

2020-08-17 Thread Alvaro Herrera
Disable autovacuum for BRIN test table This should improve stability in the tests. Per buildfarm member hyrax (CLOBBER_CACHE_ALWAYS) via Tom Lane. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6e704

pgsql: Doc: fix description of UNION/CASE/etc type unification.

2020-08-17 Thread Tom Lane
Doc: fix description of UNION/CASE/etc type unification. The description of what select_common_type() does was not terribly accurate. Improve it. David Johnston and Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://gi

pgsql: Doc: fix description of UNION/CASE/etc type unification.

2020-08-17 Thread Tom Lane
Doc: fix description of UNION/CASE/etc type unification. The description of what select_common_type() does was not terribly accurate. Improve it. David Johnston and Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- REL9_6_STABLE Details --- https://gi

pgsql: Doc: fix description of UNION/CASE/etc type unification.

2020-08-17 Thread Tom Lane
Doc: fix description of UNION/CASE/etc type unification. The description of what select_common_type() does was not terribly accurate. Improve it. David Johnston and Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- REL9_5_STABLE Details --- https://gi

pgsql: Doc: fix description of UNION/CASE/etc type unification.

2020-08-17 Thread Tom Lane
Doc: fix description of UNION/CASE/etc type unification. The description of what select_common_type() does was not terribly accurate. Improve it. David Johnston and Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postg

pgsql: Doc: fix description of UNION/CASE/etc type unification.

2020-08-17 Thread Tom Lane
Doc: fix description of UNION/CASE/etc type unification. The description of what select_common_type() does was not terribly accurate. Improve it. David Johnston and Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://gi

pgsql: Doc: fix description of UNION/CASE/etc type unification.

2020-08-17 Thread Tom Lane
Doc: fix description of UNION/CASE/etc type unification. The description of what select_common_type() does was not terribly accurate. Improve it. David Johnston and Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://gi

pgsql: Doc: fix description of UNION/CASE/etc type unification.

2020-08-17 Thread Tom Lane
Doc: fix description of UNION/CASE/etc type unification. The description of what select_common_type() does was not terribly accurate. Improve it. David Johnston and Tom Lane Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://gi

pgsql: Fix printing last progress report line in client programs.

2020-08-17 Thread Heikki Linnakangas
Fix printing last progress report line in client programs. A number of client programs have a "--progress" option that when printing to a TTY, updates the current line by printing a '\r' and overwriting it. After the last line, '\n' needs to be printed to move the cursor to the next line. pg_baseb

pgsql: Mark commit and abort WAL records with XLR_SPECIAL_REL_UPDATE.

2020-08-17 Thread Heikki Linnakangas
Mark commit and abort WAL records with XLR_SPECIAL_REL_UPDATE. If a commit or abort record includes "dropped relfilenodes", then replaying the record will remove data files. That is surely a "special rel update", but the records were not marked as such. Fix that, teach pg_rewind to expect and igno

pgsql: Make xact.h usable in frontend.

2020-08-17 Thread Heikki Linnakangas
Make xact.h usable in frontend. xact.h included utils/datetime.h, which cannot be used in the frontend (it includes fmgr.h, which needs Datum). But xact.h only needs the definition of TimestampTz from it, which is available directly in datatypes/timestamp.h. Change xact.h to include that instead o

pgsql: Fix printing last progress report line in client programs.

2020-08-17 Thread Heikki Linnakangas
Fix printing last progress report line in client programs. A number of client programs have a "--progress" option that when printing to a TTY, updates the current line by printing a '\r' and overwriting it. After the last line, '\n' needs to be printed to move the cursor to the next line. pg_baseb

pgsql: Fix printing last progress report line in client programs.

2020-08-17 Thread Heikki Linnakangas
Fix printing last progress report line in client programs. A number of client programs have a "--progress" option that when printing to a TTY, updates the current line by printing a '\r' and overwriting it. After the last line, '\n' needs to be printed to move the cursor to the next line. pg_baseb