pgsql: Update file header comments for logical/relation.c.

2020-09-17 Thread Amit Kapila
Update file header comments for logical/relation.c. Author: Amit Langote Reviewed-by: Amit Kapila Discussion: https://postgr.es/m/ca+hiwqe20ozoix13jycealptf_smjarzwtbfe5snd6zz+iu...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/24fb35e11148b2b2cae2

pgsql: Fix comments in heapam.c.

2020-09-17 Thread Amit Kapila
Fix comments in heapam.c. After commits 85f6b49c2c and 3ba59ccc89, we can allow parallel inserts which was earlier not possible as parallel group members won't conflict for relation extension and page lock. In those commits, we forgot to update comments at few places. Author: Amit Kapila Reviewe

pgsql: Fix comments in heapam.c.

2020-09-17 Thread Amit Kapila
Fix comments in heapam.c. After commits 85f6b49c2c and 3ba59ccc89, we can allow parallel inserts which was earlier not possible as parallel group members won't conflict for relation extension and page lock. In those commits, we forgot to update comments at few places. Author: Amit Kapila Reviewe

pgsql: Try to stabilize output from rolenames regression test.

2020-09-17 Thread Tom Lane
Try to stabilize output from rolenames regression test. It's not quite clear why commit 45b980570 has resulted in some instability here, though interference from concurrent autovacuum runs seems like a reasonable guess. What is clear is that the output ordering of the test queries is underdetermi

pgsql: Remove support for postfix (right-unary) operators.

2020-09-17 Thread Tom Lane
Remove support for postfix (right-unary) operators. This feature has been a thorn in our sides for a long time, causing many grammatical ambiguity problems. It doesn't seem worth the pain to continue to support it, so remove it. There are some follow-on improvements we can make in the grammar, b

Re: pgsql: Add support for building GiST index by sorting.

2020-09-17 Thread Heikki Linnakangas
On 17/09/2020 23:07, Peter Geoghegan wrote: On Thu, Sep 17, 2020 at 1:34 AM Heikki Linnakangas wrote: Add support for building GiST index by sorting. You forgot to bump catversion, despite your best efforts. :-) You left this behind: +/* FIXME: bump this before pushing! */ I have settled

Re: pgsql: Add support for building GiST index by sorting.

2020-09-17 Thread Tom Lane
Peter Geoghegan writes: > On Thu, Sep 17, 2020 at 1:34 AM Heikki Linnakangas > wrote: >> Add support for building GiST index by sorting. > You forgot to bump catversion, despite your best efforts. :-) > You left this behind: > +/* FIXME: bump this before pushing! */ Yeah, I noticed that, and j

pgsql: Remove factorial operators, leaving only the factorial() functio

2020-09-17 Thread Tom Lane
Remove factorial operators, leaving only the factorial() function. The "!" operator is our only built-in postfix operator. Remove it, on the way to removal of grammar support for postfix operators. There is also a "!!" prefix operator, but since it's been marked deprecated for most of its existe

Re: pgsql: Add support for building GiST index by sorting.

2020-09-17 Thread Peter Geoghegan
On Thu, Sep 17, 2020 at 1:34 AM Heikki Linnakangas wrote: > Add support for building GiST index by sorting. You forgot to bump catversion, despite your best efforts. :-) You left this behind: +/* FIXME: bump this before pushing! */ I have settled on a system for this: I write myself a reminde

pgsql: Further improve pgindent's list of file exclusions.

2020-09-17 Thread Tom Lane
Further improve pgindent's list of file exclusions. I despair of people keeping the README file's notes in sync with the actual exclusion list, so move the notes into the exclusion file. Adjust the pgindent script to explicitly ignore comments in the file, just in case (though it's hard to believe

pgsql: Improve common/logging.c's support for multiple verbosity levels

2020-09-17 Thread Tom Lane
Improve common/logging.c's support for multiple verbosity levels. Instead of hard-wiring specific verbosity levels into the option processing of client applications, invent pg_logging_increase_verbosity() and encourage clients to implement --verbose by calling that. Then, the common convention th

pgsql: Update parallel BTree scan state when the scan keys can't be sat

2020-09-17 Thread Amit Kapila
Update parallel BTree scan state when the scan keys can't be satisfied. For parallel btree scan to work for array of scan keys, it should reach BTPARALLEL_DONE state once for every distinct combination of array keys. This is required to ensure that the parallel workers don't try to seize blocks at

pgsql: Update parallel BTree scan state when the scan keys can't be sat

2020-09-17 Thread Amit Kapila
Update parallel BTree scan state when the scan keys can't be satisfied. For parallel btree scan to work for array of scan keys, it should reach BTPARALLEL_DONE state once for every distinct combination of array keys. This is required to ensure that the parallel workers don't try to seize blocks at

pgsql: Update parallel BTree scan state when the scan keys can't be sat

2020-09-17 Thread Amit Kapila
Update parallel BTree scan state when the scan keys can't be satisfied. For parallel btree scan to work for array of scan keys, it should reach BTPARALLEL_DONE state once for every distinct combination of array keys. This is required to ensure that the parallel workers don't try to seize blocks at

pgsql: Update parallel BTree scan state when the scan keys can't be sat

2020-09-17 Thread Amit Kapila
Update parallel BTree scan state when the scan keys can't be satisfied. For parallel btree scan to work for array of scan keys, it should reach BTPARALLEL_DONE state once for every distinct combination of array keys. This is required to ensure that the parallel workers don't try to seize blocks at

pgsql: Update parallel BTree scan state when the scan keys can't be sat

2020-09-17 Thread Amit Kapila
Update parallel BTree scan state when the scan keys can't be satisfied. For parallel btree scan to work for array of scan keys, it should reach BTPARALLEL_DONE state once for every distinct combination of array keys. This is required to ensure that the parallel workers don't try to seize blocks at

pgsql: Allow CURRENT_ROLE where CURRENT_USER is accepted

2020-09-17 Thread Peter Eisentraut
Allow CURRENT_ROLE where CURRENT_USER is accepted In the particular case of GRANTED BY, this is specified in the SQL standard. Since in PostgreSQL, CURRENT_ROLE is equivalent to CURRENT_USER, and CURRENT_USER is already supported here, adding CURRENT_ROLE is trivial. The other cases are PostgreS

pgsql: Add support for building GiST index by sorting.

2020-09-17 Thread Heikki Linnakangas
Add support for building GiST index by sorting. This adds a new optional support function to the GiST access method: sortsupport. If it is defined, the GiST index is built by sorting all data to the order defined by the sortsupport's comparator function, and packing the tuples in that order to GiS

pgsql: doc: Apply more consistently markup for OpenSSL

2020-09-17 Thread Michael Paquier
doc: Apply more consistently markup for OpenSSL OpenSSL was quoted in inconsistent ways in many places of the docs, sometimes with , or just nothing. Author: Daniel Gustafsson Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- ht