Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect

2020-10-06 Thread Fujii Masao
On 2020/10/07 11:13, Michael Paquier wrote: Hi Fujii-san, On Tue, Oct 06, 2020 at 01:52:55AM +, Fujii Masao wrote: postgres_fdw: reestablish new connection if cached one is detected as broken. In postgres_fdw, once remote connections are established, they are cached and re-used for subs

pgsql: Display the names of missing columns in error during logical rep

2020-10-06 Thread Amit Kapila
Display the names of missing columns in error during logical replication. In logical replication when a subscriber is missing some columns, it currently emits an error message that says "some" columns are missing, but it doesn't specify the missing column names. Change that to display missing colu

Re: pgsql: Fix race in test of pg_switch_wal().

2020-10-06 Thread Michael Paquier
On Tue, Oct 06, 2020 at 07:03:27PM -0700, Noah Misch wrote: > There's a new 020_archive_status.pl failure: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=mandrill&dt=2020-10-05%2023%3A02%3A17 > > Would you like to diagnose/fix that one? Wow, thanks. This does not looks like an issue c

Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect

2020-10-06 Thread Michael Paquier
Hi Fujii-san, On Tue, Oct 06, 2020 at 01:52:55AM +, Fujii Masao wrote: > postgres_fdw: reestablish new connection if cached one is detected as broken. > > In postgres_fdw, once remote connections are established, they are cached > and re-used for subsequent queries and transactions. There can

Re: pgsql: Fix race in test of pg_switch_wal().

2020-10-06 Thread Noah Misch
On Mon, Sep 14, 2020 at 05:27:07PM +0900, Michael Paquier wrote: > On Mon, Sep 14, 2020 at 06:19:38AM +, Noah Misch wrote: > > Fix race in test of pg_switch_wal(). > > > > The test failed when something added WAL between pg_switch_wal() and > > pg_current_wal_lsn(), seen on buildfarm members h

pgsql: pg_upgrade: remove pre-8.4 code and >= 8.4 check

2020-10-06 Thread Bruce Momjian
pg_upgrade: remove pre-8.4 code and >= 8.4 check We only support upgrading from >= 8.4 so no need for this code or tests. Reported-by: Magnus Hagander Discussion: https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493mjt-x6sppb...@mail.gmail.com Backpatch-through: 9.5 Branch -- REL9_

pgsql: pg_upgrade: remove pre-8.4 code and >= 8.4 check

2020-10-06 Thread Bruce Momjian
pg_upgrade: remove pre-8.4 code and >= 8.4 check We only support upgrading from >= 8.4 so no need for this code or tests. Reported-by: Magnus Hagander Discussion: https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493mjt-x6sppb...@mail.gmail.com Backpatch-through: 9.5 Branch -- REL_1

pgsql: pg_upgrade: remove pre-8.4 code and >= 8.4 check

2020-10-06 Thread Bruce Momjian
pg_upgrade: remove pre-8.4 code and >= 8.4 check We only support upgrading from >= 8.4 so no need for this code or tests. Reported-by: Magnus Hagander Discussion: https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493mjt-x6sppb...@mail.gmail.com Backpatch-through: 9.5 Branch -- REL_1

pgsql: pg_upgrade: remove pre-8.4 code and >= 8.4 check

2020-10-06 Thread Bruce Momjian
pg_upgrade: remove pre-8.4 code and >= 8.4 check We only support upgrading from >= 8.4 so no need for this code or tests. Reported-by: Magnus Hagander Discussion: https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493mjt-x6sppb...@mail.gmail.com Backpatch-through: 9.5 Branch -- REL9_

pgsql: pg_upgrade: remove pre-8.4 code and >= 8.4 check

2020-10-06 Thread Bruce Momjian
pg_upgrade: remove pre-8.4 code and >= 8.4 check We only support upgrading from >= 8.4 so no need for this code or tests. Reported-by: Magnus Hagander Discussion: https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493mjt-x6sppb...@mail.gmail.com Backpatch-through: 9.5 Branch -- REL_1

pgsql: pg_upgrade: remove pre-8.4 code and >= 8.4 check

2020-10-06 Thread Bruce Momjian
pg_upgrade: remove pre-8.4 code and >= 8.4 check We only support upgrading from >= 8.4 so no need for this code or tests. Reported-by: Magnus Hagander Discussion: https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493mjt-x6sppb...@mail.gmail.com Backpatch-through: 9.5 Branch -- maste

pgsql: pg_upgrade: remove pre-8.4 code and >= 8.4 check

2020-10-06 Thread Bruce Momjian
pg_upgrade: remove pre-8.4 code and >= 8.4 check We only support upgrading from >= 8.4 so no need for this code or tests. Reported-by: Magnus Hagander Discussion: https://postgr.es/m/CABUevEx-D0PNVe00tkeQRGennZQwDtBJn=493mjt-x6sppb...@mail.gmail.com Backpatch-through: 9.5 Branch -- REL_1

pgsql: pg_upgrade; change major version comparisons to use <=, not

2020-10-06 Thread Bruce Momjian
pg_upgrade; change major version comparisons to use <=, not < This makes checking for older major versions more consistent. Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1499477303d883947fec97730693f6f4e5593140 Modified Files -

pgsql: pg_upgrade; change major version comparisons to use <=, not

2020-10-06 Thread Bruce Momjian
pg_upgrade; change major version comparisons to use <=, not < This makes checking for older major versions more consistent. Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/bc1fbc960bf5efbb692f4d1bf91bf9bc6390425a Modified Files

pgsql: pg_upgrade; change major version comparisons to use <=, not

2020-10-06 Thread Bruce Momjian
pg_upgrade; change major version comparisons to use <=, not < This makes checking for older major versions more consistent. Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f09e2a8c6307058aa767924516bb057cc9cedef8 Modified Files -

pgsql: pg_upgrade; change major version comparisons to use <=, not

2020-10-06 Thread Bruce Momjian
pg_upgrade; change major version comparisons to use <=, not < This makes checking for older major versions more consistent. Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/89406a9b58a05c6f5f802c99b1587ae42e650123 Modified Files -

pgsql: pg_upgrade; change major version comparisons to use <=, not

2020-10-06 Thread Bruce Momjian
pg_upgrade; change major version comparisons to use <=, not < This makes checking for older major versions more consistent. Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/dc3953421b436981260ff3dc658e9a6c4c3f6ebe Modified Files -

pgsql: pg_upgrade; change major version comparisons to use <=, not

2020-10-06 Thread Bruce Momjian
pg_upgrade; change major version comparisons to use <=, not < This makes checking for older major versions more consistent. Backpatch-through: 9.5 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/2cb4b8e0ae16e7091a7bd5cf94f21d2719b108e0 Modified Files -

pgsql: pg_upgrade; change major version comparisons to use <=, not

2020-10-06 Thread Bruce Momjian
pg_upgrade; change major version comparisons to use <=, not < This makes checking for older major versions more consistent. Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0e78dcaf73b6b9d4c74b858ebb4a0464b7c726de Modified Files -

pgsql: Build EC members for child join rels in the right memory context

2020-10-06 Thread Tom Lane
Build EC members for child join rels in the right memory context. This patch prevents crashes or wrong plans when partition-wise joins are considered during GEQO planning, as a consequence of the EquivalenceClass data structures becoming corrupt after a GEQO context reset. A remaining problem is

pgsql: Build EC members for child join rels in the right memory context

2020-10-06 Thread Tom Lane
Build EC members for child join rels in the right memory context. This patch prevents crashes or wrong plans when partition-wise joins are considered during GEQO planning, as a consequence of the EquivalenceClass data structures becoming corrupt after a GEQO context reset. A remaining problem is

pgsql: Build EC members for child join rels in the right memory context

2020-10-06 Thread Tom Lane
Build EC members for child join rels in the right memory context. This patch prevents crashes or wrong plans when partition-wise joins are considered during GEQO planning, as a consequence of the EquivalenceClass data structures becoming corrupt after a GEQO context reset. A remaining problem is

pgsql: Further improvements on documentation for pg_dump -t

2020-10-06 Thread Magnus Hagander
Further improvements on documentation for pg_dump -t Ian submitted an updated patch just as I was pushing the previous one, so use this newer wording instead. Author: Ian Barwick Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/96423711918f44600c9ef91f4342984

pgsql: Further improvements on documentation for pg_dump -t

2020-10-06 Thread Magnus Hagander
Further improvements on documentation for pg_dump -t Ian submitted an updated patch just as I was pushing the previous one, so use this newer wording instead. Author: Ian Barwick Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1b4945e1e7162fe92aecb1cd2b373fba24

pgsql: Clarify documentation around pg_dump -t option

2020-10-06 Thread Magnus Hagander
Clarify documentation around pg_dump -t option The behavior is different for different types of objects, so make that more clear. Author: Ian Barwick Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0639f9b8c251d152695a968c3978edca844c3cad Modified Files ---

pgsql: Clarify documentation around pg_dump -t option

2020-10-06 Thread Magnus Hagander
Clarify documentation around pg_dump -t option The behavior is different for different types of objects, so make that more clear. Author: Ian Barwick Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b8c4d385120cb7fe70006812234b2cbc950f4a61 Modified Files --

pgsql: Expand installation documentation to cover binary installations

2020-10-06 Thread Magnus Hagander
Expand installation documentation to cover binary installations Reviewed-By: David G. Johnston, Daniel Gustafsson Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5b36221c46f9ca9c5df6a6e108790b5c6c5d2cc3 Modified Files -- doc/src/sgml/filelist.sgml