Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect

2020-10-10 Thread Tom Lane
Fujii Masao writes: >>> Therefore, the easy fix is to make libpq mark the connection as >>> CONNECTION_BAD even in ECONNABORTED, like we do in ECONNRESET. So in the wake of commit fe27009cb, this is what lorikeet is doing: @@ -9028,9 +9028,7 @@ CALL terminate_backend_and_wait('fdw_retry_check')

pgsql: Band-aid new postgres_fdw test case to remove error text depende

2020-10-10 Thread Tom Lane
Band-aid new postgres_fdw test case to remove error text dependency. Buildfarm member lorikeet is still failing the test from commit 32a9c0bdf, but now it's down to the should-have-foreseen-it problem that the error message isn't what the expected-output file expects. Let's see if we can get stabl

pgsql: Remove pointless error-code checking in pg_dump/parallel.c.

2020-10-10 Thread Tom Lane
Remove pointless error-code checking in pg_dump/parallel.c. Commit fe27009cb tried to make parallel.c's Windows implementation of piperead() translate Windows socket errors to Unix, but that didn't actually work because TranslateSocketError() is backend-internal code (and not even public there).

pgsql: Minor cleanup for win32stat.c.

2020-10-10 Thread Tom Lane
Minor cleanup for win32stat.c. Fix silly typo in previous commit. Discussion: https://postgr.es/m/cac+axb0g44sbvspc86o_1hwh8tau2pzrmrw6tjt-dkijotx...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/961e07b8ccb56cb3979185b066b503b3d4f7c036 Modified

pgsql: Minor cleanup for win32stat.c.

2020-10-10 Thread Tom Lane
Minor cleanup for win32stat.c. Ensure that CloseHandle() can't clobber the errno we set for failure exits, and make a couple of tweaks for pgindent. Juan José Santamaría Flecha Discussion: https://postgr.es/m/cac+axb0g44sbvspc86o_1hwh8tau2pzrmrw6tjt-dkijotx...@mail.gmail.com Branch -- mast

pgsql: Recognize network-failure errnos as indicating hard connection l

2020-10-10 Thread Tom Lane
Recognize network-failure errnos as indicating hard connection loss. Up to now, only ECONNRESET (and EPIPE, in most but not quite all places) received special treatment in our error handling logic. This patch changes things so that related error codes such as ECONNABORTED are also recognized as i