pgsql: Fix issue with --enable-coverage and the new unicode {de,re}comp

2020-10-23 Thread Michael Paquier
Fix issue with --enable-coverage and the new unicode {de,re}composition code genhtml has been generating the following warning with this new code: WARNING: function data mismatch at /path/src/common/unicode_norm.c:102 HTML coverage reports care about the uniqueness of functions defined in source

pgsql: Add tab completion for ALTER TABLE .. FORCE ROW LEVEL SECURITY i

2020-10-23 Thread Michael Paquier
Add tab completion for ALTER TABLE .. FORCE ROW LEVEL SECURITY in psql This completes both the FORCE and NO FORCE options, NO INHERIT needing a small adjustment. Author: Li Japin Discussion: https://postgr.es/m/[email protected] Branch -- master Details --

pgsql: Fix more portability issues in new amcheck code.

2020-10-23 Thread Tom Lane
Fix more portability issues in new amcheck code. verify_heapam() wasn't being careful to sanity-check tuple line pointers before using them, resulting in SIGBUS on alignment-picky architectures. Fix that, add some more test coverage. Mark Dilger, some tweaking by me Discussion: https://postgr.

pgsql: Allow psql to re-use connection parameters after a connection lo

2020-10-23 Thread Tom Lane
Allow psql to re-use connection parameters after a connection loss. Instead of immediately PQfinish'ing a dead connection, save it aside so that we can still extract its parameters for \connect attempts. (This works because PQconninfo doesn't care whether the PGconn is in CONNECTION_BAD state.) T

pgsql: Fix portability issues in new amcheck test.

2020-10-23 Thread Tom Lane
Fix portability issues in new amcheck test. The tests added by commit 866e24d47 failed on big-endian machines due to lack of attention to endianness considerations. Fix that. While here, improve a few small cosmetic things, such as running it through perltidy. Mark Dilger Discussion: https://

pgsql: Fix broken XML formatting in EXPLAIN output for incremental sort

2020-10-23 Thread Tom Lane
Fix broken XML formatting in EXPLAIN output for incremental sorts. The ExplainCloseGroup arguments for incremental sort usage data didn't match the corresponding ExplainOpenGroup. This only matters for XML-format output, which is probably why we'd not noticed. Daniel Gustafsson, per bug #16683 f

pgsql: Fix broken XML formatting in EXPLAIN output for incremental sort

2020-10-23 Thread Tom Lane
Fix broken XML formatting in EXPLAIN output for incremental sorts. The ExplainCloseGroup arguments for incremental sort usage data didn't match the corresponding ExplainOpenGroup. This only matters for XML-format output, which is probably why we'd not noticed. Daniel Gustafsson, per bug #16683 f

pgsql: doc: Fix order of protocol messages in listing

2020-10-23 Thread Peter Eisentraut
doc: Fix order of protocol messages in listing The order of AuthenticationGSSContinue and AuthenticationSSPI was swapped, based on the other Authentication* protocol messages being listed in subcode order. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/83d727e5b23c

pgsql: doc: Remove reference to pre-8.2 pg_dump behaviour

2020-10-23 Thread Heikki Linnakangas
doc: Remove reference to pre-8.2 pg_dump behaviour The behavioural change in the -t/--table option happened around 15 years ago and there seems little point in keeping it around. Author: Ian Barwick Discussion: https://www.postgresql.org/message-id/CAB8KJ%3Dh-XALik4M7gv-pX48%3D%2BSPWexfaYwa%2ByT