pgsql: Fix cases of discarding result from list API functions

2020-11-10 Thread Peter Eisentraut
Fix cases of discarding result from list API functions Two cases violated list APIs by throwing away the return value. While the code was technically correct, it relied on internal knowledge of the list implementation, and the code wasn't really gaining anything that way. It is planned to make t

pgsql: Fix and simplify some usages of TimestampDifference().

2020-11-10 Thread Tom Lane
Fix and simplify some usages of TimestampDifference(). Introduce TimestampDifferenceMilliseconds() to simplify callers that would rather have the difference in milliseconds, instead of the select()-oriented seconds-and-microseconds format. This gets rid of at least one integer division per call,

pgsql: Fix and simplify some usages of TimestampDifference().

2020-11-10 Thread Tom Lane
Fix and simplify some usages of TimestampDifference(). Introduce TimestampDifferenceMilliseconds() to simplify callers that would rather have the difference in milliseconds, instead of the select()-oriented seconds-and-microseconds format. This gets rid of at least one integer division per call,

pgsql: Fix and simplify some usages of TimestampDifference().

2020-11-10 Thread Tom Lane
Fix and simplify some usages of TimestampDifference(). Introduce TimestampDifferenceMilliseconds() to simplify callers that would rather have the difference in milliseconds, instead of the select()-oriented seconds-and-microseconds format. This gets rid of at least one integer division per call,

pgsql: Fix and simplify some usages of TimestampDifference().

2020-11-10 Thread Tom Lane
Fix and simplify some usages of TimestampDifference(). Introduce TimestampDifferenceMilliseconds() to simplify callers that would rather have the difference in milliseconds, instead of the select()-oriented seconds-and-microseconds format. This gets rid of at least one integer division per call,

pgsql: Fix and simplify some usages of TimestampDifference().

2020-11-10 Thread Tom Lane
Fix and simplify some usages of TimestampDifference(). Introduce TimestampDifferenceMilliseconds() to simplify callers that would rather have the difference in milliseconds, instead of the select()-oriented seconds-and-microseconds format. This gets rid of at least one integer division per call,

pgsql: Fix and simplify some usages of TimestampDifference().

2020-11-10 Thread Tom Lane
Fix and simplify some usages of TimestampDifference(). Introduce TimestampDifferenceMilliseconds() to simplify callers that would rather have the difference in milliseconds, instead of the select()-oriented seconds-and-microseconds format. This gets rid of at least one integer division per call,

pgsql: Fix and simplify some usages of TimestampDifference().

2020-11-10 Thread Tom Lane
Fix and simplify some usages of TimestampDifference(). Introduce TimestampDifferenceMilliseconds() to simplify callers that would rather have the difference in milliseconds, instead of the select()-oriented seconds-and-microseconds format. This gets rid of at least one integer division per call,

pgsql: doc: fix spelling "connction" to "connection"

2020-11-10 Thread Bruce Momjian
doc: fix spelling "connction" to "connection" Was wrong in commit 1a9388bd0f. Reported-by: Tom Lane, Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c

pgsql: doc: fix spelling "connction" to "connection"

2020-11-10 Thread Bruce Momjian
doc: fix spelling "connction" to "connection" Was wrong in commit 1a9388bd0f. Reported-by: Tom Lane, Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1

pgsql: doc: fix spelling "connction" to "connection"

2020-11-10 Thread Bruce Momjian
doc: fix spelling "connction" to "connection" Was wrong in commit 1a9388bd0f. Reported-by: Tom Lane, Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b8b6a012

pgsql: doc: fix spelling "connction" to "connection"

2020-11-10 Thread Bruce Momjian
doc: fix spelling "connction" to "connection" Was wrong in commit 1a9388bd0f. Reported-by: Tom Lane, Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/e

pgsql: doc: fix spelling "connction" to "connection"

2020-11-10 Thread Bruce Momjian
doc: fix spelling "connction" to "connection" Was wrong in commit 1a9388bd0f. Reported-by: Tom Lane, Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL9_5_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f

pgsql: doc: fix spelling "connction" to "connection"

2020-11-10 Thread Bruce Momjian
doc: fix spelling "connction" to "connection" Was wrong in commit 1a9388bd0f. Reported-by: Tom Lane, Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9

pgsql: doc: fix spelling "connction" to "connection"

2020-11-10 Thread Bruce Momjian
doc: fix spelling "connction" to "connection" Was wrong in commit 1a9388bd0f. Reported-by: Tom Lane, Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.5 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1

pgsql: Work around cross-version-upgrade issues created by commit 9e38c

2020-11-10 Thread Tom Lane
Work around cross-version-upgrade issues created by commit 9e38c2bb5. Summarily changing the STYPE of regression-test aggregates that depend on array_append or array_cat is an issue for the buildfarm's cross-version-upgrade tests, because those aggregates (as defined in the back branches) now won'

pgsql: Work around cross-version-upgrade issues created by commit 9e38c

2020-11-10 Thread Tom Lane
Work around cross-version-upgrade issues created by commit 9e38c2bb5. Summarily changing the STYPE of regression-test aggregates that depend on array_append or array_cat is an issue for the buildfarm's cross-version-upgrade tests, because those aggregates (as defined in the back branches) now won'

pgsql: Work around cross-version-upgrade issues created by commit 9e38c

2020-11-10 Thread Tom Lane
Work around cross-version-upgrade issues created by commit 9e38c2bb5. Summarily changing the STYPE of regression-test aggregates that depend on array_append or array_cat is an issue for the buildfarm's cross-version-upgrade tests, because those aggregates (as defined in the back branches) now won'

pgsql: Work around cross-version-upgrade issues created by commit 9e38c

2020-11-10 Thread Tom Lane
Work around cross-version-upgrade issues created by commit 9e38c2bb5. Summarily changing the STYPE of regression-test aggregates that depend on array_append or array_cat is an issue for the buildfarm's cross-version-upgrade tests, because those aggregates (as defined in the back branches) now won'

pgsql: Work around cross-version-upgrade issues created by commit 9e38c

2020-11-10 Thread Tom Lane
Work around cross-version-upgrade issues created by commit 9e38c2bb5. Summarily changing the STYPE of regression-test aggregates that depend on array_append or array_cat is an issue for the buildfarm's cross-version-upgrade tests, because those aggregates (as defined in the back branches) now won'

pgsql: Work around cross-version-upgrade issues created by commit 9e38c

2020-11-10 Thread Tom Lane
Work around cross-version-upgrade issues created by commit 9e38c2bb5. Summarily changing the STYPE of regression-test aggregates that depend on array_append or array_cat is an issue for the buildfarm's cross-version-upgrade tests, because those aggregates (as defined in the back branches) now won'

pgsql: Work around cross-version-upgrade issues created by commit 9e38c

2020-11-10 Thread Tom Lane
Work around cross-version-upgrade issues created by commit 9e38c2bb5. Summarily changing the STYPE of regression-test aggregates that depend on array_append or array_cat is an issue for the buildfarm's cross-version-upgrade tests, because those aggregates (as defined in the back branches) now won'

pgsql: Tag refs/tags/REL_11_10 was created

2020-11-10 Thread noreply
Tag refs/tags/REL_11_10 was created.

pgsql: Tag refs/tags/REL9_6_20 was created

2020-11-10 Thread noreply
Tag refs/tags/REL9_6_20 was created.

pgsql: Tag refs/tags/REL9_5_24 was created

2020-11-10 Thread noreply
Tag refs/tags/REL9_5_24 was created.

pgsql: Tag refs/tags/REL_13_1 was created

2020-11-10 Thread noreply
Tag refs/tags/REL_13_1 was created.

pgsql: Tag refs/tags/REL_12_5 was created

2020-11-10 Thread noreply
Tag refs/tags/REL_12_5 was created.

pgsql: Tag refs/tags/REL_10_15 was created

2020-11-10 Thread noreply
Tag refs/tags/REL_10_15 was created.

Re: pgsql: Declare assorted array functions using anycompatible not anyelem

2020-11-10 Thread Tom Lane
Andrew Dunstan writes: > On 11/9/20 5:41 PM, Tom Lane wrote: >> What I have in mind to apply to 9.5 through 13 is per attached. > You also need to modify first_el_agg_any. ... doh. That one is a little messier because there's no equally useful substitute function. What I'm inclined to do for t

pgsql: pg_rewind: Fix thinko in parsing target WAL.

2020-11-10 Thread Heikki Linnakangas
pg_rewind: Fix thinko in parsing target WAL. It's entirely possible to see WAL for a relation that doesn't exist in the target anymore. That happens when the relation was dropped later. The refactoring in commit eb00f1d4b broke that case, by sanity-checking the file type in the target before check

Re: pgsql: Declare assorted array functions using anycompatible not anyelem

2020-11-10 Thread Andrew Dunstan
On 11/9/20 5:41 PM, Tom Lane wrote: > > What I have in mind to apply to 9.5 through 13 is per attached. > You could either redefine the aggregate similarly in 9.2-9.4, > or just drop it. I doubt the latter leads to any interesting > loss of coverage for xversion upgrade, as there's plenty of oth

pgsql: Fix out of date comment

2020-11-10 Thread Magnus Hagander
Fix out of date comment Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3f16cb505d1d734674da2a2cbf2104ceae22f9b4 Modified Files -- src/backend/postmaster/postmaster.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

pgsql: Remove -o option to postmaster

2020-11-10 Thread Magnus Hagander
Remove -o option to postmaster This option was declared obsolete many years ago. Reviewed-By: Tom Lane Discussion: https://postgr.es/m/CABUevEyOE=9CQwZm2j=vwp5+6olcsoxn9pbjk8gyrdktzmf...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d2e4bf688e16f9