Re: pgsql: Test decoding of two-phase transactions during the build of a co

2021-01-08 Thread Tom Lane
Amit Kapila writes: > I think I know whats going on here. I have responded to the thread on > pgsql-hackers [1]. Ah, yeah, the autovacuum theory fits the facts: chipmunk is pretty slow, and it's not failed 100% of the time. regards, tom lane

Re: pgsql: Test decoding of two-phase transactions during the build of a co

2021-01-08 Thread Amit Kapila
On Sat, Jan 9, 2021 at 12:18 PM Amit Kapila wrote: > > On Sat, Jan 9, 2021 at 11:17 AM Tom Lane wrote: > > > > > > I think we've seen this extra-transactions symptom before, > > but I don't recall the details at this late hour. > > > > I'll look into it. > I think I know whats going on here. I h

Re: pgsql: Test decoding of two-phase transactions during the build of a co

2021-01-08 Thread Amit Kapila
On Sat, Jan 9, 2021 at 11:17 AM Tom Lane wrote: > > Amit Kapila writes: > > Test decoding of two-phase transactions during the build of a consistent > > snapshot. > > It seems this test case isn't 100% stable: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=chipmunk&dt=2021-01-08%202

Re: pgsql: Test decoding of two-phase transactions during the build of a co

2021-01-08 Thread Tom Lane
Amit Kapila writes: > Test decoding of two-phase transactions during the build of a consistent > snapshot. It seems this test case isn't 100% stable: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=chipmunk&dt=2021-01-08%2023%3A56%3A57 == output_iso/regression.d

pgsql: Fix plpgsql tests for debug_invalidate_system_caches_always.

2021-01-08 Thread Tom Lane
Fix plpgsql tests for debug_invalidate_system_caches_always. Commit c9d529848 resulted in having a couple more places where the error context stack for a failure varies depending on debug_invalidate_system_caches_always (nee CLOBBER_CACHE_ALWAYS). This is not very surprising, since we have to re-p

pgsql: Fix ancient bug in parsing of BRE-mode regular expressions.

2021-01-08 Thread Tom Lane
Fix ancient bug in parsing of BRE-mode regular expressions. brenext(), when parsing a '*' quantifier, forgot to return any "value" for the token; per the equivalent case in next(), it should return value 1 to indicate that greedy rather than non-greedy behavior is wanted. The result is that the c

pgsql: Fix ancient bug in parsing of BRE-mode regular expressions.

2021-01-08 Thread Tom Lane
Fix ancient bug in parsing of BRE-mode regular expressions. brenext(), when parsing a '*' quantifier, forgot to return any "value" for the token; per the equivalent case in next(), it should return value 1 to indicate that greedy rather than non-greedy behavior is wanted. The result is that the c

pgsql: Fix ancient bug in parsing of BRE-mode regular expressions.

2021-01-08 Thread Tom Lane
Fix ancient bug in parsing of BRE-mode regular expressions. brenext(), when parsing a '*' quantifier, forgot to return any "value" for the token; per the equivalent case in next(), it should return value 1 to indicate that greedy rather than non-greedy behavior is wanted. The result is that the c

pgsql: Fix ancient bug in parsing of BRE-mode regular expressions.

2021-01-08 Thread Tom Lane
Fix ancient bug in parsing of BRE-mode regular expressions. brenext(), when parsing a '*' quantifier, forgot to return any "value" for the token; per the equivalent case in next(), it should return value 1 to indicate that greedy rather than non-greedy behavior is wanted. The result is that the c

pgsql: Fix ancient bug in parsing of BRE-mode regular expressions.

2021-01-08 Thread Tom Lane
Fix ancient bug in parsing of BRE-mode regular expressions. brenext(), when parsing a '*' quantifier, forgot to return any "value" for the token; per the equivalent case in next(), it should return value 1 to indicate that greedy rather than non-greedy behavior is wanted. The result is that the c

pgsql: Fix ancient bug in parsing of BRE-mode regular expressions.

2021-01-08 Thread Tom Lane
Fix ancient bug in parsing of BRE-mode regular expressions. brenext(), when parsing a '*' quantifier, forgot to return any "value" for the token; per the equivalent case in next(), it should return value 1 to indicate that greedy rather than non-greedy behavior is wanted. The result is that the c

pgsql: Fix ancient bug in parsing of BRE-mode regular expressions.

2021-01-08 Thread Tom Lane
Fix ancient bug in parsing of BRE-mode regular expressions. brenext(), when parsing a '*' quantifier, forgot to return any "value" for the token; per the equivalent case in next(), it should return value 1 to indicate that greedy rather than non-greedy behavior is wanted. The result is that the c