Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().

2021-02-22 Thread Thomas Munro
On Tue, Feb 23, 2021 at 7:03 PM Peter Eisentraut wrote: > On 22.02.21 12:28, Thomas Munro wrote: > > pg_collation_actual_version() -> pg_collation_current_version(). > > > > The new name seems a bit more natural. > > > > Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com > > I d

Re: pgsql: pg_collation_actual_version() -> pg_collation_current_version().

2021-02-22 Thread Peter Eisentraut
On 22.02.21 12:28, Thomas Munro wrote: pg_collation_actual_version() -> pg_collation_current_version(). The new name seems a bit more natural. Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com I don't find where this change was discussed in that thread. I specifically ch

pgsql: Fix an oversight in ReorderBufferFinishPrepared.

2021-02-22 Thread Amit Kapila
Fix an oversight in ReorderBufferFinishPrepared. We don't have anything to decode in a transaction if ReorderBufferTXN doesn't exist by the time we decode the commit prepared. So don't create a new ReorderBufferTXN here. This is an oversight in commit a271a1b5. Reported-by: Markus Wanner Discussi

pgsql: Change the error message for logical replication authentication

2021-02-22 Thread Amit Kapila
Change the error message for logical replication authentication failure. The authentication failure error message wasn't distinguishing whether it is a physical replication or logical replication connection failure and was giving incomplete information on what led to failure in case of logical rep

pgsql: Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls

2021-02-22 Thread Alvaro Herrera
Remove pointless HeapTupleHeaderIndicatesMovedPartitions calls Pavan Deolasee recently noted that a few of the HeapTupleHeaderIndicatesMovedPartitions calls added by commit 5db6df0c0117 are useless, since they are done after comparing t_self with t_ctid. But because t_self can never be set to the

pgsql: Fix typo

2021-02-22 Thread Alvaro Herrera
Fix typo Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/6a03369a71d4a7dc5b8d928aab775ddd28b72494 Modified Files -- src/backend/storage/ipc/procarray.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Fix docs build for website styles

2021-02-22 Thread Magnus Hagander
Fix docs build for website styles Building the docs with STYLE=website referenced a stylesheet that long longer exists on the website, since we changed it to use versioned references. To make it less likely for this to happen again, point to a single stylesheet on the website which will in turn i

pgsql: Fix docs build for website styles

2021-02-22 Thread Magnus Hagander
Fix docs build for website styles Building the docs with STYLE=website referenced a stylesheet that long longer exists on the website, since we changed it to use versioned references. To make it less likely for this to happen again, point to a single stylesheet on the website which will in turn i

pgsql: Hide internal error for pg_collation_actual_version().

2021-02-22 Thread Thomas Munro
Hide internal error for pg_collation_actual_version(). Instead of an unsightly internal "cache lookup failed" message, just return NULL for bad OIDs, as is the convention for other similar things. Reported-by: Justin Pryzby Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/2021011721

pgsql: Refactor get_collation_current_version().

2021-02-22 Thread Thomas Munro
Refactor get_collation_current_version(). The code paths for three different OSes finished up with three different ways of excluding C[.xxx] and POSIX from consideration. Merge them. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com Branch -

pgsql: Tab-complete CREATE COLLATION.

2021-02-22 Thread Thomas Munro
Tab-complete CREATE COLLATION. Reviewed-by: Michael Paquier Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5bc09a74719dfeb6c4cebb311b81385c508459a8 Modified Files -- src/bin/psql/ta

pgsql: pg_collation_actual_version() -> pg_collation_current_version().

2021-02-22 Thread Thomas Munro
pg_collation_actual_version() -> pg_collation_current_version(). The new name seems a bit more natural. Discussion: https://postgr.es/m/20210117215940.GE8560%40telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9cf184cc0599b6e65e7e5ecd9d91cd42e278bcd8 M

pgsql: Initialize atomic variable waitStart in PGPROC, at postmaster st

2021-02-22 Thread Fujii Masao
Initialize atomic variable waitStart in PGPROC, at postmaster startup. Commit 46d6e5f567 added the atomic variable "waitStart" into PGPROC struct, to store the time at which wait for lock acquisition started. Previously this variable was initialized every time each backend started. Instead, this c