Re: pgsql: Allow configurable LZ4 TOAST compression.

2021-03-19 Thread Andrew Dunstan
On 3/19/21 3:37 PM, Robert Haas wrote: > Allow configurable LZ4 TOAST compression. > Looks like this has run into the heuristic in the buildfarm's cross version upgrade module. This allows for up to 2000 lines of diff between the dumps of the original and upgraded database. This has blown out b

pgsql: Provide recovery_init_sync_method=syncfs.

2021-03-19 Thread Thomas Munro
Provide recovery_init_sync_method=syncfs. Since commit 2ce439f3 we have opened every file in the data directory and called fsync() at the start of crash recovery. This can be very slow if there are many files, leading to field complaints of systems taking minutes or even hours to begin crash reco

pgsql: Use lfirst_int in cmp_list_len_contents_asc

2021-03-19 Thread Tomas Vondra
Use lfirst_int in cmp_list_len_contents_asc The function added in be45be9c33 is comparing integer lists (IntList) by length and contents, but there were two bugs. Firstly, it used intVal() to extract the value, but that's for Value nodes, not for extracting int values from IntList. Secondly, it

pgsql: Fix use-after-ReleaseSysCache problem in ATExecAlterColumnType.

2021-03-19 Thread Robert Haas
Fix use-after-ReleaseSysCache problem in ATExecAlterColumnType. Introduced by commit bbe0a81db69bd10bd166907c3701492a29aca294. Per buildfarm member prion. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d00fbdc431192c3e429b3e91c43d364e5c7ba680 Modified Files -

pgsql: Allow configurable LZ4 TOAST compression.

2021-03-19 Thread Robert Haas
Allow configurable LZ4 TOAST compression. There is now a per-column COMPRESSION option which can be set to pglz (the default, and the only option in up until now) or lz4. Or, if you like, you can set the new default_toast_compression GUC to lz4, and then that will be the default for new table colu

pgsql: Fix race condition in remove_temp_files_after_crash TAP test

2021-03-19 Thread Tomas Vondra
Fix race condition in remove_temp_files_after_crash TAP test The TAP test was written so that it was not waiting for the correct SQL command, but for output from the preceding one. This resulted in race conditions, allowing the commands to run in a different order, not block as expected and so on