Re: pgsql: Implement streaming mode in ReorderBuffer.

2021-04-27 Thread Amit Kapila
On Wed, Apr 28, 2021 at 8:51 AM Tom Lane wrote: > > Amit Kapila writes: > > On Wed, Apr 28, 2021 at 5:31 AM Tom Lane wrote: > >> It's griping about this: > >> curtxn->concurrent_abort = true; > >> and I think it's got a point. There is little if any reason to have > >> confidence t

Re: pgsql: Implement streaming mode in ReorderBuffer.

2021-04-27 Thread Tom Lane
Amit Kapila writes: > On Wed, Apr 28, 2021 at 5:31 AM Tom Lane wrote: >> It's griping about this: >> curtxn->concurrent_abort = true; >> and I think it's got a point. There is little if any reason to have >> confidence that curtxn must be non-NULL when this code is reached, >> becau

pgsql: Fix use-after-release issue with pg_identify_object_as_address()

2021-04-27 Thread Michael Paquier
Fix use-after-release issue with pg_identify_object_as_address() Spotted by buildfarm member prion, with -DRELCACHE_FORCE_RELEASE. Introduced in f7aab36. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL_13_STABLE Details --- https://

pgsql: Fix use-after-release issue with pg_identify_object_as_address()

2021-04-27 Thread Michael Paquier
Fix use-after-release issue with pg_identify_object_as_address() Spotted by buildfarm member prion, with -DRELCACHE_FORCE_RELEASE. Introduced in f7aab36. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL_10_STABLE Details --- https://

pgsql: Fix use-after-release issue with pg_identify_object_as_address()

2021-04-27 Thread Michael Paquier
Fix use-after-release issue with pg_identify_object_as_address() Spotted by buildfarm member prion, with -DRELCACHE_FORCE_RELEASE. Introduced in f7aab36. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL_11_STABLE Details --- https://

pgsql: Fix use-after-release issue with pg_identify_object_as_address()

2021-04-27 Thread Michael Paquier
Fix use-after-release issue with pg_identify_object_as_address() Spotted by buildfarm member prion, with -DRELCACHE_FORCE_RELEASE. Introduced in f7aab36. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL9_6_STABLE Details --- https://

pgsql: Fix use-after-release issue with pg_identify_object_as_address()

2021-04-27 Thread Michael Paquier
Fix use-after-release issue with pg_identify_object_as_address() Spotted by buildfarm member prion, with -DRELCACHE_FORCE_RELEASE. Introduced in f7aab36. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- master Details --- https://git.pos

pgsql: Fix use-after-release issue with pg_identify_object_as_address()

2021-04-27 Thread Michael Paquier
Fix use-after-release issue with pg_identify_object_as_address() Spotted by buildfarm member prion, with -DRELCACHE_FORCE_RELEASE. Introduced in f7aab36. Discussion: https://postgr.es/m/[email protected] Backpatch-through: 9.6 Branch -- REL_12_STABLE Details --- https://

Re: pgsql: Fix pg_identify_object_as_address() with event triggers

2021-04-27 Thread Michael Paquier
On Tue, Apr 27, 2021 at 10:44:08PM -0400, Tom Lane wrote: > Looks like this has issues under RELCACHE_FORCE_RELEASE > and/or CATCACHE_FORCE_RELEASE: > > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2021-04-28%2002%3A28%3A04 Yes, this is missing a pstrdup() for the event trigge

Re: pgsql: Implement streaming mode in ReorderBuffer.

2021-04-27 Thread Amit Kapila
On Wed, Apr 28, 2021 at 5:31 AM Tom Lane wrote: > > Amit Kapila writes: > > Implement streaming mode in ReorderBuffer. > > I notice that new buildfarm member wrasse is unhappy about some of the > code added by this commit: > > "/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/back

Re: pgsql: Fix pg_identify_object_as_address() with event triggers

2021-04-27 Thread Tom Lane
Michael Paquier writes: > Fix pg_identify_object_as_address() with event triggers Looks like this has issues under RELCACHE_FORCE_RELEASE and/or CATCACHE_FORCE_RELEASE: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion&dt=2021-04-28%2002%3A28%3A04 regards, to

pgsql: Fix pg_identify_object_as_address() with event triggers

2021-04-27 Thread Michael Paquier
Fix pg_identify_object_as_address() with event triggers Attempting to use this function with event triggers failed, as, since its introduction in a676201, this code has never associated an object name with event triggers. This addresses the failure by adding the event trigger name to the set defi

pgsql: Fix pg_identify_object_as_address() with event triggers

2021-04-27 Thread Michael Paquier
Fix pg_identify_object_as_address() with event triggers Attempting to use this function with event triggers failed, as, since its introduction in a676201, this code has never associated an object name with event triggers. This addresses the failure by adding the event trigger name to the set defi

pgsql: Fix pg_identify_object_as_address() with event triggers

2021-04-27 Thread Michael Paquier
Fix pg_identify_object_as_address() with event triggers Attempting to use this function with event triggers failed, as, since its introduction in a676201, this code has never associated an object name with event triggers. This addresses the failure by adding the event trigger name to the set defi

pgsql: Fix pg_identify_object_as_address() with event triggers

2021-04-27 Thread Michael Paquier
Fix pg_identify_object_as_address() with event triggers Attempting to use this function with event triggers failed, as, since its introduction in a676201, this code has never associated an object name with event triggers. This addresses the failure by adding the event trigger name to the set defi

pgsql: Fix pg_identify_object_as_address() with event triggers

2021-04-27 Thread Michael Paquier
Fix pg_identify_object_as_address() with event triggers Attempting to use this function with event triggers failed, as, since its introduction in a676201, this code has never associated an object name with event triggers. This addresses the failure by adding the event trigger name to the set defi

pgsql: Fix pg_identify_object_as_address() with event triggers

2021-04-27 Thread Michael Paquier
Fix pg_identify_object_as_address() with event triggers Attempting to use this function with event triggers failed, as, since its introduction in a676201, this code has never associated an object name with event triggers. This addresses the failure by adding the event trigger name to the set defi

Re: pgsql: Implement streaming mode in ReorderBuffer.

2021-04-27 Thread Tom Lane
Amit Kapila writes: > Implement streaming mode in ReorderBuffer. I notice that new buildfarm member wrasse is unhappy about some of the code added by this commit: "/export/home/nm/farm/studio64v12_6/HEAD/pgsql.build/../pgsql/src/backend/replication/logical/reorderbuffer.c", line 2510: Warning:

pgsql: Improve logic in PostgresVersion.pm

2021-04-27 Thread Andrew Dunstan
Improve logic in PostgresVersion.pm Handle the situation where perl swaps the order of operands of the comparison operator. See `perldoc overload` for details: The third argument is set to TRUE if (and only if) the two operands have been swapped. Perl may do this to ensure that the first argument

pgsql: doc: Review for "Allow TRUNCATE command to truncate foreign tabl

2021-04-27 Thread Fujii Masao
doc: Review for "Allow TRUNCATE command to truncate foreign tables". Typos, corrections and language improvements in the docs. Author: Justin Pryzby, Fujii Masao Reviewed-by: Bharath Rupireddy, Justin Pryzby, Fujii Masao Discussion: https://postgr.es/m/[email protected] Branch