pgsql: pg_amcheck: Message style and formatting improvements

2021-05-12 Thread Peter Eisentraut
pg_amcheck: Message style and formatting improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/5a73a9e3b5b24cf2dd90ab4a7ae3724b2c12a0cc Modified Files -- src/bin/pg_amcheck/pg_amcheck.c | 90 - 1 file changed

pgsql: Fix tests for replication slots stats.

2021-05-12 Thread Amit Kapila
Fix tests for replication slots stats. Some of the tests were not considering that the slot's spill stats could be received by the stats collector after we have reset the stats. Remove those tests and don't check total bytes decoded and sent to output plugin in the spilled stats test as we can sen

pgsql: doc: update PG 14 release notes based on current feedback

2021-05-12 Thread Bruce Momjian
doc: update PG 14 release notes based on current feedback Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b35f827b68dc1e761e17f621fbf17c3ecd073cb0 Modified Files -- doc/src/sgml/release-14.sgml | 85 ++-- 1 file ch

pgsql: Make saner the tab completion of INSERT and DELETE in psql

2021-05-12 Thread Michael Paquier
Make saner the tab completion of INSERT and DELETE in psql When specified directly as DML queries, INSERT was not getting always completed to "INSERT INTO", same for DELETE with "DELETE FROM". This makes the completion behavior more consistent for both commands, saving a few keystrokes. Commands

pgsql: Rename the logical replication global "wrconn"

2021-05-12 Thread Alvaro Herrera
Rename the logical replication global "wrconn" The worker.c global wrconn is only meant to be used by logical apply/ tablesync workers, but there are other variables with the same name. To reduce future confusion rename the global from "wrconn" to "LogRepWorkerWalRcvConn". While this is just cosm

pgsql: Rename the logical replication global "wrconn"

2021-05-12 Thread Alvaro Herrera
Rename the logical replication global "wrconn" The worker.c global wrconn is only meant to be used by logical apply/ tablesync workers, but there are other variables with the same name. To reduce future confusion rename the global from "wrconn" to "LogRepWorkerWalRcvConn". While this is just cosm

pgsql: Rename the logical replication global "wrconn"

2021-05-12 Thread Alvaro Herrera
Rename the logical replication global "wrconn" The worker.c global wrconn is only meant to be used by logical apply/ tablesync workers, but there are other variables with the same name. To reduce future confusion rename the global from "wrconn" to "LogRepWorkerWalRcvConn". While this is just cosm

pgsql: Rename the logical replication global "wrconn"

2021-05-12 Thread Alvaro Herrera
Rename the logical replication global "wrconn" The worker.c global wrconn is only meant to be used by logical apply/ tablesync workers, but there are other variables with the same name. To reduce future confusion rename the global from "wrconn" to "LogRepWorkerWalRcvConn". While this is just cosm

pgsql: Rename the logical replication global "wrconn"

2021-05-12 Thread Alvaro Herrera
Rename the logical replication global "wrconn" The worker.c global wrconn is only meant to be used by logical apply/ tablesync workers, but there are other variables with the same name. To reduce future confusion rename the global from "wrconn" to "LogRepWorkerWalRcvConn". While this is just cosm

pgsql: Double-space commands in system_constraints.sql/system_functions

2021-05-12 Thread Tom Lane
Double-space commands in system_constraints.sql/system_functions.sql. Previously, any error reported by the backend while reading system_constraints.sql would report the entire file, not just the particular command it was working on. (Ask me how I know.) Likewise, there were chunks of system_fun

Re: pgsql: Improve wording of some pg_upgrade failure reports.

2021-05-12 Thread Tom Lane
Peter Eisentraut writes: > On 29.04.21 21:40, Tom Lane wrote: >> Don't advocate dropping a whole table when dropping a column would >> serve. While at it, try to make the layout of these messages a >> bit cleaner and more consistent. > I don't understand how this makes the message layout cleaner

Re: pgsql: Improve wording of some pg_upgrade failure reports.

2021-05-12 Thread Peter Eisentraut
On 29.04.21 21:40, Tom Lane wrote: Improve wording of some pg_upgrade failure reports. Don't advocate dropping a whole table when dropping a column would serve. While at it, try to make the layout of these messages a bit cleaner and more consistent. I don't understand how this makes the mes

pgsql: Doc: update bki.sgml's statements about OID ranges.

2021-05-12 Thread Tom Lane
Doc: update bki.sgml's statements about OID ranges. Commit ab596105b neglected to make the docs match the code. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1f9b0e6938054515b8c9df545437c3d347eed683 Modified Files -- doc/src/sgml/bki.sgml | 4 ++-- 1 f

pgsql: Do pre-release housekeeping on catalog data.

2021-05-12 Thread Tom Lane
Do pre-release housekeeping on catalog data. Run renumber_oids.pl to move high-numbered OIDs down, as per pre-beta tasks specified by RELEASE_CHANGES. For reference, the command was ./renumber_oids.pl --first-mapped-oid 8000 --target-oid 6150 Branch -- master Details --- https://git.pos

pgsql: Initial pgindent and pgperltidy run for v14.

2021-05-12 Thread Tom Lane
Initial pgindent and pgperltidy run for v14. Also "make reformat-dat-files". The only change worthy of note is that pgindent messed up the formatting of launcher.c's struct LogicalRepWorkerId, which led me to notice that that struct wasn't used at all anymore, so I just took it out. Branch -