pgsql: Improve handling of dropped objects in pg_event_trigger_ddl_comm

2021-06-13 Thread Michael Paquier
Improve handling of dropped objects in pg_event_trigger_ddl_commands() An object found as dropped when digging into the list of objects returned by pg_event_trigger_ddl_commands() could cause a cache lookup error, as the calls grabbing for the object address and the type name would fail if the obj

pgsql: Remove forced toast recompression in VACUUM FULL/CLUSTER

2021-06-13 Thread Michael Paquier
Remove forced toast recompression in VACUUM FULL/CLUSTER The extra checks added by the recompression of toast data introduced in bbe0a81 is proving to have a performance impact on VACUUM or CLUSTER even if no recompression is done. This is more noticeable with more toastable columns that contain

pgsql: Work around portability issue with newer versions of mktime().

2021-06-13 Thread Tom Lane
Work around portability issue with newer versions of mktime(). Recent glibc versions have made mktime() fail if tm_isdst is inconsistent with the prevailing timezone; in particular it fails for tm_isdst = 1 when the zone is UTC. (This seems wildly inconsistent with the POSIX-mandated treatment of

pgsql: Work around portability issue with newer versions of mktime().

2021-06-13 Thread Tom Lane
Work around portability issue with newer versions of mktime(). Recent glibc versions have made mktime() fail if tm_isdst is inconsistent with the prevailing timezone; in particular it fails for tm_isdst = 1 when the zone is UTC. (This seems wildly inconsistent with the POSIX-mandated treatment of

pgsql: Work around portability issue with newer versions of mktime().

2021-06-13 Thread Tom Lane
Work around portability issue with newer versions of mktime(). Recent glibc versions have made mktime() fail if tm_isdst is inconsistent with the prevailing timezone; in particular it fails for tm_isdst = 1 when the zone is UTC. (This seems wildly inconsistent with the POSIX-mandated treatment of

pgsql: Work around portability issue with newer versions of mktime().

2021-06-13 Thread Tom Lane
Work around portability issue with newer versions of mktime(). Recent glibc versions have made mktime() fail if tm_isdst is inconsistent with the prevailing timezone; in particular it fails for tm_isdst = 1 when the zone is UTC. (This seems wildly inconsistent with the POSIX-mandated treatment of

pgsql: Work around portability issue with newer versions of mktime().

2021-06-13 Thread Tom Lane
Work around portability issue with newer versions of mktime(). Recent glibc versions have made mktime() fail if tm_isdst is inconsistent with the prevailing timezone; in particular it fails for tm_isdst = 1 when the zone is UTC. (This seems wildly inconsistent with the POSIX-mandated treatment of

pgsql: Work around portability issue with newer versions of mktime().

2021-06-13 Thread Tom Lane
Work around portability issue with newer versions of mktime(). Recent glibc versions have made mktime() fail if tm_isdst is inconsistent with the prevailing timezone; in particular it fails for tm_isdst = 1 when the zone is UTC. (This seems wildly inconsistent with the POSIX-mandated treatment of

pgsql: Further tweaks to stuck_on_old_timeline recovery test

2021-06-13 Thread Andrew Dunstan
Further tweaks to stuck_on_old_timeline recovery test Translate path slashes on target directory path. This was confusing old branches, but is applied to all branches for the sake of uniformity. Perl is perfectly able to understand paths with forward slashes. Along the way, restore the previous a

pgsql: Further tweaks to stuck_on_old_timeline recovery test

2021-06-13 Thread Andrew Dunstan
Further tweaks to stuck_on_old_timeline recovery test Translate path slashes on target directory path. This was confusing old branches, but is applied to all branches for the sake of uniformity. Perl is perfectly able to understand paths with forward slashes. Along the way, restore the previous a

pgsql: Further tweaks to stuck_on_old_timeline recovery test

2021-06-13 Thread Andrew Dunstan
Further tweaks to stuck_on_old_timeline recovery test Translate path slashes on target directory path. This was confusing old branches, but is applied to all branches for the sake of uniformity. Perl is perfectly able to understand paths with forward slashes. Along the way, restore the previous a

pgsql: Further tweaks to stuck_on_old_timeline recovery test

2021-06-13 Thread Andrew Dunstan
Further tweaks to stuck_on_old_timeline recovery test Translate path slashes on target directory path. This was confusing old branches, but is applied to all branches for the sake of uniformity. Perl is perfectly able to understand paths with forward slashes. Along the way, restore the previous a

pgsql: Further tweaks to stuck_on_old_timeline recovery test

2021-06-13 Thread Andrew Dunstan
Further tweaks to stuck_on_old_timeline recovery test Translate path slashes on target directory path. This was confusing old branches, but is applied to all branches for the sake of uniformity. Perl is perfectly able to understand paths with forward slashes. Along the way, restore the previous a

pgsql: Further tweaks to stuck_on_old_timeline recovery test

2021-06-13 Thread Andrew Dunstan
Further tweaks to stuck_on_old_timeline recovery test Translate path slashes on target directory path. This was confusing old branches, but is applied to all branches for the sake of uniformity. Perl is perfectly able to understand paths with forward slashes. Along the way, restore the previous a

pgsql: Ignore more environment variables in pg_regress.c

2021-06-13 Thread Michael Paquier
Ignore more environment variables in pg_regress.c This is similar to the work done in 8279f68 for TestLib.pm, where environment variables set may cause unwanted failures if using a temporary installation with pg_regress. The list of variables reset is adjusted in each stable branch depending on w

pgsql: Ignore more environment variables in pg_regress.c

2021-06-13 Thread Michael Paquier
Ignore more environment variables in pg_regress.c This is similar to the work done in 8279f68 for TestLib.pm, where environment variables set may cause unwanted failures if using a temporary installation with pg_regress. The list of variables reset is adjusted in each stable branch depending on w

pgsql: Ignore more environment variables in pg_regress.c

2021-06-13 Thread Michael Paquier
Ignore more environment variables in pg_regress.c This is similar to the work done in 8279f68 for TestLib.pm, where environment variables set may cause unwanted failures if using a temporary installation with pg_regress. The list of variables reset is adjusted in each stable branch depending on w

pgsql: Ignore more environment variables in pg_regress.c

2021-06-13 Thread Michael Paquier
Ignore more environment variables in pg_regress.c This is similar to the work done in 8279f68 for TestLib.pm, where environment variables set may cause unwanted failures if using a temporary installation with pg_regress. The list of variables reset is adjusted in each stable branch depending on w

pgsql: Ignore more environment variables in pg_regress.c

2021-06-13 Thread Michael Paquier
Ignore more environment variables in pg_regress.c This is similar to the work done in 8279f68 for TestLib.pm, where environment variables set may cause unwanted failures if using a temporary installation with pg_regress. The list of variables reset is adjusted in each stable branch depending on w

pgsql: Ignore more environment variables in pg_regress.c

2021-06-13 Thread Michael Paquier
Ignore more environment variables in pg_regress.c This is similar to the work done in 8279f68 for TestLib.pm, where environment variables set may cause unwanted failures if using a temporary installation with pg_regress. The list of variables reset is adjusted in each stable branch depending on w