pgsql: Fix decoding of speculative aborts.

2021-06-14 Thread Amit Kapila
Fix decoding of speculative aborts. During decoding for speculative inserts, we were relying for cleaning toast hash on confirmation records or next change records. But that could lead to multiple problems (a) memory leak if there is neither a confirmation record nor any other record after toast i

pgsql: Fix decoding of speculative aborts.

2021-06-14 Thread Amit Kapila
Fix decoding of speculative aborts. During decoding for speculative inserts, we were relying for cleaning toast hash on confirmation records or next change records. But that could lead to multiple problems (a) memory leak if there is neither a confirmation record nor any other record after toast i

pgsql: Fix decoding of speculative aborts.

2021-06-14 Thread Amit Kapila
Fix decoding of speculative aborts. During decoding for speculative inserts, we were relying for cleaning toast hash on confirmation records or next change records. But that could lead to multiple problems (a) memory leak if there is neither a confirmation record nor any other record after toast i

pgsql: Fix decoding of speculative aborts.

2021-06-14 Thread Amit Kapila
Fix decoding of speculative aborts. During decoding for speculative inserts, we were relying for cleaning toast hash on confirmation records or next change records. But that could lead to multiple problems (a) memory leak if there is neither a confirmation record nor any other record after toast i

pgsql: Fix decoding of speculative aborts.

2021-06-14 Thread Amit Kapila
Fix decoding of speculative aborts. During decoding for speculative inserts, we were relying for cleaning toast hash on confirmation records or next change records. But that could lead to multiple problems (a) memory leak if there is neither a confirmation record nor any other record after toast i

pgsql: Fix decoding of speculative aborts.

2021-06-14 Thread Amit Kapila
Fix decoding of speculative aborts. During decoding for speculative inserts, we were relying for cleaning toast hash on confirmation records or next change records. But that could lead to multiple problems (a) memory leak if there is neither a confirmation record nor any other record after toast i

pgsql: Update variant expected-result file.

2021-06-14 Thread Tom Lane
Update variant expected-result file. This should have been updated in d2d8a229b, but it was overlooked. According to 31a877f18 which added it, this file is meant to show the results you get under default_transaction_isolation = serializable. We've largely lost track of that goal in other isolation

pgsql: Update variant expected-result file.

2021-06-14 Thread Tom Lane
Update variant expected-result file. This should have been updated in d2d8a229b, but it was overlooked. According to 31a877f18 which added it, this file is meant to show the results you get under default_transaction_isolation = serializable. We've largely lost track of that goal in other isolation

pgsql: Remove orphaned expected-result file.

2021-06-14 Thread Tom Lane
Remove orphaned expected-result file. This should have been removed in 43e084197, which removed the corresponding spec file. Noted while fooling about with the isolationtester. Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0483ae7c513bf2604443fa681811b4a51

pgsql: Remove orphaned expected-result file.

2021-06-14 Thread Tom Lane
Remove orphaned expected-result file. This should have been removed in 43e084197, which removed the corresponding spec file. Noted while fooling about with the isolationtester. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ffbe9dec13599fa786ea6567df1c6a3f3ee3c673

pgsql: Copy-edit text for the pg_terminate_backend() "timeout" paramete

2021-06-14 Thread Noah Misch
Copy-edit text for the pg_terminate_backend() "timeout" parameter. Revert the pg_description entry to its v13 form, since those messages usually remain shorter and don't discuss individual parameters. No catversion bump, since pg_description content does not impair backend compatibility or applic

pgsql: Remove pg_wait_for_backend_termination().

2021-06-14 Thread Noah Misch
Remove pg_wait_for_backend_termination(). It was unable to wait on a backend that had already left the procarray. Users tolerant of that limitation can poll pg_stat_activity. Other users can employ the "timeout" argument of pg_terminate_backend(). Reviewed by Bharath Rupireddy. Discussion: http

pgsql: Fix logic bug in 1632ea43682f

2021-06-14 Thread Alvaro Herrera
Fix logic bug in 1632ea43682f I overlooked that one condition was logically inverted. The fix is a little bit more involved than simply negating the condition, to make the code easier to read. Fix some outdated comments left by the same commit, while at it. Author: Masahiko Sawada Author: Álva

pgsql: doc: PG 14 relnotes fixes

2021-06-14 Thread Bruce Momjian
doc: PG 14 relnotes fixes Items related to logical replication attribution and BRIN indexes Reported-by: Tomas Vondra, John Naylor Discussion: https://postgr.es/m/[email protected], cafbsxsh21knteydk33f1ozu2o726nsd6_xbq51tn0jytsa1...@mail.gmail.com Branch

pgsql: doc: PG 14 relnote updates

2021-06-14 Thread Bruce Momjian
doc: PG 14 relnote updates Reported-by: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a2559d4093725592a3fd5da8a4c7ac7c883115a0 Modified Files -- doc/src/sgml/release-

pgsql: doc: add PG 14 relnote item about array function references

2021-06-14 Thread Bruce Momjian
doc: add PG 14 relnote item about array function references User-defined objects that reference some built-in array functions will need to be recreated in PG 14. Reported-by: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Branch -- master Details --