pgsql: Disable tests involving ZLIB on Windows for pg_receivewal

2021-07-15 Thread Michael Paquier
Disable tests involving ZLIB on Windows for pg_receivewal As reported by buildfarm member bowerbird, those tests are unstable on Windows. The failure produced there points to a problem with gzflush(), that fails to sync a file freshly-opened, with a gzFile properly opened. While testing this mys

pgsql: docs: fix inconsistencies in markup and case

2021-07-15 Thread Daniel Gustafsson
docs: fix inconsistencies in markup and case Ensure to properly mark up function parameters in text with , avoid using for terms which aren't acronyms and properly place the ", and" in a value list. The acronym removal is a follow-up to commit fb72a7b8c3 which removed it for minmax-multi. In pas

pgsql: docs: fix inconsistencies in markup and case

2021-07-15 Thread Daniel Gustafsson
docs: fix inconsistencies in markup and case Ensure to properly mark up function parameters in text with , avoid using for terms which aren't acronyms and properly place the ", and" in a value list. The acronym removal is a follow-up to commit fb72a7b8c3 which removed it for minmax-multi. In pas

pgsql: Replace explicit PIN entries in pg_depend with an OID range test

2021-07-15 Thread Tom Lane
Replace explicit PIN entries in pg_depend with an OID range test. As of v14, pg_depend contains almost 7000 "pin" entries recording the OIDs of built-in objects. This is a fair amount of bloat for every database, and it adds time to pg_depend lookups as well as initdb. We can get rid of all of t

pgsql: Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix.

2021-07-15 Thread Tom Lane
Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix. Autoconf's AC_CHECK_DECLS() always defines HAVE_DECL_whatever as 1 or 0, but some of the entries in msvc/Solution.pm showed such symbols as "undef" instead of 0. Fix that for consistency. There's no live bug in current usages AFAICS,

pgsql: Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix.

2021-07-15 Thread Tom Lane
Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix. Autoconf's AC_CHECK_DECLS() always defines HAVE_DECL_whatever as 1 or 0, but some of the entries in msvc/Solution.pm showed such symbols as "undef" instead of 0. Fix that for consistency. There's no live bug in current usages AFAICS,

pgsql: Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix.

2021-07-15 Thread Tom Lane
Ensure HAVE_DECL_XXX macros in MSVC builds match those in Unix. Autoconf's AC_CHECK_DECLS() always defines HAVE_DECL_whatever as 1 or 0, but some of the entries in msvc/Solution.pm showed such symbols as "undef" instead of 0. Fix that for consistency. There's no live bug in current usages AFAICS,

pgsql: Fix portability issue with gzip in TAP test of pg_receivewal

2021-07-15 Thread Michael Paquier
Fix portability issue with gzip in TAP test of pg_receivewal The OpenBSD implementation of gzip considers only files suffixed by "Z", "gz", "z", "tgz" or "taz" as valid targets, discarding anything else and making a command using --test exit with an error code of 512 if anything invalid is found.

pgsql: Fix small inconsistencies in catalog definition of multirange op

2021-07-15 Thread Alexander Korotkov
Fix small inconsistencies in catalog definition of multirange operators This commit fixes the description of a couple of multirange operators and oprjoin for another multirange operator. The change of oprjoin is more cosmetic since both old and new functions return the same constant. These cosme

pgsql: Fix small inconsistencies in catalog definition of multirange op

2021-07-15 Thread Alexander Korotkov
Fix small inconsistencies in catalog definition of multirange operators This commit fixes the description of a couple of multirange operators and oprjoin for another multirange operator. The change of oprjoin is more cosmetic since both old and new functions return the same constant. These cosme

pgsql: Improve reporting of "conflicting or redundant options" errors.

2021-07-15 Thread Dean Rasheed
Improve reporting of "conflicting or redundant options" errors. When reporting "conflicting or redundant options" errors, try to ensure that errposition() is used, to help the user identify the offending option. Formerly, errposition() was invoked in less than 60% of cases. This patch raises that