pgsql: Use l*_node() family of functions where appropriate

2021-07-18 Thread Peter Eisentraut
Use l*_node() family of functions where appropriate Instead of castNode(…, lfoo(…)) Author: Dagfinn Ilmari Mannsåker Discussion: https://www.postgresql.org/message-id/flat/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/2b00db4fb0

pgsql: Don't allow to set replication slot_name as ''.

2021-07-18 Thread Amit Kapila
Don't allow to set replication slot_name as ''. We don't allow to create replication slot_name as an empty string ('') via SQL API pg_create_logical_replication_slot() but it is allowed to be set via Alter Subscription command. This will lead to apply worker repeatedly keep trying to stream data v

pgsql: Don't allow to set replication slot_name as ''.

2021-07-18 Thread Amit Kapila
Don't allow to set replication slot_name as ''. We don't allow to create replication slot_name as an empty string ('') via SQL API pg_create_logical_replication_slot() but it is allowed to be set via Alter Subscription command. This will lead to apply worker repeatedly keep trying to stream data v

pgsql: Don't allow to set replication slot_name as ''.

2021-07-18 Thread Amit Kapila
Don't allow to set replication slot_name as ''. We don't allow to create replication slot_name as an empty string ('') via SQL API pg_create_logical_replication_slot() but it is allowed to be set via Alter Subscription command. This will lead to apply worker repeatedly keep trying to stream data v

pgsql: Don't allow to set replication slot_name as ''.

2021-07-18 Thread Amit Kapila
Don't allow to set replication slot_name as ''. We don't allow to create replication slot_name as an empty string ('') via SQL API pg_create_logical_replication_slot() but it is allowed to be set via Alter Subscription command. This will lead to apply worker repeatedly keep trying to stream data v

pgsql: Don't allow to set replication slot_name as ''.

2021-07-18 Thread Amit Kapila
Don't allow to set replication slot_name as ''. We don't allow to create replication slot_name as an empty string ('') via SQL API pg_create_logical_replication_slot() but it is allowed to be set via Alter Subscription command. This will lead to apply worker repeatedly keep trying to stream data v

pgsql: Don't allow to set replication slot_name as ''.

2021-07-18 Thread Amit Kapila
Don't allow to set replication slot_name as ''. We don't allow to create replication slot_name as an empty string ('') via SQL API pg_create_logical_replication_slot() but it is allowed to be set via Alter Subscription command. This will lead to apply worker repeatedly keep trying to stream data v

pgsql: doc: Mention CASCADE/RESTRICT for DROP STATISTICS

2021-07-18 Thread Michael Paquier
doc: Mention CASCADE/RESTRICT for DROP STATISTICS This grammar has no effect as there are no dependencies on statistics, but it is supported by the parser. This is more consistent with the other DROP commands. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm1LA=ynmzcsfy+0oe6ceagsxxrf_-

pgsql: doc: Mention CASCADE/RESTRICT for DROP STATISTICS

2021-07-18 Thread Michael Paquier
doc: Mention CASCADE/RESTRICT for DROP STATISTICS This grammar has no effect as there are no dependencies on statistics, but it is supported by the parser. This is more consistent with the other DROP commands. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm1LA=ynmzcsfy+0oe6ceagsxxrf_-

pgsql: doc: Mention CASCADE/RESTRICT for DROP STATISTICS

2021-07-18 Thread Michael Paquier
doc: Mention CASCADE/RESTRICT for DROP STATISTICS This grammar has no effect as there are no dependencies on statistics, but it is supported by the parser. This is more consistent with the other DROP commands. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm1LA=ynmzcsfy+0oe6ceagsxxrf_-

pgsql: doc: Mention CASCADE/RESTRICT for DROP STATISTICS

2021-07-18 Thread Michael Paquier
doc: Mention CASCADE/RESTRICT for DROP STATISTICS This grammar has no effect as there are no dependencies on statistics, but it is supported by the parser. This is more consistent with the other DROP commands. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm1LA=ynmzcsfy+0oe6ceagsxxrf_-

pgsql: doc: Mention CASCADE/RESTRICT for DROP STATISTICS

2021-07-18 Thread Michael Paquier
doc: Mention CASCADE/RESTRICT for DROP STATISTICS This grammar has no effect as there are no dependencies on statistics, but it is supported by the parser. This is more consistent with the other DROP commands. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm1LA=ynmzcsfy+0oe6ceagsxxrf_-

pgsql: doc: Mention CASCADE/RESTRICT for DROP STATISTICS

2021-07-18 Thread Michael Paquier
doc: Mention CASCADE/RESTRICT for DROP STATISTICS This grammar has no effect as there are no dependencies on statistics, but it is supported by the parser. This is more consistent with the other DROP commands. Author: Vignesh C Discussion: https://postgr.es/m/CALDaNm1LA=ynmzcsfy+0oe6ceagsxxrf_-

pgsql: Update comments for AlterSubscription.

2021-07-18 Thread Amit Kapila
Update comments for AlterSubscription. Add explanation as to why the subscription needs to be disabled to allow slot_name as none. Author: Japin Li and Amit Kapila Discussion: https://postgr.es/m/meyp282mb1669cbd98e721c77ca696499b6...@meyp282mb1669.ausp282.prod.outlook.com Branch -- master

pgsql: Support for unnest(multirange)

2021-07-18 Thread Alexander Korotkov
Support for unnest(multirange) It has been spotted that multiranges lack of ability to decompose them into individual ranges. Subscription and proper expanded object representation require substantial work, and it's too late for v14. This commit provides the implementation of unnest(multirange),

pgsql: Forgotten catversion bump for 9e3c217bd9

2021-07-18 Thread Alexander Korotkov
Forgotten catversion bump for 9e3c217bd9 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f157db862225a7bfe041ca3f7b73e913e2a8d8d6 Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: Support for unnest(multirange)

2021-07-18 Thread Alexander Korotkov
Support for unnest(multirange) It has been spotted that multiranges lack of ability to decompose them into individual ranges. Subscription and proper expanded object representation require substantial work, and it's too late for v14. This commit provides the implementation of unnest(multirange),

pgsql: Improve error checking of CREATE COLLATION options.

2021-07-18 Thread Dean Rasheed
Improve error checking of CREATE COLLATION options. Check for conflicting or redundant options, as we do for most other commands. Specifying any option more than once is at best redundant, and quite likely indicates a bug in the user's code. While at it, improve the error for conflicting locale o