Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Michael Paquier
On Wed, Jul 21, 2021 at 09:08:28PM -0400, Andrew Dunstan wrote: > Yeah, bowerbird got a SIGBREAK that caused the whole buildfarm run to > die, so it's even worse than fairywren. That's impressive. I went through the code of zlib and its documentation, and I don't see anything wrong in what we are

pgsql: Disable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Michael Paquier
Disable TAP tests of pg_receivewal for ZLIB on Windows This reverts commit 91d395f, to avoid running those tests on Windows. The tests are globally stable across all buildfarm members, except fairywren (crash of pg_receivewal) and bowerdird (SIGBREAK preventing the buildfarm run to complete). Tho

pgsql: jit: Don't inline functions that access thread-locals.

2021-07-21 Thread Thomas Munro
jit: Don't inline functions that access thread-locals. Code inlined by LLVM can crash or fail with "Relocation type not implemented yet!" if it tries to access thread local variables. Don't inline such code. Back-patch to 11, where LLVM arrived. Bug #16696. Author: Dmitry Marakasov Reviewed-b

pgsql: jit: Don't inline functions that access thread-locals.

2021-07-21 Thread Thomas Munro
jit: Don't inline functions that access thread-locals. Code inlined by LLVM can crash or fail with "Relocation type not implemented yet!" if it tries to access thread local variables. Don't inline such code. Back-patch to 11, where LLVM arrived. Bug #16696. Author: Dmitry Marakasov Reviewed-b

pgsql: jit: Don't inline functions that access thread-locals.

2021-07-21 Thread Thomas Munro
jit: Don't inline functions that access thread-locals. Code inlined by LLVM can crash or fail with "Relocation type not implemented yet!" if it tries to access thread local variables. Don't inline such code. Back-patch to 11, where LLVM arrived. Bug #16696. Author: Dmitry Marakasov Reviewed-b

pgsql: jit: Don't inline functions that access thread-locals.

2021-07-21 Thread Thomas Munro
jit: Don't inline functions that access thread-locals. Code inlined by LLVM can crash or fail with "Relocation type not implemented yet!" if it tries to access thread local variables. Don't inline such code. Back-patch to 11, where LLVM arrived. Bug #16696. Author: Dmitry Marakasov Reviewed-b

pgsql: jit: Don't inline functions that access thread-locals.

2021-07-21 Thread Thomas Munro
jit: Don't inline functions that access thread-locals. Code inlined by LLVM can crash or fail with "Relocation type not implemented yet!" if it tries to access thread local variables. Don't inline such code. Back-patch to 11, where LLVM arrived. Bug #16696. Author: Dmitry Marakasov Reviewed-b

pgsql: Make nodeSort.c use Datum sorts for single column sorts

2021-07-21 Thread David Rowley
Make nodeSort.c use Datum sorts for single column sorts Datum sorts can be significantly faster than tuple sorts, especially when the data type being sorted is a pass-by-value type. Something in the region of 50-70% performance improvements appear to be possible. Just in case there's any confusi

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Andrew Dunstan
On 7/21/21 8:00 PM, Michael Paquier wrote: > On Wed, Jul 21, 2021 at 10:05:19AM -0400, Andrew Dunstan wrote: >> drongo, an MSVC animal running on the same machine, doesn't seem to have >> an issue, nor jacana which runs msys1, so this seems possibly >> msys2-specific. I'll investigate on a simila

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Michael Paquier
On Wed, Jul 21, 2021 at 10:05:19AM -0400, Andrew Dunstan wrote: > drongo, an MSVC animal running on the same machine, doesn't seem to have > an issue, nor jacana which runs msys1, so this seems possibly > msys2-specific. I'll investigate on a similar instance I have. How is doing bowerbird? I was

pgsql: Doc: improve documentation about exponentiation operator.

2021-07-21 Thread Tom Lane
Doc: improve documentation about exponentiation operator. Now that we're not having to wedge this into the straitjacket of the old operator table format, we can add another example to clarify the point about left-to-right associativity. Per suggestion from mdione at grulic.org.ar. https://postgr

pgsql: Doc: improve documentation about exponentiation operator.

2021-07-21 Thread Tom Lane
Doc: improve documentation about exponentiation operator. Now that we're not having to wedge this into the straitjacket of the old operator table format, we can add another example to clarify the point about left-to-right associativity. Per suggestion from mdione at grulic.org.ar. https://postgr

pgsql: Doc: improve documentation about exponentiation operator.

2021-07-21 Thread Tom Lane
Doc: improve documentation about exponentiation operator. Now that we're not having to wedge this into the straitjacket of the old operator table format, we can add another example to clarify the point about left-to-right associativity. Per suggestion from mdione at grulic.org.ar. https://postgr

pgsql: Improve installation instructions a bit

2021-07-21 Thread Alvaro Herrera
Improve installation instructions a bit Reported-by: Daniel Westermann Discussion: https://postgr.es/m/gv0p278mb04835aaeacf894617574eb6bd2...@gv0p278mb0483.chep278.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/aaec237b1a2f368ed2a8794c4f48b3656750

pgsql: Document "B" as an accepted unit in postgres.conf.sample

2021-07-21 Thread John Naylor
Document "B" as an accepted unit in postgres.conf.sample In postgresql.conf, memory and file size GUCs can be specified with "B" (bytes) as of b06d8e58b. Pavel Luzanov This is a backpatch to v11 of a portion of bb95feabb. Discussion: https://www.postgresql.org/message-id/flat/f10d16fc-8fa0-1b3

pgsql: Document "B" and "us" as accepted units in postgres.conf.sample

2021-07-21 Thread John Naylor
Document "B" and "us" as accepted units in postgres.conf.sample In postgresql.conf, memory and file size GUCs can be specified with "B" (bytes) as of b06d8e58b. Likewise, time GUCs can be specified with "us" (microseconds) as of caf626b2c. Update postgres.conf.sample to reflect that fact. Pavel L

pgsql: Document "B" and "us" as accepted units in postgres.conf.sample

2021-07-21 Thread John Naylor
Document "B" and "us" as accepted units in postgres.conf.sample In postgresql.conf, memory and file size GUCs can be specified with "B" (bytes) as of b06d8e58b. Likewise, time GUCs can be specified with "us" (microseconds) as of caf626b2c. Update postgres.conf.sample to reflect that fact. Pavel L

pgsql: Document "B" and "us" as accepted units in postgres.conf.sample

2021-07-21 Thread John Naylor
Document "B" and "us" as accepted units in postgres.conf.sample In postgresql.conf, memory and file size GUCs can be specified with "B" (bytes) as of b06d8e58b. Likewise, time GUCs can be specified with "us" (microseconds) as of caf626b2c. Update postgres.conf.sample to reflect that fact. Pavel L

pgsql: Document "B" and "us" as accepted units in postgres.conf.sample

2021-07-21 Thread John Naylor
Document "B" and "us" as accepted units in postgres.conf.sample In postgresql.conf, memory and file size GUCs can be specified with "B" (bytes) as of b06d8e58b. Likewise, time GUCs can be specified with "us" (microseconds) as of caf626b2c. Update postgres.conf.sample to reflect that fact. Pavel L

Re: pgsql: Re-enable TAP tests of pg_receivewal for ZLIB on Windows

2021-07-21 Thread Andrew Dunstan
On 7/20/21 7:43 PM, Michael Paquier wrote: > On Tue, Jul 20, 2021 at 05:33:52PM -0400, Andrew Dunstan wrote: >> fairywren doesn't seem to like this. > Indeed, it doesn't. The logs don't offer much, and I am not sure if > this is a problem that happens when opening the first segment, or if > that

pgsql: Add missing check of noError parameter in euc_tw_and_big5.c

2021-07-21 Thread John Naylor
Add missing check of noError parameter in euc_tw_and_big5.c Oversight in ea1b99a66 Yukun Wang Backpatch to v14 where this parameter was introduced Discussion: https://www.postgresql.org/message-id/flat/OS0PR01MB6003FCEFF0201EF21685FD33B4E39%40OS0PR01MB6003.jpnprd01.prod.outlook.com Branch ---

pgsql: Add missing check of noError parameter in euc_tw_and_big5.c

2021-07-21 Thread John Naylor
Add missing check of noError parameter in euc_tw_and_big5.c Oversight in ea1b99a66 Yukun Wang Backpatch to v14 where this parameter was introduced Discussion: https://www.postgresql.org/message-id/flat/OS0PR01MB6003FCEFF0201EF21685FD33B4E39%40OS0PR01MB6003.jpnprd01.prod.outlook.com Branch

pgsql: Add missing enum tags in enums used in nodes

2021-07-21 Thread Peter Eisentraut
Add missing enum tags in enums used in nodes Discussion: https://www.postgresql.org/message-id/flat/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/983bdc4fac492a99bb8ab5a471ca7437139e5cf6 Modified Files --

pgsql: Rename some node support functions for consistency

2021-07-21 Thread Peter Eisentraut
Rename some node support functions for consistency Some node function names didn't match their node type names exactly. Fix those for consistency. Discussion: https://www.postgresql.org/message-id/flat/[email protected] Branch -- master Details --- h

pgsql: Rename argument of _outValue()

2021-07-21 Thread Peter Eisentraut
Rename argument of _outValue() Rename from value to node, for consistency with similar functions. Discussion: https://www.postgresql.org/message-id/flat/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3d25b4ea6