pgsql: Update obsolete nbtree deletion comments.

2021-09-25 Thread Peter Geoghegan
Update obsolete nbtree deletion comments. _bt_delitems_delete() is no longer the high-level entry point used by index tuple deletion driven by index tuples whose LP_DEAD bits are set (now called "simple index tuple deletion"). It became a lower level routine that's only called by _bt_delitems_del

pgsql: vacuumlazy.c: Remove obsolete 'onecall' comment.

2021-09-25 Thread Peter Geoghegan
vacuumlazy.c: Remove obsolete 'onecall' comment. Remove obsolete reference to lazy_vacuum()'s onecall argument. The function argument was removed by commit 3499df0dee. Also remove adjoining comment block that introduces the wraparound failsafe concept. Talking about the failsafe here no longer

pgsql: Doc: final(?) updates for 14.0 release notes.

2021-09-25 Thread Tom Lane
Doc: final(?) updates for 14.0 release notes. Add the customary short list of major features. Set release date. Discussion: https://postgr.es/m/[email protected] Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/765f677f364100072160e7af37288eb1

pgsql: Doc: extend warnings about collation-mismatch hazards in postgre

2021-09-25 Thread Tom Lane
Doc: extend warnings about collation-mismatch hazards in postgres_fdw. Be a little more vocal about the risks of remote collations not matching local ones. Actually fixing these risks seems hard, and I've given up on the idea that it might be back-patchable. So the best we can do for the back bra

pgsql: Doc: extend warnings about collation-mismatch hazards in postgre

2021-09-25 Thread Tom Lane
Doc: extend warnings about collation-mismatch hazards in postgres_fdw. Be a little more vocal about the risks of remote collations not matching local ones. Actually fixing these risks seems hard, and I've given up on the idea that it might be back-patchable. So the best we can do for the back bra

pgsql: Doc: extend warnings about collation-mismatch hazards in postgre

2021-09-25 Thread Tom Lane
Doc: extend warnings about collation-mismatch hazards in postgres_fdw. Be a little more vocal about the risks of remote collations not matching local ones. Actually fixing these risks seems hard, and I've given up on the idea that it might be back-patchable. So the best we can do for the back bra

pgsql: Doc: extend warnings about collation-mismatch hazards in postgre

2021-09-25 Thread Tom Lane
Doc: extend warnings about collation-mismatch hazards in postgres_fdw. Be a little more vocal about the risks of remote collations not matching local ones. Actually fixing these risks seems hard, and I've given up on the idea that it might be back-patchable. So the best we can do for the back bra

pgsql: Doc: extend warnings about collation-mismatch hazards in postgre

2021-09-25 Thread Tom Lane
Doc: extend warnings about collation-mismatch hazards in postgres_fdw. Be a little more vocal about the risks of remote collations not matching local ones. Actually fixing these risks seems hard, and I've given up on the idea that it might be back-patchable. So the best we can do for the back bra

pgsql: Doc: extend warnings about collation-mismatch hazards in postgre

2021-09-25 Thread Tom Lane
Doc: extend warnings about collation-mismatch hazards in postgres_fdw. Be a little more vocal about the risks of remote collations not matching local ones. Actually fixing these risks seems hard, and I've given up on the idea that it might be back-patchable. So the best we can do for the back bra

pgsql: Doc: extend warnings about collation-mismatch hazards in postgre

2021-09-25 Thread Tom Lane
Doc: extend warnings about collation-mismatch hazards in postgres_fdw. Be a little more vocal about the risks of remote collations not matching local ones. Actually fixing these risks seems hard, and I've given up on the idea that it might be back-patchable. So the best we can do for the back bra

pgsql: Add alternative output for OpenSSL 3 without legacy loaded

2021-09-25 Thread Daniel Gustafsson
Add alternative output for OpenSSL 3 without legacy loaded OpenSSL 3 introduced the concept of providers to support modularization, and moved the outdated ciphers to the new legacy provider. In case it's not loaded in the users openssl.cnf file there will be a lot of regress test failures, so add

pgsql: pgcrypto: Check for error return of px_cipher_decrypt()

2021-09-25 Thread Daniel Gustafsson
pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the

pgsql: Disable OpenSSL EVP digest padding in pgcrypto

2021-09-25 Thread Daniel Gustafsson
Disable OpenSSL EVP digest padding in pgcrypto The PX layer in pgcrypto is handling digest padding on its own uniformly for all backend implementations. Starting with OpenSSL 3.0.0, DecryptUpdate doesn't flush the last block in case padding is enabled so explicitly disable it as we don't use it.

pgsql: Add alternative output for OpenSSL 3 without legacy loaded

2021-09-25 Thread Daniel Gustafsson
Add alternative output for OpenSSL 3 without legacy loaded OpenSSL 3 introduced the concept of providers to support modularization, and moved the outdated ciphers to the new legacy provider. In case it's not loaded in the users openssl.cnf file there will be a lot of regress test failures, so add

pgsql: Disable OpenSSL EVP digest padding in pgcrypto

2021-09-25 Thread Daniel Gustafsson
Disable OpenSSL EVP digest padding in pgcrypto The PX layer in pgcrypto is handling digest padding on its own uniformly for all backend implementations. Starting with OpenSSL 3.0.0, DecryptUpdate doesn't flush the last block in case padding is enabled so explicitly disable it as we don't use it.

pgsql: pgcrypto: Check for error return of px_cipher_decrypt()

2021-09-25 Thread Daniel Gustafsson
pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the

pgsql: Add alternative output for OpenSSL 3 without legacy loaded

2021-09-25 Thread Daniel Gustafsson
Add alternative output for OpenSSL 3 without legacy loaded OpenSSL 3 introduced the concept of providers to support modularization, and moved the outdated ciphers to the new legacy provider. In case it's not loaded in the users openssl.cnf file there will be a lot of regress test failures, so add

pgsql: Disable OpenSSL EVP digest padding in pgcrypto

2021-09-25 Thread Daniel Gustafsson
Disable OpenSSL EVP digest padding in pgcrypto The PX layer in pgcrypto is handling digest padding on its own uniformly for all backend implementations. Starting with OpenSSL 3.0.0, DecryptUpdate doesn't flush the last block in case padding is enabled so explicitly disable it as we don't use it.

pgsql: pgcrypto: Check for error return of px_cipher_decrypt()

2021-09-25 Thread Daniel Gustafsson
pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the

pgsql: Disable OpenSSL EVP digest padding in pgcrypto

2021-09-25 Thread Daniel Gustafsson
Disable OpenSSL EVP digest padding in pgcrypto The PX layer in pgcrypto is handling digest padding on its own uniformly for all backend implementations. Starting with OpenSSL 3.0.0, DecryptUpdate doesn't flush the last block in case padding is enabled so explicitly disable it as we don't use it.

pgsql: pgcrypto: Check for error return of px_cipher_decrypt()

2021-09-25 Thread Daniel Gustafsson
pgcrypto: Check for error return of px_cipher_decrypt() This has previously not been a problem (that anyone ever reported), but in future OpenSSL versions (3.0.0), where legacy ciphers are/can be disabled, this is the place where this is reported. So we need to catch the error here, otherwise the

pgsql: Add alternative output for OpenSSL 3 without legacy loaded

2021-09-25 Thread Daniel Gustafsson
Add alternative output for OpenSSL 3 without legacy loaded OpenSSL 3 introduced the concept of providers to support modularization, and moved the outdated ciphers to the new legacy provider. In case it's not loaded in the users openssl.cnf file there will be a lot of regress test failures, so add

pgsql: Add alternative output for OpenSSL 3 without legacy loaded

2021-09-25 Thread Daniel Gustafsson
Add alternative output for OpenSSL 3 without legacy loaded OpenSSL 3 introduced the concept of providers to support modularization, and moved the outdated ciphers to the new legacy provider. In case it's not loaded in the users openssl.cnf file there will be a lot of regress test failures, so add

pgsql: Disable OpenSSL EVP digest padding in pgcrypto

2021-09-25 Thread Daniel Gustafsson
Disable OpenSSL EVP digest padding in pgcrypto The PX layer in pgcrypto is handling digest padding on its own uniformly for all backend implementations. Starting with OpenSSL 3.0.0, DecryptUpdate doesn't flush the last block in case padding is enabled so explicitly disable it as we don't use it.