pgsql: doc: Document pg_encoding_to_char() and pg_char_to_encoding().

2021-10-04 Thread Fujii Masao
doc: Document pg_encoding_to_char() and pg_char_to_encoding(). Previously both functions were not described anywhere in the docs. But since they have been around since 7.0 and mentioned in the description for system catalog like pg_database, it's reasonable to add short descriptions for them. Aut

pgsql: Remove obsolete comment in snapbuild.c.

2021-10-04 Thread Amit Kapila
Remove obsolete comment in snapbuild.c. Commits 955a684e04 and a975ff4980 removed the usage of running xacts information from serialized snapshots but forgot to remove the corresponding comment. Author: Masahiko Sawada Discussion: https://postgr.es/m/CAD21AoBifOr7RS=jre7ycavc646y9omchv6zkwxvjezc

pgsql: psql: Improve tab-completion for LOCK TABLE.

2021-10-04 Thread Fujii Masao
psql: Improve tab-completion for LOCK TABLE. This commit makes psql support the tab-completion for ONLY and NOWAIT keywords of LOCK TABLE command. Author: Koyu Tanigawa Reviewed-by: Shinya Kato, Fujii Masao Discussion: https://postgr.es/m/[email protected] Branch -

pgsql: doc: remove URL for ICU explorer/locexp

2021-10-04 Thread Bruce Momjian
doc: remove URL for ICU explorer/locexp The old URL was HTTP 404 and the git link didn't build. Also update two other ICU links. If we ever get a good link we will add it back. Reported-by: Anton Voloshin Author: Laurenz Albe Backpatch-through: 10 only (missed in previous commit) Branch ---

pgsql: doc: remove URL for ICU explorer/locexp

2021-10-04 Thread Bruce Momjian
doc: remove URL for ICU explorer/locexp The old URL was HTTP 404 and the git link didn't build. Also update two other ICU links. If we ever get a good link we will add it back. Reported-by: Anton Voloshin Author: Laurenz Albe Backpatch-through: 10 Branch -- master Details --- https

pgsql: doc: remove URL for ICU explorer/locexp

2021-10-04 Thread Bruce Momjian
doc: remove URL for ICU explorer/locexp The old URL was HTTP 404 and the git link didn't build. Also update two other ICU links. If we ever get a good link we will add it back. Reported-by: Anton Voloshin Author: Laurenz Albe Backpatch-through: 10 Branch -- REL_14_STABLE Details --

pgsql: doc: remove URL for ICU explorer/locexp

2021-10-04 Thread Bruce Momjian
doc: remove URL for ICU explorer/locexp The old URL was HTTP 404 and the git link didn't build. Also update two other ICU links. If we ever get a good link we will add it back. Reported-by: Anton Voloshin Author: Laurenz Albe Backpatch-through: 10 Branch -- REL_11_STABLE Details --

pgsql: doc: remove URL for ICU explorer/locexp

2021-10-04 Thread Bruce Momjian
doc: remove URL for ICU explorer/locexp The old URL was HTTP 404 and the git link didn't build. Also update two other ICU links. If we ever get a good link we will add it back. Reported-by: Anton Voloshin Author: Laurenz Albe Backpatch-through: 10 Branch -- REL_13_STABLE Details --

pgsql: doc: remove URL for ICU explorer/locexp

2021-10-04 Thread Bruce Momjian
doc: remove URL for ICU explorer/locexp The old URL was HTTP 404 and the git link didn't build. Also update two other ICU links. If we ever get a good link we will add it back. Reported-by: Anton Voloshin Author: Laurenz Albe Backpatch-through: 10 Branch -- REL_12_STABLE Details --

pgsql: Fix TestLib::slurp_file() with offset on windows.

2021-10-04 Thread Andres Freund
Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can jus

pgsql: Fix TestLib::slurp_file() with offset on windows.

2021-10-04 Thread Andres Freund
Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can jus

pgsql: Fix TestLib::slurp_file() with offset on windows.

2021-10-04 Thread Andres Freund
Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can jus

pgsql: Fix TestLib::slurp_file() with offset on windows.

2021-10-04 Thread Andres Freund
Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can jus

pgsql: Fix TestLib::slurp_file() with offset on windows.

2021-10-04 Thread Andres Freund
Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can jus

pgsql: Fix TestLib::slurp_file() with offset on windows.

2021-10-04 Thread Andres Freund
Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can jus

pgsql: Fix TestLib::slurp_file() with offset on windows.

2021-10-04 Thread Andres Freund
Fix TestLib::slurp_file() with offset on windows. 3c5b0685b921 used setFilePointer() to set the position of the filehandle, but passed the wrong filehandle, always leaving the position at 0. Instead of just fixing that, remove use of setFilePointer(), we have a perl fd at this point, so we can jus

pgsql: windows: Define WIN32_LEAN_AND_MEAN to make compilation faster.

2021-10-04 Thread Andres Freund
windows: Define WIN32_LEAN_AND_MEAN to make compilation faster. windows.h includes a lot of other headers, slowing down compilation significantly. WIN32_LEAN_AND_MEAN reduces that a bit. It'd be better to remove the include of windows.h (as well as indirect inclusions of it) from such a central pl

pgsql: Fix check for trapping exit() calls in libpq

2021-10-04 Thread Daniel Gustafsson
Fix check for trapping exit() calls in libpq Commit e9bc0441f added an errorhint on the exit() check for libpq, but accidentally changed the nm commandline to use -a instead of -A. These options are similar enough to hide it in testing, but -a can also show debugger symbols which isn't what we wan

pgsql: Update our mapping of Windows time zone names some more.

2021-10-04 Thread Tom Lane
Update our mapping of Windows time zone names some more. Per discussion, let's just follow CLDR's default zone mappings faithfully. There are two changes here that are clear improvements: * Mapping "Greenwich Standard Time" to Atlantic/Reykjavik is actually a better fit than using London, becaus

pgsql: Update our mapping of Windows time zone names some more.

2021-10-04 Thread Tom Lane
Update our mapping of Windows time zone names some more. Per discussion, let's just follow CLDR's default zone mappings faithfully. There are two changes here that are clear improvements: * Mapping "Greenwich Standard Time" to Atlantic/Reykjavik is actually a better fit than using London, becaus

pgsql: Update our mapping of Windows time zone names some more.

2021-10-04 Thread Tom Lane
Update our mapping of Windows time zone names some more. Per discussion, let's just follow CLDR's default zone mappings faithfully. There are two changes here that are clear improvements: * Mapping "Greenwich Standard Time" to Atlantic/Reykjavik is actually a better fit than using London, becaus

pgsql: Update our mapping of Windows time zone names some more.

2021-10-04 Thread Tom Lane
Update our mapping of Windows time zone names some more. Per discussion, let's just follow CLDR's default zone mappings faithfully. There are two changes here that are clear improvements: * Mapping "Greenwich Standard Time" to Atlantic/Reykjavik is actually a better fit than using London, becaus

pgsql: Update our mapping of Windows time zone names some more.

2021-10-04 Thread Tom Lane
Update our mapping of Windows time zone names some more. Per discussion, let's just follow CLDR's default zone mappings faithfully. There are two changes here that are clear improvements: * Mapping "Greenwich Standard Time" to Atlantic/Reykjavik is actually a better fit than using London, becaus

pgsql: Update our mapping of Windows time zone names some more.

2021-10-04 Thread Tom Lane
Update our mapping of Windows time zone names some more. Per discussion, let's just follow CLDR's default zone mappings faithfully. There are two changes here that are clear improvements: * Mapping "Greenwich Standard Time" to Atlantic/Reykjavik is actually a better fit than using London, becaus

pgsql: Update our mapping of Windows time zone names some more.

2021-10-04 Thread Tom Lane
Update our mapping of Windows time zone names some more. Per discussion, let's just follow CLDR's default zone mappings faithfully. There are two changes here that are clear improvements: * Mapping "Greenwich Standard Time" to Atlantic/Reykjavik is actually a better fit than using London, becaus

pgsql: Make Unicode makefile parallel-safe

2021-10-04 Thread Peter Eisentraut
Make Unicode makefile parallel-safe Fix the rules so that each rule is parallel safe, using the same trickery that we use elsewhere in the tree for rules that produce more than one output file. Refactor the whole makefile so that there is less repetition. Discussion: https://www.postgresql.org/

pgsql: Doc: fix minor issues in GiST support function documentation.

2021-10-04 Thread Tom Lane
Doc: fix minor issues in GiST support function documentation. gist.sgml and xindex.sgml hadn't been fully updated for the addition of a sortsupport support function (commit 16fa9b2b3). xindex.sgml also missed that the compress and decompress support functions are optional, an apparently far older

pgsql: Doc: fix minor issues in GiST support function documentation.

2021-10-04 Thread Tom Lane
Doc: fix minor issues in GiST support function documentation. gist.sgml and xindex.sgml hadn't been fully updated for the addition of a sortsupport support function (commit 16fa9b2b3). xindex.sgml also missed that the compress and decompress support functions are optional, an apparently far older

pgsql: Fix duplicate words in comments

2021-10-04 Thread Daniel Gustafsson
Fix duplicate words in comments Remove accidentally duplicated words in code comments. Author: Dagfinn Ilmari MannsÃ¥ker Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7111e332c57ddb562d0ce26a4e08761

pgsql: Provide error hint on exit() check when building libpq

2021-10-04 Thread Daniel Gustafsson
Provide error hint on exit() check when building libpq Commit dc227eb82 introduced a restriction on libpq that no functions which invoke exit() are allowed to be called. This was further refined and fixed in e45b0dfa1f and 2f7bae2f92 and 792259591. While this is well documented in the Makefile, th

pgsql: Update Unicode map text files

2021-10-04 Thread Peter Eisentraut
Update Unicode map text files A couple of newer ones are available. There are no functional differences, but let's get them in anyway, so that there is no surprise diff next time someone wants to do some actual work in this area. Branch -- master Details --- https://git.postgresql.org/p

pgsql: Provide error hint if TAP tests are not enabled

2021-10-04 Thread Daniel Gustafsson
Provide error hint if TAP tests are not enabled The error message for trying to run the TAP tests in a tree not configured with --enable-tap-tests is quite terse, and could be made more helpful to new developers onboarding to postgres. This adds a small hint on how to get the tests running in such

pgsql: Replace occurrences of InvalidXid with InvalidTransactionId

2021-10-04 Thread Daniel Gustafsson
Replace occurrences of InvalidXid with InvalidTransactionId While Xid is a known shortening of TransactionId, InvalidXid is not defined in the code. Fix comments which mistakenly were using the shorter version. Author: Bharath Rupireddy Discussion: https://postgr.es/m/calj2acuqzdigml868nv4cojfe