pgsql: Refactor fallback to stderr for csvlog to handle better WIN32 se

2021-10-07 Thread Michael Paquier
Refactor fallback to stderr for csvlog to handle better WIN32 service case send_message_to_server_log() would force a redirection of a log entry to stderr in some cases for csvlog, like the syslogger not being available yet. If this happens, csvlog would fall back to stderr to log some informatio

pgsql: Doc: update our claims about the minimum recommended AIX version

2021-10-07 Thread Tom Lane
Doc: update our claims about the minimum recommended AIX version. We currently have buildfarm members testing back to AIX 7.1, but not before, and older AIX versions are long out of support from IBM. So say that 7.1 is the oldest supported version. Discussion: https://postgr.es/m/87y278s6iq@

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Daniel Gustafsson
> On 7 Oct 2021, at 21:02, Tom Lane wrote: > BTW, looking at that a second time, I wonder if that advice is > really of any use. Yeah, I would have to agree. Reading that again I think what it perhaps should be saying is that 5.8.3 is the Perl API level that the testcode must conform to, but th

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Tom Lane
I wrote: > Daniel Gustafsson writes: >> src/test/perl/README still claims "5.8.0 and newer", not sure how important >> that is to fix but it seems a bit inconsistent now. > Ah, done. BTW, looking at that a second time, I wonder if that advice is really of any use. (1) I'm distrustful of the ide

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Tom Lane
Daniel Gustafsson writes: >> On 7 Oct 2021, at 20:26, Tom Lane wrote: >> Previously it only checked for version >= 5.8.0, although the >> documentation has said that the minimum version is 5.8.3 since >> commit dea6ba939. > src/test/perl/README still claims "5.8.0 and newer", not sure how import

pgsql: Update test/perl/README to insist on Perl version >= 5.8.3, too.

2021-10-07 Thread Tom Lane
Update test/perl/README to insist on Perl version >= 5.8.3, too. Oversight in previous commit, noted by Daniel Gustafsson. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/93fb39eca643a33dd6e3c8818fc78

Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Daniel Gustafsson
> On 7 Oct 2021, at 20:26, Tom Lane wrote: > Previously it only checked for version >= 5.8.0, although the > documentation has said that the minimum version is 5.8.3 since > commit dea6ba939. src/test/perl/README still claims "5.8.0 and newer", not sure how important that is to fix but it seems

pgsql: Adjust configure to insist on Perl version >= 5.8.3.

2021-10-07 Thread Tom Lane
Adjust configure to insist on Perl version >= 5.8.3. Previously it only checked for version >= 5.8.0, although the documentation has said that the minimum version is 5.8.3 since commit dea6ba939. Per the discussion leading up to that commit, I (tgl) left it that way intentionally because you coul

pgsql: plperl: update ppport.h to Perl 5.34.0.

2021-10-07 Thread Tom Lane
plperl: update ppport.h to Perl 5.34.0. Also apply the changes suggested by running perl ppport.h --compat-version=5.8.0 And remove some no-longer-required NEED_foo declarations. Dagfinn Ilmari MannsÃ¥ker Discussion: https://postgr.es/m/[email protected] Branch -- master

pgsql: postgres_fdw: Fix comments in connection.c.

2021-10-07 Thread Etsuro Fujita
postgres_fdw: Fix comments in connection.c. Commit 27e1f1456 missed updating some comments. Reviewed-by: Bharath Rupireddy Backpatch-through: 14 Discussion: https://postgr.es/m/CAPmGK15Q2Nm6U%2Ba_GwskrWFEVBZ9_3VKOvRrprGufpx91M_3Sw%40mail.gmail.com Branch -- master Details --- https://g

pgsql: postgres_fdw: Fix comments in connection.c.

2021-10-07 Thread Etsuro Fujita
postgres_fdw: Fix comments in connection.c. Commit 27e1f1456 missed updating some comments. Reviewed-by: Bharath Rupireddy Backpatch-through: 14 Discussion: https://postgr.es/m/CAPmGK15Q2Nm6U%2Ba_GwskrWFEVBZ9_3VKOvRrprGufpx91M_3Sw%40mail.gmail.com Branch -- REL_14_STABLE Details --- ht

pgsql: Add missing word to comment in joinrels.c.

2021-10-07 Thread Etsuro Fujita
Add missing word to comment in joinrels.c. Author: Amit Langote Backpatch-through: 13 Discussion: https://postgr.es/m/CA%2BHiwqGQNbtamQ_9DU3osR1XiWR4wxWFZurPmN6zgbdSZDeWmw%40mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/700c73312841bd1a89263f238556

pgsql: Add missing word to comment in joinrels.c.

2021-10-07 Thread Etsuro Fujita
Add missing word to comment in joinrels.c. Author: Amit Langote Backpatch-through: 13 Discussion: https://postgr.es/m/CA%2BHiwqGQNbtamQ_9DU3osR1XiWR4wxWFZurPmN6zgbdSZDeWmw%40mail.gmail.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ef2e107f548cfbd22060e

pgsql: Add missing word to comment in joinrels.c.

2021-10-07 Thread Etsuro Fujita
Add missing word to comment in joinrels.c. Author: Amit Langote Backpatch-through: 13 Discussion: https://postgr.es/m/CA%2BHiwqGQNbtamQ_9DU3osR1XiWR4wxWFZurPmN6zgbdSZDeWmw%40mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/08f37e2592920a6df9584

pgsql: Fix compilation warning in syslogger.c

2021-10-07 Thread Michael Paquier
Fix compilation warning in syslogger.c Oversight in 5c6e33f. Author: Nathan Bossart Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/05c4248ad1bf0c2721ce9445f6908da9ece36ff8 Modified Fi