pgsql: Reset properly snapshot export state during transaction abort

2021-10-17 Thread Michael Paquier
Reset properly snapshot export state during transaction abort During a replication slot creation, an ERROR generated in the same transaction as the one creating a to-be-exported snapshot would have left the backend in an inconsistent state, as the associated static export snapshot state was not be

pgsql: Reset properly snapshot export state during transaction abort

2021-10-17 Thread Michael Paquier
Reset properly snapshot export state during transaction abort During a replication slot creation, an ERROR generated in the same transaction as the one creating a to-be-exported snapshot would have left the backend in an inconsistent state, as the associated static export snapshot state was not be

pgsql: Reset properly snapshot export state during transaction abort

2021-10-17 Thread Michael Paquier
Reset properly snapshot export state during transaction abort During a replication slot creation, an ERROR generated in the same transaction as the one creating a to-be-exported snapshot would have left the backend in an inconsistent state, as the associated static export snapshot state was not be

pgsql: Reset properly snapshot export state during transaction abort

2021-10-17 Thread Michael Paquier
Reset properly snapshot export state during transaction abort During a replication slot creation, an ERROR generated in the same transaction as the one creating a to-be-exported snapshot would have left the backend in an inconsistent state, as the associated static export snapshot state was not be

pgsql: Reset properly snapshot export state during transaction abort

2021-10-17 Thread Michael Paquier
Reset properly snapshot export state during transaction abort During a replication slot creation, an ERROR generated in the same transaction as the one creating a to-be-exported snapshot would have left the backend in an inconsistent state, as the associated static export snapshot state was not be

pgsql: Reset properly snapshot export state during transaction abort

2021-10-17 Thread Michael Paquier
Reset properly snapshot export state during transaction abort During a replication slot creation, an ERROR generated in the same transaction as the one creating a to-be-exported snapshot would have left the backend in an inconsistent state, as the associated static export snapshot state was not be

pgsql: Reset properly snapshot export state during transaction abort

2021-10-17 Thread Michael Paquier
Reset properly snapshot export state during transaction abort During a replication slot creation, an ERROR generated in the same transaction as the one creating a to-be-exported snapshot would have left the backend in an inconsistent state, as the associated static export snapshot state was not be

Re: pgsql: Add more $Test::Builder::Level in the TAP tests

2021-10-17 Thread Michael Paquier
On Sat, Oct 16, 2021 at 08:08:28PM -0700, Peter Geoghegan wrote: > Thank you for taking care of this. Okay. Done, then. -- Michael signature.asc Description: PGP signature

pgsql: Fix portability issues in new TAP tests of psql

2021-10-17 Thread Michael Paquier
Fix portability issues in new TAP tests of psql The tests added by c0280bc and d9ddc50 in 001_basic.pl have introduced commands calling directly psql, making them sensitive to the environment. One issue was that those commands forgot -X to not use a local .psqlrc, causing all those tests to fail

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-17 Thread Andrew Dunstan
On 10/8/21 8:33 PM, Andrew Dunstan wrote: > On 10/8/21 5:14 PM, Andres Freund wrote: >> Hi, >> >> On 2021-10-08 11:41:50 -0400, Andrew Dunstan wrote: >>> On 10/1/21 6:34 PM, Andres Freund wrote: Reference test binary using TESTDIR in 001_libpq_pipeline.pl. The previous approach didn