pgsql: Back-patch "Add parent table name in an error in reorderbuffer.c

2021-10-20 Thread Amit Kapila
Back-patch "Add parent table name in an error in reorderbuffer.c." This was originally done in commit 5e77625b26 for 15 only, as a troubleshooting aid but multiple people showed interest in back-patching this. Author: Jeremy Schneider Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: ht

pgsql: Back-patch "Add parent table name in an error in reorderbuffer.c

2021-10-20 Thread Amit Kapila
Back-patch "Add parent table name in an error in reorderbuffer.c." This was originally done in commit 5e77625b26 for 15 only, as a troubleshooting aid but multiple people showed interest in back-patching this. Author: Jeremy Schneider Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: ht

pgsql: Back-patch "Add parent table name in an error in reorderbuffer.c

2021-10-20 Thread Amit Kapila
Back-patch "Add parent table name in an error in reorderbuffer.c." This was originally done in commit 5e77625b26 for 15 only, as a troubleshooting aid but multiple people showed interest in back-patching this. Author: Jeremy Schneider Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: ht

pgsql: Back-patch "Add parent table name in an error in reorderbuffer.c

2021-10-20 Thread Amit Kapila
Back-patch "Add parent table name in an error in reorderbuffer.c." This was originally done in commit 5e77625b26 for 15 only, as a troubleshooting aid but multiple people showed interest in back-patching this. Author: Jeremy Schneider Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: ht

pgsql: Back-patch "Add parent table name in an error in reorderbuffer.c

2021-10-20 Thread Amit Kapila
Back-patch "Add parent table name in an error in reorderbuffer.c." This was originally done in commit 5e77625b26 for 15 only, as a troubleshooting aid but multiple people showed interest in back-patching this. Author: Jeremy Schneider Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: ht

pgsql: Back-patch "Add parent table name in an error in reorderbuffer.c

2021-10-20 Thread Amit Kapila
Back-patch "Add parent table name in an error in reorderbuffer.c." This was originally done in commit 5e77625b26 for 15 only, as a troubleshooting aid but multiple people showed interest in back-patching this. Author: Jeremy Schneider Reviewed-by: Amit Kapila Backpatch-through: 9.6 Discussion: ht

pgsql: Remove unused wait events.

2021-10-20 Thread Amit Kapila
Remove unused wait events. Commit 464824323e introduced the wait events which were neither used by that commit nor by follow-up commits for that work. Author: Masahiro Ikeda Backpatch-through: 14, where it was introduced Discussion: https://postgr.es/m/[email protected]

pgsql: Remove unused wait events.

2021-10-20 Thread Amit Kapila
Remove unused wait events. Commit 464824323e introduced the wait events which were neither used by that commit nor by follow-up commits for that work. Author: Masahiro Ikeda Backpatch-through: 14, where it was introduced Discussion: https://postgr.es/m/[email protected]

pgsql: Fix corruption of pg_shdepend when copying deps from template da

2021-10-20 Thread Michael Paquier
Fix corruption of pg_shdepend when copying deps from template database Using for a new database a template database with shared dependencies that need to be copied over was causing a corruption of pg_shdepend because of an off-by-one computation error of the index number used for the values insert

pgsql: Fix corruption of pg_shdepend when copying deps from template da

2021-10-20 Thread Michael Paquier
Fix corruption of pg_shdepend when copying deps from template database Using for a new database a template database with shared dependencies that need to be copied over was causing a corruption of pg_shdepend because of an off-by-one computation error of the index number used for the values insert

pgsql: Improve pg_regress.c's infrastructure for issuing psql commands.

2021-10-20 Thread Tom Lane
Improve pg_regress.c's infrastructure for issuing psql commands. Support issuing more than one "-c command" switch to a single psql invocation. This allows combining some things that formerly required two or more backend launches into a single session. In particular, we can issue DROP DATABASE as

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Tom Lane
Andrew Dunstan writes: > OK, it turns out that it's better to put the addition at the end of the > PATH, otherise initdb complains that it can't find postgres in the same > directory. That seems horribly unsafe, or at least prone to pulling in the program from some other versuion of Postgres. Ho

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Andrew Dunstan
On 10/20/21 3:09 PM, Andres Freund wrote: > Hi, > > On 2021-10-20 14:30:49 -0400, Andrew Dunstan wrote: >> On 10/20/21 12:31 PM, Andres Freund wrote: >>> ISTM that we should just make the "test invocation framework" responsible to >>> put the relevant directory onto PATH? I.e. Makefile.global shou

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Andres Freund
Hi, On 2021-10-20 14:30:49 -0400, Andrew Dunstan wrote: > On 10/20/21 12:31 PM, Andres Freund wrote: > > ISTM that we should just make the "test invocation framework" responsible to > > put the relevant directory onto PATH? I.e. Makefile.global should add the > > build directory of the test to PAT

Re: pgsql: Refactor the sslfiles Makefile target for ease of use

2021-10-20 Thread Daniel Gustafsson
> On 20 Oct 2021, at 15:33, Tom Lane wrote: > > Daniel Gustafsson writes: >> The conversion of the serialnumber from hex to base10 requires a 64-bit >> capable >> Perl, and my guess is that prairiedog has a 32-bit Perl. > > Yup, it does. Thanks for confirming, then my fix is attacking the rig

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Andrew Dunstan
On 10/20/21 12:31 PM, Andres Freund wrote: > > ISTM that we should just make the "test invocation framework" responsible to > put the relevant directory onto PATH? I.e. Makefile.global should add the > build directory of the test to PATH, and vcregress.pl should put the relevant > $configuration/$

Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.

2021-10-20 Thread Andres Freund
Hi, On 2021-10-18 11:39:08 -0400, Andrew Dunstan wrote: > On 10/18/21 10:23 AM, Alvaro Herrera wrote: > > On 2021-Oct-17, Andrew Dunstan wrote: > > > >> +sub find_built_program > >> +{ > >> + my $program = shift; > >> + my $path; > >> + > >> + if (defined $ENV{MSBUILDDIR}) > >> + { > >> +

pgsql: Protect against collation variations in test

2021-10-20 Thread Alvaro Herrera
Protect against collation variations in test Discussion: https://postgr.es/m/YW/[email protected] Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7182788552b7b7d7fca226af2ec281789b1abff3 Modified Files -- src/test/regress/expected/alter_t

pgsql: Protect against collation variations in test

2021-10-20 Thread Alvaro Herrera
Protect against collation variations in test Discussion: https://postgr.es/m/YW/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cd124d205c42a623b68cd155ace94cc376851b78 Modified Files -- src/test/regress/expected/alter_table.ou

pgsql: Protect against collation variations in test

2021-10-20 Thread Alvaro Herrera
Protect against collation variations in test Discussion: https://postgr.es/m/YW/[email protected] Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/a73a3671daea34f244e1c51321d714be3200f2d9 Modified Files -- src/test/regress/expected/alter_t

pgsql: Protect against collation variations in test

2021-10-20 Thread Alvaro Herrera
Protect against collation variations in test Discussion: https://postgr.es/m/YW/[email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3c8c49945dfcbb6e045d9cb9d1da59fed822649d Modified Files -- src/test/regress/expected/alter_t

Re: pgsql: Refactor the sslfiles Makefile target for ease of use

2021-10-20 Thread Tom Lane
Daniel Gustafsson writes: > The conversion of the serialnumber from hex to base10 requires a 64-bit > capable > Perl, and my guess is that prairiedog has a 32-bit Perl. Yup, it does. regards, tom lane

Re: pgsql: Refactor the sslfiles Makefile target for ease of use

2021-10-20 Thread Daniel Gustafsson
> On 19 Oct 2021, at 20:17, Daniel Gustafsson > wrote: > > Refactor the sslfiles Makefile target for ease of use This made prairiedog fall over in the SSL tests [0], with what seems a pretty straightforward reason: 32- vs 64-bit Perl. Integer overflow in hexadecimal number at t/001_ssltests.

Re: pgsql: Ensure correct lock level is used in ALTER ... RENAME

2021-10-20 Thread Alvaro Herrera
Hi, On 2021-Oct-20, Michael Paquier wrote: > hippopotamus and jay are complaining that this commit has introduced a > test with ordering issues: > ORDER BY relation::regclass::text; Oh, I forgot that we need a COLLATE clause there. Will fix, thanks ... -- Álvaro Herrera Valdivi

Re: pgsql: Ensure correct lock level is used in ALTER ... RENAME

2021-10-20 Thread Michael Paquier
Hi Alvaro, On Tue, Oct 19, 2021 at 10:11:24PM +, Alvaro Herrera wrote: > Ensure correct lock level is used in ALTER ... RENAME > > Commit 1b5d797cd4f7 intended to relax the lock level used to rename > indexes, but inadvertently allowed *any* relation to be renamed with a > lowered lock level,

pgsql: Fix build of MSVC with OpenSSL 3.0.0

2021-10-20 Thread Michael Paquier
Fix build of MSVC with OpenSSL 3.0.0 The build scripts of Visual Studio would fail to detect properly a 3.0.0 build as the check on the second digit was failing. This is adjusted where needed, allowing the builds to complete. Note that the MSIs of OpenSSL mentioned in the documentation have not

pgsql: Fix build of MSVC with OpenSSL 3.0.0

2021-10-20 Thread Michael Paquier
Fix build of MSVC with OpenSSL 3.0.0 The build scripts of Visual Studio would fail to detect properly a 3.0.0 build as the check on the second digit was failing. This is adjusted where needed, allowing the builds to complete. Note that the MSIs of OpenSSL mentioned in the documentation have not

pgsql: Fix build of MSVC with OpenSSL 3.0.0

2021-10-20 Thread Michael Paquier
Fix build of MSVC with OpenSSL 3.0.0 The build scripts of Visual Studio would fail to detect properly a 3.0.0 build as the check on the second digit was failing. This is adjusted where needed, allowing the builds to complete. Note that the MSIs of OpenSSL mentioned in the documentation have not

pgsql: Fix build of MSVC with OpenSSL 3.0.0

2021-10-20 Thread Michael Paquier
Fix build of MSVC with OpenSSL 3.0.0 The build scripts of Visual Studio would fail to detect properly a 3.0.0 build as the check on the second digit was failing. This is adjusted where needed, allowing the builds to complete. Note that the MSIs of OpenSSL mentioned in the documentation have not

pgsql: Fix build of MSVC with OpenSSL 3.0.0

2021-10-20 Thread Michael Paquier
Fix build of MSVC with OpenSSL 3.0.0 The build scripts of Visual Studio would fail to detect properly a 3.0.0 build as the check on the second digit was failing. This is adjusted where needed, allowing the builds to complete. Note that the MSIs of OpenSSL mentioned in the documentation have not

pgsql: Fix build of MSVC with OpenSSL 3.0.0

2021-10-20 Thread Michael Paquier
Fix build of MSVC with OpenSSL 3.0.0 The build scripts of Visual Studio would fail to detect properly a 3.0.0 build as the check on the second digit was failing. This is adjusted where needed, allowing the builds to complete. Note that the MSIs of OpenSSL mentioned in the documentation have not

pgsql: Fix build of MSVC with OpenSSL 3.0.0

2021-10-20 Thread Michael Paquier
Fix build of MSVC with OpenSSL 3.0.0 The build scripts of Visual Studio would fail to detect properly a 3.0.0 build as the check on the second digit was failing. This is adjusted where needed, allowing the builds to complete. Note that the MSIs of OpenSSL mentioned in the documentation have not