Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().

2021-10-26 Thread Bharath Rupireddy
On Wed, Oct 27, 2021 at 10:33 AM Michael Paquier wrote: > > On Wed, Oct 27, 2021 at 10:27:18AM +0530, Bharath Rupireddy wrote: > > +1 and the above statement looks good. Apart from that I have one more > > suggestion that I earlier made: have the function produce the error > > when no permissions

Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().

2021-10-26 Thread Michael Paquier
On Wed, Oct 27, 2021 at 10:27:18AM +0530, Bharath Rupireddy wrote: > +1 and the above statement looks good. Apart from that I have one more > suggestion that I earlier made: have the function produce the error > when no permissions were granted (just to ensure we have the error > message covered) i

Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().

2021-10-26 Thread Bharath Rupireddy
On Wed, Oct 27, 2021 at 9:45 AM Michael Paquier wrote: > > On Tue, Oct 26, 2021 at 08:41:11PM +, Jeff Davis wrote: > > Allow GRANT on pg_log_backend_memory_contexts(). > > > > Remove superuser check, allowing any user granted permissions on > > pg_log_backend_memory_contexts() to log the memor

Re: pgsql: Allow GRANT on pg_log_backend_memory_contexts().

2021-10-26 Thread Michael Paquier
On Tue, Oct 26, 2021 at 08:41:11PM +, Jeff Davis wrote: > Allow GRANT on pg_log_backend_memory_contexts(). > > Remove superuser check, allowing any user granted permissions on > pg_log_backend_memory_contexts() to log the memory contexts of any > backend. > > Note that this could allow a priv

pgsql: Allow publishing the tables of schema.

2021-10-26 Thread Amit Kapila
Allow publishing the tables of schema. A new option "FOR ALL TABLES IN SCHEMA" in Create/Alter Publication allows one or more schemas to be specified, whose tables are selected by the publisher for sending the data to the subscriber. The new syntax allows specifying both the tables and schemas. F

pgsql: Allow GRANT on pg_log_backend_memory_contexts().

2021-10-26 Thread Jeff Davis
Allow GRANT on pg_log_backend_memory_contexts(). Remove superuser check, allowing any user granted permissions on pg_log_backend_memory_contexts() to log the memory contexts of any backend. Note that this could allow a privileged non-superuser to log the memory contexts of a superuser backend, bu

Re: pgsql: Refactor the sslfiles Makefile target for ease of use

2021-10-26 Thread Daniel Gustafsson
> On 26 Oct 2021, at 19:41, Andres Freund wrote: > > Hi, > > On 2021-10-19 18:17:34 +, Daniel Gustafsson wrote: >> Refactor the sslfiles Makefile target for ease of use >> >> The Makefile handling of certificate and keypairs used for TLS testing >> had become quite difficult to work with. A

Re: pgsql: Refactor the sslfiles Makefile target for ease of use

2021-10-26 Thread Andres Freund
Hi, On 2021-10-19 18:17:34 +, Daniel Gustafsson wrote: > Refactor the sslfiles Makefile target for ease of use > > The Makefile handling of certificate and keypairs used for TLS testing > had become quite difficult to work with. Adding a new cert without the > need to regenerate everything wa

pgsql: Improve HINT message that FDW reports when there are no valid op

2021-10-26 Thread Fujii Masao
Improve HINT message that FDW reports when there are no valid options. The foreign data wrapper's validator function provides a HINT message with list of valid options for the object specified in CREATE or ALTER command, when the option given in the command is invalid. Previously postgresql_fdw_va

pgsql: Ensure that slots are zeroed before use

2021-10-26 Thread Daniel Gustafsson
Ensure that slots are zeroed before use The previous coding relied on the memory for the slots being zeroed elsewhere, which while it was true in this case is not an contract which is guaranteed to hold. Explicitly clear the tts_isnull array to ensure that the slots are filled from a known state.

pgsql: Ensure that slots are zeroed before use

2021-10-26 Thread Daniel Gustafsson
Ensure that slots are zeroed before use The previous coding relied on the memory for the slots being zeroed elsewhere, which while it was true in this case is not an contract which is guaranteed to hold. Explicitly clear the tts_isnull array to ensure that the slots are filled from a known state.