pgsql: Fix some thinkos with pg_receivewal --compression-method

2021-11-03 Thread Michael Paquier
Fix some thinkos with pg_receivewal --compression-method The option name was incorrect in one of the error messages, and the short option 'I' was used in the code but we did not intend things to be this way. While on it, fix the documentation to refer to a "method", and not a "level. Oversights

pgsql: Rework compression options of pg_receivewal

2021-11-03 Thread Michael Paquier
Rework compression options of pg_receivewal pg_receivewal includes since cada1af the option --compress, to allow the compression of WAL segments using gzip, with a value of 0 (the default) meaning that no compression can be used. This commit introduces a new option, called --compression-method, a

pgsql: Add another old commit to git-blame-ignore-revs.

2021-11-03 Thread Peter Geoghegan
Add another old commit to git-blame-ignore-revs. Add another historic pgindent commit that was missed by the initial work done in commit 8e638845. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/581055c32fbb5018431265877754cbd8019bc012 Modified Files --

Re: pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Daniel Gustafsson
> On 3 Nov 2021, at 18:47, Heikki Linnakangas wrote: > > On 03/11/2021 13:06, Daniel Gustafsson wrote: >>> On 3 Nov 2021, at 10:44, Heikki Linnakangas >>> wrote: >>> Fix snapshot reference leak if lo_export fails. >> This commit seems to lack the update in largeobject_1 as per hamerkop in: > >

Re: pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Heikki Linnakangas
On 03/11/2021 13:06, Daniel Gustafsson wrote: On 3 Nov 2021, at 10:44, Heikki Linnakangas wrote: Fix snapshot reference leak if lo_export fails. This commit seems to lack the update in largeobject_1 as per hamerkop in: Fixed, thanks! I'm a bit surprised none of the other Windows systems

pgsql: Update alternative expected output file.

2021-11-03 Thread Heikki Linnakangas
Update alternative expected output file. Previous commit added a test to 'largeobject', but neglected the alternative expected output file 'largeobject_1.source'. Per failure on buildfarm animal 'hamerkop'. Discussion: https://www.postgresql.org/message-id/dba08346-9962-4706-92d1-230ee5201...@ye

pgsql: Update alternative expected output file.

2021-11-03 Thread Heikki Linnakangas
Update alternative expected output file. Previous commit added a test to 'largeobject', but neglected the alternative expected output file 'largeobject_1.source'. Per failure on buildfarm animal 'hamerkop'. Discussion: https://www.postgresql.org/message-id/dba08346-9962-4706-92d1-230ee5201...@ye

pgsql: Update alternative expected output file.

2021-11-03 Thread Heikki Linnakangas
Update alternative expected output file. Previous commit added a test to 'largeobject', but neglected the alternative expected output file 'largeobject_1.source'. Per failure on buildfarm animal 'hamerkop'. Discussion: https://www.postgresql.org/message-id/dba08346-9962-4706-92d1-230ee5201...@ye

pgsql: Update alternative expected output file.

2021-11-03 Thread Heikki Linnakangas
Update alternative expected output file. Previous commit added a test to 'largeobject', but neglected the alternative expected output file 'largeobject_1.source'. Per failure on buildfarm animal 'hamerkop'. Discussion: https://www.postgresql.org/message-id/dba08346-9962-4706-92d1-230ee5201...@ye

pgsql: Update alternative expected output file.

2021-11-03 Thread Heikki Linnakangas
Update alternative expected output file. Previous commit added a test to 'largeobject', but neglected the alternative expected output file 'largeobject_1.source'. Per failure on buildfarm animal 'hamerkop'. Discussion: https://www.postgresql.org/message-id/dba08346-9962-4706-92d1-230ee5201...@ye

pgsql: Update alternative expected output file.

2021-11-03 Thread Heikki Linnakangas
Update alternative expected output file. Previous commit added a test to 'largeobject', but neglected the alternative expected output file 'largeobject_1.source'. Per failure on buildfarm animal 'hamerkop'. Discussion: https://www.postgresql.org/message-id/dba08346-9962-4706-92d1-230ee5201...@ye

pgsql: Update alternative expected output file.

2021-11-03 Thread Heikki Linnakangas
Update alternative expected output file. Previous commit added a test to 'largeobject', but neglected the alternative expected output file 'largeobject_1.source'. Per failure on buildfarm animal 'hamerkop'. Discussion: https://www.postgresql.org/message-id/dba08346-9962-4706-92d1-230ee5201...@ye

Re: pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Daniel Gustafsson
> On 3 Nov 2021, at 10:44, Heikki Linnakangas wrote: > Fix snapshot reference leak if lo_export fails. This commit seems to lack the update in largeobject_1 as per hamerkop in: https://brekka.postgresql.org/cgi-bin/show_log.pl?nm=hamerkop&dt=2021-11-03%2010%3A42%3A37 -- Daniel Gustafsson

pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Heikki Linnakangas
Fix snapshot reference leak if lo_export fails. If lo_export() fails to open the target file or to write to it, it leaks the created LargeObjectDesc and its snapshot in the top-transaction context and resource owner. That's pretty harmless, it's a small leak after all, but it gives the user a "Sna

pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Heikki Linnakangas
Fix snapshot reference leak if lo_export fails. If lo_export() fails to open the target file or to write to it, it leaks the created LargeObjectDesc and its snapshot in the top-transaction context and resource owner. That's pretty harmless, it's a small leak after all, but it gives the user a "Sna

pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Heikki Linnakangas
Fix snapshot reference leak if lo_export fails. If lo_export() fails to open the target file or to write to it, it leaks the created LargeObjectDesc and its snapshot in the top-transaction context and resource owner. That's pretty harmless, it's a small leak after all, but it gives the user a "Sna

pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Heikki Linnakangas
Fix snapshot reference leak if lo_export fails. If lo_export() fails to open the target file or to write to it, it leaks the created LargeObjectDesc and its snapshot in the top-transaction context and resource owner. That's pretty harmless, it's a small leak after all, but it gives the user a "Sna

pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Heikki Linnakangas
Fix snapshot reference leak if lo_export fails. If lo_export() fails to open the target file or to write to it, it leaks the created LargeObjectDesc and its snapshot in the top-transaction context and resource owner. That's pretty harmless, it's a small leak after all, but it gives the user a "Sna

pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Heikki Linnakangas
Fix snapshot reference leak if lo_export fails. If lo_export() fails to open the target file or to write to it, it leaks the created LargeObjectDesc and its snapshot in the top-transaction context and resource owner. That's pretty harmless, it's a small leak after all, but it gives the user a "Sna

pgsql: Fix snapshot reference leak if lo_export fails.

2021-11-03 Thread Heikki Linnakangas
Fix snapshot reference leak if lo_export fails. If lo_export() fails to open the target file or to write to it, it leaks the created LargeObjectDesc and its snapshot in the top-transaction context and resource owner. That's pretty harmless, it's a small leak after all, but it gives the user a "Sna