pgsql: Report any XLogReadRecord() error in XlogReadTwoPhaseData().

2021-11-11 Thread Noah Misch
Report any XLogReadRecord() error in XlogReadTwoPhaseData(). Buildfarm members kittiwake and tadarida have witnessed errors at this site. The site discarded key facts. Back-patch to v10 (all supported versions). Reviewed by Michael Paquier and Tom Lane. Discussion: https://postgr.es/m/20211107

pgsql: Report any XLogReadRecord() error in XlogReadTwoPhaseData().

2021-11-11 Thread Noah Misch
Report any XLogReadRecord() error in XlogReadTwoPhaseData(). Buildfarm members kittiwake and tadarida have witnessed errors at this site. The site discarded key facts. Back-patch to v10 (all supported versions). Reviewed by Michael Paquier and Tom Lane. Discussion: https://postgr.es/m/20211107

pgsql: Report any XLogReadRecord() error in XlogReadTwoPhaseData().

2021-11-11 Thread Noah Misch
Report any XLogReadRecord() error in XlogReadTwoPhaseData(). Buildfarm members kittiwake and tadarida have witnessed errors at this site. The site discarded key facts. Back-patch to v10 (all supported versions). Reviewed by Michael Paquier and Tom Lane. Discussion: https://postgr.es/m/20211107

pgsql: Report any XLogReadRecord() error in XlogReadTwoPhaseData().

2021-11-11 Thread Noah Misch
Report any XLogReadRecord() error in XlogReadTwoPhaseData(). Buildfarm members kittiwake and tadarida have witnessed errors at this site. The site discarded key facts. Back-patch to v10 (all supported versions). Reviewed by Michael Paquier and Tom Lane. Discussion: https://postgr.es/m/20211107

pgsql: Report any XLogReadRecord() error in XlogReadTwoPhaseData().

2021-11-11 Thread Noah Misch
Report any XLogReadRecord() error in XlogReadTwoPhaseData(). Buildfarm members kittiwake and tadarida have witnessed errors at this site. The site discarded key facts. Back-patch to v10 (all supported versions). Reviewed by Michael Paquier and Tom Lane. Discussion: https://postgr.es/m/20211107

pgsql: Report any XLogReadRecord() error in XlogReadTwoPhaseData().

2021-11-11 Thread Noah Misch
Report any XLogReadRecord() error in XlogReadTwoPhaseData(). Buildfarm members kittiwake and tadarida have witnessed errors at this site. The site discarded key facts. Back-patch to v10 (all supported versions). Reviewed by Michael Paquier and Tom Lane. Discussion: https://postgr.es/m/20211107

pgsql: Update heap_page_prune() free space map comments.

2021-11-11 Thread Peter Geoghegan
Update heap_page_prune() free space map comments. It is up to the heap_page_prune() caller to decide what to do about updating the FSM for a page following pruning. Update old comments that address what we might want to do as if it was the responsibility of heap_page_prune() itself. heap_page_pr

pgsql: Update another obsolete reference in vacuumlazy.c.

2021-11-11 Thread Peter Geoghegan
Update another obsolete reference in vacuumlazy.c. Addresses an oversight in commit 7ab96cf6. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eb9baef8e92adf81c6adbe44f1d67878d850bff7 Modified Files -- src/backend/access/heap/vacuumlazy.c | 9 + 1

pgsql: Improve performance of pgarch_readyXlog() with many status files

2021-11-11 Thread Robert Haas
Improve performance of pgarch_readyXlog() with many status files. Presently, the archive_status directory was scanned for each file to archive. When there are many status files, say because archive_command has been failing for a long time, these directory scans can get very slow. With this chang

pgsql: Fall back to unsigned int, not int, for socklen_t.

2021-11-11 Thread Tom Lane
Fall back to unsigned int, not int, for socklen_t. It's a coin toss which of these is a better default assumption. However, of the machines we have in the buildfarm, the only ones relying on the fallback socklen_t definition are ancient HPUX, and on that platform unsigned int is the right choice.

pgsql: Restore lock level to set vacuum flags

2021-11-11 Thread Alvaro Herrera
Restore lock level to set vacuum flags Commit 27838981be9d mistakenly reduced the lock level from exclusive to shared that is acquired to set PGPROC->statusFlags; this was reverted by dcfff74fb166, but failed to do so in one spot. Fix it. Backpatch to 14. Noted by Andres Freund. Discussion: h

pgsql: Restore lock level to set vacuum flags

2021-11-11 Thread Alvaro Herrera
Restore lock level to set vacuum flags Commit 27838981be9d mistakenly reduced the lock level from exclusive to shared that is acquired to set PGPROC->statusFlags; this was reverted by dcfff74fb166, but failed to do so in one spot. Fix it. Backpatch to 14. Noted by Andres Freund. Discussion: h

pgsql: doc: Add referential actions to CREATE/ALTER TABLE synopsis

2021-11-11 Thread Peter Eisentraut
doc: Add referential actions to CREATE/ALTER TABLE synopsis The general constraint synopsis references "referential_action", but this was not further defined in the synopsis section. Compared to the level of detail that the synopsis gives to other subclauses, this should surely be there. extract