pgsql: Explain pruning pgstats accounting subtleties.

2021-11-12 Thread Peter Geoghegan
Explain pruning pgstats accounting subtleties. Add a comment explaining why the pgstats accounting used during opportunistic heap pruning operations (to maintain the current number of dead tuples in the relation) needs to compensate by subtracting away the number of new LP_DEAD items. This is

pgsql: Document PG_TEST_NOCLEAN in TAP test README

2021-11-12 Thread Daniel Gustafsson
Document PG_TEST_NOCLEAN in TAP test README Commit 90627cf98 added support for retaining the data directory even on successful tests, but failed to document the environment variable which controls retention. This adds a small note to the TAP test README about PG_TEST_NOCLEAN which when set skips

pgsql: Make psql's \password default to CURRENT_USER, not PQuser(conn).

2021-11-12 Thread Tom Lane
Make psql's \password default to CURRENT_USER, not PQuser(conn). The documentation says plainly that \password acts on "the current user" by default. What it actually acted on, or tried to, was the username used to log into the current session. This is not the same thing if one has since done

pgsql: Make psql's \password default to CURRENT_USER, not PQuser(conn).

2021-11-12 Thread Tom Lane
Make psql's \password default to CURRENT_USER, not PQuser(conn). The documentation says plainly that \password acts on "the current user" by default. What it actually acted on, or tried to, was the username used to log into the current session. This is not the same thing if one has since done

pgsql: Make psql's \password default to CURRENT_USER, not PQuser(conn).

2021-11-12 Thread Tom Lane
Make psql's \password default to CURRENT_USER, not PQuser(conn). The documentation says plainly that \password acts on "the current user" by default. What it actually acted on, or tried to, was the username used to log into the current session. This is not the same thing if one has since done

pgsql: Make psql's \password default to CURRENT_USER, not PQuser(conn).

2021-11-12 Thread Tom Lane
Make psql's \password default to CURRENT_USER, not PQuser(conn). The documentation says plainly that \password acts on "the current user" by default. What it actually acted on, or tried to, was the username used to log into the current session. This is not the same thing if one has since done

pgsql: Make psql's \password default to CURRENT_USER, not PQuser(conn).

2021-11-12 Thread Tom Lane
Make psql's \password default to CURRENT_USER, not PQuser(conn). The documentation says plainly that \password acts on "the current user" by default. What it actually acted on, or tried to, was the username used to log into the current session. This is not the same thing if one has since done

pgsql: Make psql's \password default to CURRENT_USER, not PQuser(conn).

2021-11-12 Thread Tom Lane
Make psql's \password default to CURRENT_USER, not PQuser(conn). The documentation says plainly that \password acts on "the current user" by default. What it actually acted on, or tried to, was the username used to log into the current session. This is not the same thing if one has since done

Re: pgsql: Remove check for accept() argument types

2021-11-12 Thread Tom Lane
I wrote: > Peter Eisentraut writes: >> What does the man page say the correct type >> would be? size_t? > The machine's not booted up right now :-(. But I'm pretty sure we > shouldn't consider using size_t here, as it's not real clear that that > couldn't be 64 bits on any affected platforms.

pgsql: postgres_fdw: suppress casts on constants in limited cases.

2021-11-12 Thread Tom Lane
postgres_fdw: suppress casts on constants in limited cases. When deparsing an expression of the form "remote_var OP constant", we'd normally apply a cast to the constant to make sure that the remote parser thinks it's of the same type we do. However, doing so is often not necessary, and it

pgsql: Report found versions of required perl modules

2021-11-12 Thread Andrew Dunstan
Report found versions of required perl modules Configure tests for the presence of perl modules required for TAP tests, and that they meet specified minimum version requirements. This patch makes it report the version of the module that's actually found rather than just an 'ok' message. This will

Re: pgsql: Remove check for accept() argument types

2021-11-12 Thread Tom Lane
Peter Eisentraut writes: > On 10.11.21 16:41, Tom Lane wrote: >> May I suggest that "unsigned int" would be a better choice >> than "int" for socklen_t? > I have been waiting for a few more buildfarm members to finish (mainly > the other AIX and HPUX instances), but they appear to be on strike

pgsql: Tag refs/tags/REL_13_5 was created

2021-11-12 Thread noreply
Tag refs/tags/REL_13_5 was created.

pgsql: Tag refs/tags/REL_12_9 was created

2021-11-12 Thread noreply
Tag refs/tags/REL_12_9 was created.

pgsql: Tag refs/tags/REL_11_14 was created

2021-11-12 Thread noreply
Tag refs/tags/REL_11_14 was created.

pgsql: Tag refs/tags/REL_14_1 was created

2021-11-12 Thread noreply
Tag refs/tags/REL_14_1 was created.

pgsql: Tag refs/tags/REL9_6_24 was created

2021-11-12 Thread noreply
Tag refs/tags/REL9_6_24 was created.

pgsql: Tag refs/tags/REL_10_19 was created

2021-11-12 Thread noreply
Tag refs/tags/REL_10_19 was created.

pgsql: Last-minute updates for release notes.

2021-11-12 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2021-23214, CVE-2021-23222 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/402c3ba3954d81531b6c9ff9b5d554552a85c6a7 Modified Files -- doc/src/sgml/release-13.sgml | 70

pgsql: Last-minute updates for release notes.

2021-11-12 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2021-23214, CVE-2021-23222 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3eadebaa975d8a0af444b8ecc4a84854cdd7920a Modified Files -- doc/src/sgml/release-10.sgml | 70

pgsql: Last-minute updates for release notes.

2021-11-12 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2021-23214, CVE-2021-23222 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/965e7b1e8531341fed3ade7d03d9ee85fa7793d4 Modified Files -- doc/src/sgml/release-11.sgml | 70

pgsql: Last-minute updates for release notes.

2021-11-12 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2021-23214, CVE-2021-23222 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ddc6917c314ddcf16f56dd2cfd52fbc721760b07 Modified Files -- doc/src/sgml/release-14.sgml | 86

pgsql: Last-minute updates for release notes.

2021-11-12 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2021-23214, CVE-2021-23222 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9f06c0755e8f9dc8d196b3dc8722138bf04d5d59 Modified Files -- doc/src/sgml/release-12.sgml | 70

pgsql: Reject extraneous data after SSL or GSS encryption handshake.

2021-11-12 Thread Tom Lane
Reject extraneous data after SSL or GSS encryption handshake. The server collects up to a bufferload of data whenever it reads data from the client socket. When SSL or GSS encryption is requested during startup, any additional data received with the initial request message remained in the

pgsql: Last-minute updates for release notes.

2021-11-12 Thread Tom Lane
Last-minute updates for release notes. Security: CVE-2021-23214, CVE-2021-23222 Branch -- REL9_6_STABLE Details --- https://git.postgresql.org/pg/commitdiff/cace98d76cab8882125f6fbbe919f789fe2b9ee3 Modified Files -- doc/src/sgml/release-9.6.sgml | 70

pgsql: libpq: reject extraneous data after SSL or GSS encryption handsh

2021-11-12 Thread Tom Lane
libpq: reject extraneous data after SSL or GSS encryption handshake. libpq collects up to a bufferload of data whenever it reads data from the socket. When SSL or GSS encryption is requested during startup, any additional data received with the server's yes-or-no reply remained in the buffer,

pgsql: libpq: reject extraneous data after SSL or GSS encryption handsh

2021-11-12 Thread Tom Lane
libpq: reject extraneous data after SSL or GSS encryption handshake. libpq collects up to a bufferload of data whenever it reads data from the socket. When SSL or GSS encryption is requested during startup, any additional data received with the server's yes-or-no reply remained in the buffer,

pgsql: Reject extraneous data after SSL or GSS encryption handshake.

2021-11-12 Thread Tom Lane
Reject extraneous data after SSL or GSS encryption handshake. The server collects up to a bufferload of data whenever it reads data from the client socket. When SSL or GSS encryption is requested during startup, any additional data received with the initial request message remained in the

pgsql: Reject extraneous data after SSL or GSS encryption handshake.

2021-11-12 Thread Tom Lane
Reject extraneous data after SSL or GSS encryption handshake. The server collects up to a bufferload of data whenever it reads data from the client socket. When SSL or GSS encryption is requested during startup, any additional data received with the initial request message remained in the

pgsql: Reject extraneous data after SSL or GSS encryption handshake.

2021-11-12 Thread Tom Lane
Reject extraneous data after SSL or GSS encryption handshake. The server collects up to a bufferload of data whenever it reads data from the client socket. When SSL or GSS encryption is requested during startup, any additional data received with the initial request message remained in the

pgsql: libpq: reject extraneous data after SSL or GSS encryption handsh

2021-11-12 Thread Tom Lane
libpq: reject extraneous data after SSL or GSS encryption handshake. libpq collects up to a bufferload of data whenever it reads data from the socket. When SSL or GSS encryption is requested during startup, any additional data received with the server's yes-or-no reply remained in the buffer,

pgsql: Reject extraneous data after SSL or GSS encryption handshake.

2021-11-12 Thread Tom Lane
Reject extraneous data after SSL or GSS encryption handshake. The server collects up to a bufferload of data whenever it reads data from the client socket. When SSL or GSS encryption is requested during startup, any additional data received with the initial request message remained in the

pgsql: Reject extraneous data after SSL or GSS encryption handshake.

2021-11-12 Thread Tom Lane
Reject extraneous data after SSL or GSS encryption handshake. The server collects up to a bufferload of data whenever it reads data from the client socket. When SSL or GSS encryption is requested during startup, any additional data received with the initial request message remained in the

pgsql: libpq: reject extraneous data after SSL or GSS encryption handsh

2021-11-12 Thread Tom Lane
libpq: reject extraneous data after SSL or GSS encryption handshake. libpq collects up to a bufferload of data whenever it reads data from the socket. When SSL or GSS encryption is requested during startup, any additional data received with the server's yes-or-no reply remained in the buffer,

pgsql: libpq: reject extraneous data after SSL or GSS encryption handsh

2021-11-12 Thread Tom Lane
libpq: reject extraneous data after SSL or GSS encryption handshake. libpq collects up to a bufferload of data whenever it reads data from the socket. When SSL or GSS encryption is requested during startup, any additional data received with the server's yes-or-no reply remained in the buffer,

pgsql: libpq: reject extraneous data after SSL or GSS encryption handsh

2021-11-12 Thread Tom Lane
libpq: reject extraneous data after SSL or GSS encryption handshake. libpq collects up to a bufferload of data whenever it reads data from the socket. When SSL or GSS encryption is requested during startup, any additional data received with the server's yes-or-no reply remained in the buffer,

pgsql: libpq: reject extraneous data after SSL or GSS encryption handsh

2021-11-12 Thread Tom Lane
libpq: reject extraneous data after SSL or GSS encryption handshake. libpq collects up to a bufferload of data whenever it reads data from the socket. When SSL or GSS encryption is requested during startup, any additional data received with the server's yes-or-no reply remained in the buffer,

pgsql: Reject extraneous data after SSL or GSS encryption handshake.

2021-11-12 Thread Tom Lane
Reject extraneous data after SSL or GSS encryption handshake. The server collects up to a bufferload of data whenever it reads data from the client socket. When SSL or GSS encryption is requested during startup, any additional data received with the initial request message remained in the

Re: pgsql: Remove check for accept() argument types

2021-11-12 Thread Peter Eisentraut
On 10.11.21 16:41, Tom Lane wrote: Peter Eisentraut writes: Remove check for accept() argument types Early returns from the buildfarm are gaur | 2021-11-09 16:55:58 | auth.c:3235:17: warning: pointer targets in passing argument 6 of 'recvfrom' differ in signedness gaur

pgsql: Fix memory overrun when querying pg_stat_slru

2021-11-12 Thread Michael Paquier
Fix memory overrun when querying pg_stat_slru pg_stat_get_slru() in pgstatfuncs.c would point to one element after the end of the array PgStat_SLRUStats when finishing to scan its entries. This had no direct consequences as no data from the extra memory area was read, but static analyzers would

pgsql: Fix memory overrun when querying pg_stat_slru

2021-11-12 Thread Michael Paquier
Fix memory overrun when querying pg_stat_slru pg_stat_get_slru() in pgstatfuncs.c would point to one element after the end of the array PgStat_SLRUStats when finishing to scan its entries. This had no direct consequences as no data from the extra memory area was read, but static analyzers would

pgsql: Fix memory overrun when querying pg_stat_slru

2021-11-12 Thread Michael Paquier
Fix memory overrun when querying pg_stat_slru pg_stat_get_slru() in pgstatfuncs.c would point to one element after the end of the array PgStat_SLRUStats when finishing to scan its entries. This had no direct consequences as no data from the extra memory area was read, but static analyzers would