Noah Misch writes:
> On Sat, Nov 20, 2021 at 08:22:14PM -0500, Tom Lane wrote:
>> I think we need a back-patch of *something*. It's pure luck that wrasse
>> hasn't shown problems already. I don't want to be rediscovering this
>> issue a year from now when somebody back-patches some test requirin
On Sat, Nov 20, 2021 at 08:22:14PM -0500, Tom Lane wrote:
> Noah Misch writes:
> > On Sat, Nov 20, 2021 at 07:50:02PM -0500, Tom Lane wrote:
> >> What I'm inclined to do is temporarily push `dirname $PERL` onto the front
> >> of PATH while running
> >> PGAC_PATH_PROGS(PROVE, prove)
>
> > Adding t
Noah Misch writes:
> On Sat, Nov 20, 2021 at 07:50:02PM -0500, Tom Lane wrote:
>> What I'm inclined to do is temporarily push `dirname $PERL` onto the front
>> of PATH while running
>> PGAC_PATH_PROGS(PROVE, prove)
> Adding to PATH, even briefly, is way too brazen. You'd need to be sure that
> P
On Sat, Nov 20, 2021 at 07:50:02PM -0500, Tom Lane wrote:
> Noah Misch writes:
> > Yep. wrasse sets PERL to a manually-installed Perl, but PROVE still uses an
> > old Perl. I'll fix that somehow.
>
> A quick workaround is to set PROVE in the animal's config_env, but
> I don't think that's ideal
I wrote:
> What I'm inclined to do is temporarily push `dirname $PERL` onto the front
> of PATH while running
> PGAC_PATH_PROGS(PROVE, prove)
The attached seems like it will work. I think we want to backpatch
this, since the wrong-PROVE hazard is the same in all branches.
Noah Misch writes:
> Yep. wrasse sets PERL to a manually-installed Perl, but PROVE still uses an
> old Perl. I'll fix that somehow.
A quick workaround is to set PROVE in the animal's config_env, but
I don't think that's ideal, because configure then skips module
presence tests:
# Check for n
I wrote:
> So apparently the true issue is that this test is somehow failing to use
> the same perl, or the same perl import path, as configure did.
Oh, I see it: wrasse is configured to use a nondefault Perl:
'config_env' => {
'PERL' => '/home/nm/sw/nopath/perl64/bin/perl',
bu
On Sat, Nov 20, 2021 at 07:32:23PM -0500, Tom Lane wrote:
> I wrote:
> > Hah, looks like wrasse beat me to it [1]. I'd supposed that Noah
> > was using a manually-installed Perl there, but maybe not?
>
> No, wait, I *did* check wrasse. Its configure run reports
>
> checking for perl module Test
I wrote:
> Hah, looks like wrasse beat me to it [1]. I'd supposed that Noah
> was using a manually-installed Perl there, but maybe not?
No, wait, I *did* check wrasse. Its configure run reports
checking for perl module Test::More 0.98... 1.302162
so everything looks fine there. But now we hav
Andrew Dunstan writes:
> Require version 0.98 of Test::More for TAP tests
> This means that the subtest feature will be available for use.
> We expect that this change will make prairiedog go red until it is
> updated, but other buildfarm animals should be fine.
Hah, looks like wrasse beat me to
Require version 0.98 of Test::More for TAP tests
This means that the subtest feature will be available for use.
We expect that this change will make prairiedog go red until it is
updated, but other buildfarm animals should be fine.
Discussion:
https://postgr.es/m/f5e1d308-4e33-37a7-bdf1-f6e0c75
Fix SP-GiST scan initialization logic for binary-compatible cases.
Commit ac9099fc1 rearranged the logic in spgGetCache() that determines
the index's attType (nominal input data type) and leafType (actual
type stored in leaf index tuples). Turns out this broke things for
the case where (a) the ac
Fix SP-GiST scan initialization logic for binary-compatible cases.
Commit ac9099fc1 rearranged the logic in spgGetCache() that determines
the index's attType (nominal input data type) and leafType (actual
type stored in leaf index tuples). Turns out this broke things for
the case where (a) the ac
13 matches
Mail list logo
