Re: pgsql: Add a view to show the stats of subscription workers.

On Tue, Nov 30, 2021 at 3:04 PM Amit Kapila wrote: > > On Tue, Nov 30, 2021 at 9:05 AM Amit Kapila wrote: > > > > Add a view to show the stats of subscription workers. > > > > sidewinder is showing failure in the test added by this patch: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=

Re: pgsql: Add a view to show the stats of subscription workers.

On Tue, Nov 30, 2021 at 9:05 AM Amit Kapila wrote: > > Add a view to show the stats of subscription workers. > sidewinder is showing failure in the test added by this patch: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=sidewinder&dt=2021-11-30%2005%3A05%3A25 I'll investigate and share

pgsql: Fix flags of some GUCs and improve some descriptions

Fix flags of some GUCs and improve some descriptions This commit fixes some issues with GUCs: - enable_incremental_sort was not marked as GUC_EXPLAIN, causing it to not be listed in the output of EXPLAIN (SETTINGS) if using a value different than the default, contrary to the other planner-level GU

pgsql: Add a view to show the stats of subscription workers.

Add a view to show the stats of subscription workers. This commit adds a new system view pg_stat_subscription_workers, that shows information about any errors which occur during the application of logical replication changes as well as during performing initial table synchronization. The subscript

pgsql: Fix typos

Fix typos Author: Lingjie Qiang Discussion: https://postgr.es/m/osapr01mb71654e773f62ac88dc1fc8cc80...@osapr01mb7165.jpnprd01.prod.outlook.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/98105e53e0ab472b7721a3e8d7b9f1750a635120 Modified Files -- sr

pgsql: Fix compatibility thinko for fstat() on standard streams in win3

Fix compatibility thinko for fstat() on standard streams in win32stat.c GetFinalPathNameByHandleA() cannot be used in compilation environments where _WIN32_WINNT < 0x0600, meaning at least Windows XP used by some buildfarm members under MinGW that Postgres still needs to support. This was reported

pgsql: Fix compatibility thinko for fstat() on standard streams in win3

Fix compatibility thinko for fstat() on standard streams in win32stat.c GetFinalPathNameByHandleA() cannot be used in compilation environments where _WIN32_WINNT < 0x0600, meaning at least Windows XP used by some buildfarm members under MinGW that Postgres still needs to support. This was reported

pgsql: vacuumlazy.c: Rename dead_tuples to dead_items.

vacuumlazy.c: Rename dead_tuples to dead_items. Commit 8523492d simplified what it meant for an item to be considered "dead" to VACUUM: TIDs collected in memory (in preparation for index vacuuming) must always come from LP_DEAD stub line pointers in heap pages, found following pruning. This forma

pgsql: Doc: improve documentation about ORDER BY in matviews.

Doc: improve documentation about ORDER BY in matviews. Remove the confusing use of ORDER BY in an example materialized view. It adds nothing to the example, but might encourage people to follow bad practice. Clarify REFRESH MATERIALIZED VIEW's note about whether view ordering is retained (it isn

pgsql: Doc: improve documentation about ORDER BY in matviews.

Doc: improve documentation about ORDER BY in matviews. Remove the confusing use of ORDER BY in an example materialized view. It adds nothing to the example, but might encourage people to follow bad practice. Clarify REFRESH MATERIALIZED VIEW's note about whether view ordering is retained (it isn

pgsql: Doc: improve documentation about ORDER BY in matviews.

Doc: improve documentation about ORDER BY in matviews. Remove the confusing use of ORDER BY in an example materialized view. It adds nothing to the example, but might encourage people to follow bad practice. Clarify REFRESH MATERIALIZED VIEW's note about whether view ordering is retained (it isn

pgsql: Doc: improve documentation about ORDER BY in matviews.

Doc: improve documentation about ORDER BY in matviews. Remove the confusing use of ORDER BY in an example materialized view. It adds nothing to the example, but might encourage people to follow bad practice. Clarify REFRESH MATERIALIZED VIEW's note about whether view ordering is retained (it isn

pgsql: Doc: improve documentation about ORDER BY in matviews.

Doc: improve documentation about ORDER BY in matviews. Remove the confusing use of ORDER BY in an example materialized view. It adds nothing to the example, but might encourage people to follow bad practice. Clarify REFRESH MATERIALIZED VIEW's note about whether view ordering is retained (it isn

pgsql: Doc: improve documentation about ORDER BY in matviews.

Doc: improve documentation about ORDER BY in matviews. Remove the confusing use of ORDER BY in an example materialized view. It adds nothing to the example, but might encourage people to follow bad practice. Clarify REFRESH MATERIALIZED VIEW's note about whether view ordering is retained (it isn

Re: pgsql: Update high level vacuumlazy.c comments.

On Mon, Nov 29, 2021 at 6:58 AM Robert Haas wrote: > I don't know whether this was discussed and you forgot to include a > Discussion link, or whether it wasn't discussed on list, but typically > both things should happen. This was a piece of the patch I posted here, which was discussed in genera

pgsql: Simplify declaring variables exported from libpgcommon and libpg

Simplify declaring variables exported from libpgcommon and libpgport. This reverts commits c2d1eea9e and 11b500072, as well as similar hacks elsewhere, in favor of setting up the PGDLLIMPORT macro so that it can just be used unconditionally. That can work because in frontend code, we need no mark

Re: pgsql: Update high level vacuumlazy.c comments.

On Sat, Nov 27, 2021 at 5:31 PM Peter Geoghegan wrote: > Update high level vacuumlazy.c comments. > > Update vacuumlazy.c file header comments (as well as comments above the > lazy_scan_heap function) that were largely written before the > introduction of the HOT optimization, when lazy_scan_heap