pgsql: doc: Fix description of pg_replication_origin_oid() in error cas

2022-01-18 Thread Michael Paquier
doc: Fix description of pg_replication_origin_oid() in error case This function returns NULL if the replication origin given in input argument does not exist, contrary to what the docs described previously. Author: Ian Barwick Discussion: https://postgr.es/m/CAB8KJ=htJjBL=103urqjoxv2mqb4rjphdpme

pgsql: doc: Fix description of pg_replication_origin_oid() in error cas

2022-01-18 Thread Michael Paquier
doc: Fix description of pg_replication_origin_oid() in error case This function returns NULL if the replication origin given in input argument does not exist, contrary to what the docs described previously. Author: Ian Barwick Discussion: https://postgr.es/m/CAB8KJ=htJjBL=103urqjoxv2mqb4rjphdpme

pgsql: doc: Fix description of pg_replication_origin_oid() in error cas

2022-01-18 Thread Michael Paquier
doc: Fix description of pg_replication_origin_oid() in error case This function returns NULL if the replication origin given in input argument does not exist, contrary to what the docs described previously. Author: Ian Barwick Discussion: https://postgr.es/m/CAB8KJ=htJjBL=103urqjoxv2mqb4rjphdpme

pgsql: doc: Fix description of pg_replication_origin_oid() in error cas

2022-01-18 Thread Michael Paquier
doc: Fix description of pg_replication_origin_oid() in error case This function returns NULL if the replication origin given in input argument does not exist, contrary to what the docs described previously. Author: Ian Barwick Discussion: https://postgr.es/m/CAB8KJ=htJjBL=103urqjoxv2mqb4rjphdpme

pgsql: doc: Fix description of pg_replication_origin_oid() in error cas

2022-01-18 Thread Michael Paquier
doc: Fix description of pg_replication_origin_oid() in error case This function returns NULL if the replication origin given in input argument does not exist, contrary to what the docs described previously. Author: Ian Barwick Discussion: https://postgr.es/m/CAB8KJ=htJjBL=103urqjoxv2mqb4rjphdpme

pgsql: doc: Fix description of pg_replication_origin_oid() in error cas

2022-01-18 Thread Michael Paquier
doc: Fix description of pg_replication_origin_oid() in error case This function returns NULL if the replication origin given in input argument does not exist, contrary to what the docs described previously. Author: Ian Barwick Discussion: https://postgr.es/m/CAB8KJ=htJjBL=103urqjoxv2mqb4rjphdpme

Re: pgsql: Test replay of regression tests, attempt II.

2022-01-18 Thread Andres Freund
Hi, On 2022-01-18 17:19:06 -0500, Tom Lane wrote: > Andres Freund writes: > > That's an extremely small shared_buffers for running the regression tests, > > it'd not > > be surprising if that provoked problems we don't otherwise see. Perhaps > > VACUUM > > ends up skipping over a page because o

Re: pgsql: Test replay of regression tests, attempt II.

2022-01-18 Thread Thomas Munro
On Wed, Jan 19, 2022 at 11:19 AM Tom Lane wrote: > Andres Freund writes: > > Also, it's odd that there's "max_connections 25" without an equal sign. I'd > > kind of expected that to cause an error > > I see that guc.c intentionally allows the equal sign to be optional. > Too lazy to check if

Re: pgsql: Test replay of regression tests, attempt II.

2022-01-18 Thread Tom Lane
Andres Freund writes: > That's an extremely small shared_buffers for running the regression tests, > it'd not > be surprising if that provoked problems we don't otherwise see. Perhaps VACUUM > ends up skipping over a page because of page contention? Hmm, good thought. I tried running the test w

Re: pgsql: Test replay of regression tests, attempt II.

2022-01-18 Thread Andres Freund
On 2022-01-18 15:15:44 -0500, Tom Lane wrote: > https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rorqual&dt=2022-01-18%2019%3A50%3A57 > > That reloptions test has been there awhile, and we weren't seeing > issues with it before. What about the replication environment > would cause VACUUM t

Re: pgsql: Test replay of regression tests, attempt II.

2022-01-18 Thread Tom Lane
Thomas Munro writes: > Alright, I've pushed a change like that. Let's see if that clears it > up. Nope: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=rorqual&dt=2022-01-18%2019%3A50%3A57 That reloptions test has been there awhile, and we weren't seeing issues with it before. What ab

pgsql: Make PQcancel use the PGconn's tcp_user_timeout and keepalives s

2022-01-18 Thread Tom Lane
Make PQcancel use the PGconn's tcp_user_timeout and keepalives settings. If connectivity to the server has been lost or become flaky, the user might well try to send a query cancel. It's highly annoying if PQcancel hangs up in such a case, but that's exactly what's likely to happen. To ameliorat

Re: pgsql: Test replay of regression tests, attempt II.

2022-01-18 Thread Thomas Munro
On Tue, Jan 18, 2022 at 11:08 AM Thomas Munro wrote: > commit fe246d1c111d43fd60a1b0afff25ed09b7ae11eb > Author: Michael Paquier > Date: Fri Apr 2 09:44:42 2021 +0900 > > Improve stability of test with vacuum_truncate in reloptions.sql > > Hmm... looking at that commit and the referenced di

pgsql: Modify pg_basebackup to use a new COPY subprotocol for base back

2022-01-18 Thread Robert Haas
Modify pg_basebackup to use a new COPY subprotocol for base backups. In the new approach, all files across all tablespaces are sent in a single COPY OUT operation. The CopyData messages are no longer raw archive content; rather, each message is prefixed with a type byte that describes its purpose,

pgsql: Try to stabilize the reloptions test.

2022-01-18 Thread Thomas Munro
Try to stabilize the reloptions test. Where we test vacuum_truncate's effects, sometimes this is failing to truncate as expected on the build farm. That could be explained by page skipping, so disable it explicitly, with the theory that commit fe246d1c didn't go far enough. Back-patch to 12, whe

pgsql: Try to stabilize the reloptions test.

2022-01-18 Thread Thomas Munro
Try to stabilize the reloptions test. Where we test vacuum_truncate's effects, sometimes this is failing to truncate as expected on the build farm. That could be explained by page skipping, so disable it explicitly, with the theory that commit fe246d1c didn't go far enough. Back-patch to 12, whe

pgsql: Try to stabilize the reloptions test.

2022-01-18 Thread Thomas Munro
Try to stabilize the reloptions test. Where we test vacuum_truncate's effects, sometimes this is failing to truncate as expected on the build farm. That could be explained by page skipping, so disable it explicitly, with the theory that commit fe246d1c didn't go far enough. Back-patch to 12, whe

pgsql: Try to stabilize the reloptions test.

2022-01-18 Thread Thomas Munro
Try to stabilize the reloptions test. Where we test vacuum_truncate's effects, sometimes this is failing to truncate as expected on the build farm. That could be explained by page skipping, so disable it explicitly, with the theory that commit fe246d1c didn't go far enough. Back-patch to 12, whe

pgsql: Revert "Replace use of deprecated Python module distutils.syscon

2022-01-18 Thread Peter Eisentraut
Revert "Replace use of deprecated Python module distutils.sysconfig" This reverts commit e0e567a106726f6709601ee7cffe73eb6da8084e. On various platforms, the new approach using the sysconfig module reported incorrect values for the include directory, and so any Python-related compilations failed.

pgsql: Fix thinko in psql test

2022-01-18 Thread Peter Eisentraut
Fix thinko in psql test The tests added by 14d755b00037ce04b9e24504f4b540d9e731c29e added a test case for psql's \set ECHO errors. After the test, it then reset this to \set ECHO none, which is the default. But the regression tests are actually run under \set ECHO all (psql -a), so that would ha