pgsql: Temporarily add some information about python include paths to c

2022-01-23 Thread Andres Freund
Temporarily add some information about python include paths to configure. We're still (see e0e567a1067, e0e567a1067) working on replacing use of the deprecated distutils. This commit just makes configure print out the results of different ways of determining the include path. Hopefully this will h

pgsql: pg_basebackup: Skip a few more fsyncs if --no-sync is specified.

2022-01-23 Thread Andres Freund
pg_basebackup: Skip a few more fsyncs if --no-sync is specified. This is mostly interesting for running the regression tests on machines with slow / overloaded IO. Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git

pgsql: pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_

2022-01-23 Thread Tom Lane
pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid Commit 6df7a9698 wrote appendPQExpBuffer where it should have written printfPQExpBuffer. This resulted in re-issuing the previous query along with the desired one, which very accidentally had no negative consequences except

pgsql: pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_

2022-01-23 Thread Tom Lane
pg_dump: avoid useless query in binary_upgrade_set_type_oids_by_type_oid Commit 6df7a9698 wrote appendPQExpBuffer where it should have written printfPQExpBuffer. This resulted in re-issuing the previous query along with the desired one, which very accidentally had no negative consequences except

pgsql: Clean up recent Coverity complaints.

2022-01-23 Thread Tom Lane
Clean up recent Coverity complaints. Commit 5c649fe15 introduced a memory leak into pg_basebackup's parse_compress_options. (I simplified nearby code while at it.) Commit 9a974cbcb introduced a memory leak into pg_dump's binary_upgrade_set_pg_class_oids. Coverity also complained about a call of

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void

pgsql: Suppress variable-set-but-not-used warning from clang 13.

2022-01-23 Thread Tom Lane
Suppress variable-set-but-not-used warning from clang 13. In the normal configuration where GEQO_DEBUG isn't defined, recent clang versions have started to complain that geqo_main.c accumulates the edge_failures count but never does anything with it. As a minimal back-patchable fix, insert a void