Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
Hi, On 2022-01-30 21:01:07 -0500, Tom Lane wrote: > Andres Freund writes: > > On 2022-01-30 17:35:48 -0800, Andres Freund wrote: > >> I see this broke on everywhere but master. Looking. > > > Ugh. It's that we didn't backport pport.h. > > Ooops. I've pushed the quick fix of just using PERL_VER

pgsql: plperl: Fix breakage of c89f409749c in back branches.

2022-01-30 Thread Andres Freund
plperl: Fix breakage of c89f409749c in back branches. ppport.h was only updated in 05798c9f7f0 (master). Unfortunately my commit c89f409749c uses PERL_VERSION_LT which came in with that update. Breaking most buildfarm animals. I should have noticed that... We might want to backpatch the ppport u

pgsql: plperl: Fix breakage of c89f409749c in back branches.

2022-01-30 Thread Andres Freund
plperl: Fix breakage of c89f409749c in back branches. ppport.h was only updated in 05798c9f7f0 (master). Unfortunately my commit c89f409749c uses PERL_VERSION_LT which came in with that update. Breaking most buildfarm animals. I should have noticed that... We might want to backpatch the ppport u

pgsql: plperl: Fix breakage of c89f409749c in back branches.

2022-01-30 Thread Andres Freund
plperl: Fix breakage of c89f409749c in back branches. ppport.h was only updated in 05798c9f7f0 (master). Unfortunately my commit c89f409749c uses PERL_VERSION_LT which came in with that update. Breaking most buildfarm animals. I should have noticed that... We might want to backpatch the ppport u

pgsql: plperl: Fix breakage of c89f409749c in back branches.

2022-01-30 Thread Andres Freund
plperl: Fix breakage of c89f409749c in back branches. ppport.h was only updated in 05798c9f7f0 (master). Unfortunately my commit c89f409749c uses PERL_VERSION_LT which came in with that update. Breaking most buildfarm animals. I should have noticed that... We might want to backpatch the ppport u

pgsql: plperl: Fix breakage of c89f409749c in back branches.

2022-01-30 Thread Andres Freund
plperl: Fix breakage of c89f409749c in back branches. ppport.h was only updated in 05798c9f7f0 (master). Unfortunately my commit c89f409749c uses PERL_VERSION_LT which came in with that update. Breaking most buildfarm animals. I should have noticed that... We might want to backpatch the ppport u

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Tom Lane
Andres Freund writes: > On 2022-01-30 17:35:48 -0800, Andres Freund wrote: >> I see this broke on everywhere but master. Looking. > Ugh. It's that we didn't backport pport.h. Ooops. > Unless somebody comes up with a better idea quickly I'm going use a plain > PERL_VERSION check in the backbranc

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
Hi, On 2022-01-30 17:35:48 -0800, Andres Freund wrote: > I see this broke on everywhere but master. Looking. Ugh. It's that we didn't backport pport.h. commit 05798c9f7f08908bdd06c82d934da67535b72005 Author: Tom Lane Date: 2021-10-07 13:59:43 -0400 plperl: update ppport.h to Perl 5.34.0.

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
Hi, On 2022-01-31 00:44:39 +, Andres Freund wrote: > plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. > > For older versions we need our own copy of perl's setlocale(), because it was > not exposed (why we need the setlocale in the first place is explained in > plperl_ini

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-30 Thread Andres Freund
plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. For older versions we need our own copy of perl's setlocale(), because it was not exposed (why we need the setlocale in the first place is explained in plperl_init_interp) . The copy stopped working in 5.28, as some of the used

pgsql: Introduce pg_settings_get_flags() to find flags associated to a

2022-01-30 Thread Michael Paquier
Introduce pg_settings_get_flags() to find flags associated to a GUC The most meaningful flags are shown, which are the ones useful for the user and for automating and extending the set of tests supported currently by check_guc. This script may actually be removed in the future, but we are not com

pgsql: psql: improve tab-complete's handling of variant SQL names.

2022-01-30 Thread Tom Lane
psql: improve tab-complete's handling of variant SQL names. This patch improves tab completion's ability to deal with valid variant spellings of SQL identifiers. Notably: * Unquoted upper-case identifiers are now downcased as the backend would do, allowing them to be completed correctly. * Tab

pgsql: Remove xloginsert.h from xlog.h

2022-01-30 Thread Alvaro Herrera
Remove xloginsert.h from xlog.h xlog.h is directly and indirectly #included in a lot of places. With this change, xloginsert.h is no longer unnecessarily included in the large number of them that don't need it. Author: Bharath Rupireddy Discussion: https://postgr.es/m/CALj2ACVe-W+WM5P44N7eG9C2