Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-31 Thread Andres Freund
On 2022-01-31 15:08:30 -0500, Tom Lane wrote: > Done now. Thanks!

pgsql: Fix missing undefine in sort_template.h

2022-01-31 Thread John Naylor
Fix missing undefine in sort_template.h All parameter macros are supposed to be undefined at the end of the header. ST_CHECK_FOR_INTERRUPTS was forgotten, so could affect later inclusions. Thomas Munro The patch set of which this is a part is discussed in https://www.postgresql.org/message-id/CA

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-31 Thread Tom Lane
Andres Freund writes: > On 2022-01-30 21:01:07 -0500, Tom Lane wrote: >> I think we oughta backport. We didn't do so at the time because >> we thought it was mostly cosmetic/future-proofing, but evidently >> the future is now. >> I can look into that tomorrow or so. > Cool. I can either do a rev

pgsql: Revert "plperl: Fix breakage of c89f409749c in back branches."

2022-01-31 Thread Tom Lane
Revert "plperl: Fix breakage of c89f409749c in back branches." This reverts commits d81cac47a et al. We shouldn't need that hack after the preceding commits. Discussion: https://postgr.es/m/[email protected] Branch -- REL_11_STABLE Details --- https://g

pgsql: plperl: update ppport.h to Perl 5.34.0.

2022-01-31 Thread Tom Lane
plperl: update ppport.h to Perl 5.34.0. Also apply the changes suggested by running perl ppport.h --compat-version=5.8.0 And remove some no-longer-required NEED_foo declarations. Dagfinn Ilmari Mannsåker Back-patch of commit 05798c9f7 into all supported branches. At the time we thought this upd

pgsql: plperl: update ppport.h to Perl 5.34.0.

2022-01-31 Thread Tom Lane
plperl: update ppport.h to Perl 5.34.0. Also apply the changes suggested by running perl ppport.h --compat-version=5.8.0 And remove some no-longer-required NEED_foo declarations. Dagfinn Ilmari Mannsåker Back-patch of commit 05798c9f7 into all supported branches. At the time we thought this upd

pgsql: Revert "plperl: Fix breakage of c89f409749c in back branches."

2022-01-31 Thread Tom Lane
Revert "plperl: Fix breakage of c89f409749c in back branches." This reverts commits d81cac47a et al. We shouldn't need that hack after the preceding commits. Discussion: https://postgr.es/m/[email protected] Branch -- REL_13_STABLE Details --- https://g

pgsql: plperl: update ppport.h to Perl 5.34.0.

2022-01-31 Thread Tom Lane
plperl: update ppport.h to Perl 5.34.0. Also apply the changes suggested by running perl ppport.h --compat-version=5.8.0 And remove some no-longer-required NEED_foo declarations. Dagfinn Ilmari Mannsåker Back-patch of commit 05798c9f7 into all supported branches. At the time we thought this upd

pgsql: Revert "plperl: Fix breakage of c89f409749c in back branches."

2022-01-31 Thread Tom Lane
Revert "plperl: Fix breakage of c89f409749c in back branches." This reverts commits d81cac47a et al. We shouldn't need that hack after the preceding commits. Discussion: https://postgr.es/m/[email protected] Branch -- REL_14_STABLE Details --- https://g

pgsql: Revert "plperl: Fix breakage of c89f409749c in back branches."

2022-01-31 Thread Tom Lane
Revert "plperl: Fix breakage of c89f409749c in back branches." This reverts commits d81cac47a et al. We shouldn't need that hack after the preceding commits. Discussion: https://postgr.es/m/[email protected] Branch -- REL_12_STABLE Details --- https://g

pgsql: plperl: update ppport.h to Perl 5.34.0.

2022-01-31 Thread Tom Lane
plperl: update ppport.h to Perl 5.34.0. Also apply the changes suggested by running perl ppport.h --compat-version=5.8.0 And remove some no-longer-required NEED_foo declarations. Dagfinn Ilmari Mannsåker Back-patch of commit 05798c9f7 into all supported branches. At the time we thought this upd

pgsql: Revert "plperl: Fix breakage of c89f409749c in back branches."

2022-01-31 Thread Tom Lane
Revert "plperl: Fix breakage of c89f409749c in back branches." This reverts commits d81cac47a et al. We shouldn't need that hack after the preceding commits. Discussion: https://postgr.es/m/[email protected] Branch -- REL_10_STABLE Details --- https://g

pgsql: plperl: update ppport.h to Perl 5.34.0.

2022-01-31 Thread Tom Lane
plperl: update ppport.h to Perl 5.34.0. Also apply the changes suggested by running perl ppport.h --compat-version=5.8.0 And remove some no-longer-required NEED_foo declarations. Dagfinn Ilmari Mannsåker Back-patch of commit 05798c9f7 into all supported branches. At the time we thought this upd

pgsql: Simplify coding around path_contains_parent_reference().

2022-01-31 Thread Tom Lane
Simplify coding around path_contains_parent_reference(). Given the existing stipulation that path_contains_parent_reference() must only be invoked on canonicalized paths, we can simplify things in the wake of commit c10f830c5. It is now only possible to see ".." at the start of a relative path.

pgsql: Make canonicalize_path() more canonical.

2022-01-31 Thread Tom Lane
Make canonicalize_path() more canonical. Teach canonicalize_path() how to strip all unnecessary uses of "." and "..", replacing the previous ad-hoc code that got rid of only some such cases. In particular, we can always remove all such uses from absolute paths. The proximate reason to do this is

Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai

2022-01-31 Thread Kyotaro Horiguchi
At Sun, 30 Jan 2022 17:35:48 -0800, Andres Freund wrote in > Hi, > > On 2022-01-31 00:44:39 +, Andres Freund wrote: > > plperl: windows: Use Perl_setlocale on 5.28+, fixing compile failure. > > > > For older versions we need our own copy of perl's setlocale(), because it > > was > > not ex