pgsql: Further fix for EvalPlanQual with mix of local and foreign parti

2022-02-02 Thread Etsuro Fujita
Further fix for EvalPlanQual with mix of local and foreign partitions. We assume that direct-modify ForeignScan nodes cannot be re-evaluated during EvalPlanQual processing, but the rework for inherited UPDATE/DELETE in commit 86dc90056 changed things, without considering that, so that such Foreign

pgsql: Further fix for EvalPlanQual with mix of local and foreign parti

2022-02-02 Thread Etsuro Fujita
Further fix for EvalPlanQual with mix of local and foreign partitions. We assume that direct-modify ForeignScan nodes cannot be re-evaluated during EvalPlanQual processing, but the rework for inherited UPDATE/DELETE in commit 86dc90056 changed things, without considering that, so that such Foreign

pgsql: Remove configure's check for rl_completion_append_character.

2022-02-02 Thread Tom Lane
Remove configure's check for rl_completion_append_character. The comment for PGAC_READLINE_VARIABLES says "Readline versions < 2.1 don't have rl_completion_append_character". It seems certain that such versions are extinct in the wild, though; for sure there are none in the buildfarm. Libedit ha

pgsql: doc: clarify syntax notation, particularly parentheses

2022-02-02 Thread Bruce Momjian
doc: clarify syntax notation, particularly parentheses Also move TCL syntax to the PL/tcl section. Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_12_STABLE Details ---

pgsql: doc: clarify syntax notation, particularly parentheses

2022-02-02 Thread Bruce Momjian
doc: clarify syntax notation, particularly parentheses Also move TCL syntax to the PL/tcl section. Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_10_STABLE Details ---

pgsql: doc: clarify syntax notation, particularly parentheses

2022-02-02 Thread Bruce Momjian
doc: clarify syntax notation, particularly parentheses Also move TCL syntax to the PL/tcl section. Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_13_STABLE Details ---

pgsql: doc: clarify syntax notation, particularly parentheses

2022-02-02 Thread Bruce Momjian
doc: clarify syntax notation, particularly parentheses Also move TCL syntax to the PL/tcl section. Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- master Details --- https:/

pgsql: doc: clarify syntax notation, particularly parentheses

2022-02-02 Thread Bruce Momjian
doc: clarify syntax notation, particularly parentheses Also move TCL syntax to the PL/tcl section. Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_14_STABLE Details ---

pgsql: doc: clarify syntax notation, particularly parentheses

2022-02-02 Thread Bruce Momjian
doc: clarify syntax notation, particularly parentheses Also move TCL syntax to the PL/tcl section. Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_11_STABLE Details ---

pgsql: windows: Improve crash / assert / exception handling.

2022-02-02 Thread Andres Freund
windows: Improve crash / assert / exception handling. startup_hacks() called SetErrorMode() with the SEM_NOGPFAULTERRORBOX argument to prevent GUI popups on error. While that likely was sufficient at some point, there are other sources of error popups. At the same time SEM_NOGPFAULTERRORBOX unfor

pgsql: ci: windows: run tests under timeout.

2022-02-02 Thread Andres Freund
ci: windows: run tests under timeout. On windows ci/cfbot currently regularly hangs / times out. Presumably this is due to the issues discussed in https://postgr.es/m/CA%2BhUKG%2BG5DUNJfdE-qusq5pcj6omYTuWmmFuxCvs%3Dq1jNjkKKA%40mail.gmail.com which lead to reverting 75674c7ec1b everywhere but mast

pgsql: Improve psql tab-completion tests.

2022-02-02 Thread Tom Lane
Improve psql tab-completion tests. Fix up recently-added test cases in 010_tab_completion.pl so that they pass with the rather seriously broken libedit found in Debian 10 (Buster). Also, add a few more test cases to improve code coverage. The total line coverage still looks pretty awful, because

pgsql: Fix server crash bug in 'server' backup target.

2022-02-02 Thread Robert Haas
Fix server crash bug in 'server' backup target. When this code executed as superuser it appeared to work because no system catalog lookups happened, but otherwise it crashes because there is no transaction environment. Fix that. Report and code change by me. Test case by Dagfinn Ilmari Mannsåker.

pgsql: Some cleanup for change of collate and ctype fields to type text

2022-02-02 Thread Peter Eisentraut
Some cleanup for change of collate and ctype fields to type text Some cleanup for commit 54637508f87bd5f07fb9406bac6b08240283be3b: Reformat pg_database.dat to reflect the new field order. Also update the corresponding example in bki.sgml. Reorder the way the fields are filled in dbcommands.c to

pgsql: doc: Fix mistake in PL/Python documentation

2022-02-02 Thread Peter Eisentraut
doc: Fix mistake in PL/Python documentation Small thinko introduced by 94aceed317730953476bec490ce0148b2af3c383 Reported-by: [email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/cb2bab14fff5b4e1c065b8546323f1a9fefc9611 Modified Files -- do

pgsql: doc: Fix mistake in PL/Python documentation

2022-02-02 Thread Peter Eisentraut
doc: Fix mistake in PL/Python documentation Small thinko introduced by 94aceed317730953476bec490ce0148b2af3c383 Reported-by: [email protected] Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/31c9712610c7eec1b2f376fd3bbf5839e4234d64 Modified Files --

pgsql: doc: Fix mistake in PL/Python documentation

2022-02-02 Thread Peter Eisentraut
doc: Fix mistake in PL/Python documentation Small thinko introduced by 94aceed317730953476bec490ce0148b2af3c383 Reported-by: [email protected] Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/0b25f5e444ff471135bcf58cbb1e4cbda165efa5 Modified Files --

pgsql: doc: Fix mistake in PL/Python documentation

2022-02-02 Thread Peter Eisentraut
doc: Fix mistake in PL/Python documentation Small thinko introduced by 94aceed317730953476bec490ce0148b2af3c383 Reported-by: [email protected] Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f4f97e95043ffeae152324842443b29996c004cd Modified Files --

pgsql: doc: Fix mistake in PL/Python documentation

2022-02-02 Thread Peter Eisentraut
doc: Fix mistake in PL/Python documentation Small thinko introduced by 94aceed317730953476bec490ce0148b2af3c383 Reported-by: [email protected] Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/ee57467cb6b2ce1e25d367cbd64cc60ae9ba0eb3 Modified Files --

pgsql: doc: Fix mistake in PL/Python documentation

2022-02-02 Thread Peter Eisentraut
doc: Fix mistake in PL/Python documentation Small thinko introduced by 94aceed317730953476bec490ce0148b2af3c383 Reported-by: [email protected] Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/7792c0c61787fa7341d0f004f062f27ab93d455a Modified Files --