pgsql: Add min() and max() aggregates for xid8.

2022-02-09 Thread Fujii Masao
Add min() and max() aggregates for xid8. Bump catalog version. Author: Ken Kato Reviewed-by: Kyotaro Horiguchi, Fujii Masao Discussion: https://postgr.es/m/47d77b18c44f87f8222c4c7a3e2de...@oss.nttdata.com Branch -- master Details ---

Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f

2022-02-09 Thread Tom Lane
Noah Misch writes: > On Wed, Feb 09, 2022 at 09:41:09PM -0500, Tom Lane wrote: >> Ouch! Do you have any idea why? > I do not. OK, I'll look into it tomorrow. regards, tom lane

Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f

2022-02-09 Thread Noah Misch
On Wed, Feb 09, 2022 at 09:41:09PM -0500, Tom Lane wrote: > Noah Misch writes: > > On AIX, this pair of commits added 5-10h of runtime to 017_shm.pl. > > Ouch! Do you have any idea why? I do not.

Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f

2022-02-09 Thread Tom Lane
Noah Misch writes: > On AIX, this pair of commits added 5-10h of runtime to 017_shm.pl. Ouch! Do you have any idea why? regards, tom lane

Re: pgsql: TAP tests: check for postmaster.pid anyway when "pg_ctl start" f

2022-02-09 Thread Noah Misch
On Thu, Jan 20, 2022 at 05:30:44PM -0500, Tom Lane wrote: > I wrote: > > What I'm thinking of doing is inventing a "soft_stop" variant of > > Cluster::stop that won't complain if pg_ctl stop fails, and then > > having 017_shm's poll_start() call that before retrying the start > > call. > > I did

pgsql: Use Test::Builder::todo_start(), replacing $::TODO.

2022-02-09 Thread Noah Misch
Use Test::Builder::todo_start(), replacing $::TODO. Some pre-2017 Test::More versions need perfect $Test::Builder::Level maintenance to find the variable. Buildfarm member snapper reported an overall failure that the file intended to hide via the TODO construct. That trouble was reachable in v11

pgsql: Fix back-patch of "Avoid race in RelationBuildDesc() ..."

2022-02-09 Thread Noah Misch
Fix back-patch of "Avoid race in RelationBuildDesc() ..." The back-patch of commit fdd965d074d46765c295223b119ca437dbcac973 broke CLOBBER_CACHE_ALWAYS for v9.6 through v13. It updated the InvalidateSystemCaches() call for CLOBBER_CACHE_RECURSIVELY, neglecting the one for CLOBBER_CACHE_ALWAYS.

pgsql: Use Test::Builder::todo_start(), replacing $::TODO.

2022-02-09 Thread Noah Misch
Use Test::Builder::todo_start(), replacing $::TODO. Some pre-2017 Test::More versions need perfect $Test::Builder::Level maintenance to find the variable. Buildfarm member snapper reported an overall failure that the file intended to hide via the TODO construct. That trouble was reachable in v11

pgsql: Fix back-patch of "Avoid race in RelationBuildDesc() ..."

2022-02-09 Thread Noah Misch
Fix back-patch of "Avoid race in RelationBuildDesc() ..." The back-patch of commit fdd965d074d46765c295223b119ca437dbcac973 broke CLOBBER_CACHE_ALWAYS for v9.6 through v13. It updated the InvalidateSystemCaches() call for CLOBBER_CACHE_RECURSIVELY, neglecting the one for CLOBBER_CACHE_ALWAYS.

pgsql: Use Test::Builder::todo_start(), replacing $::TODO.

2022-02-09 Thread Noah Misch
Use Test::Builder::todo_start(), replacing $::TODO. Some pre-2017 Test::More versions need perfect $Test::Builder::Level maintenance to find the variable. Buildfarm member snapper reported an overall failure that the file intended to hide via the TODO construct. That trouble was reachable in v11

pgsql: Fix back-patch of "Avoid race in RelationBuildDesc() ..."

2022-02-09 Thread Noah Misch
Fix back-patch of "Avoid race in RelationBuildDesc() ..." The back-patch of commit fdd965d074d46765c295223b119ca437dbcac973 broke CLOBBER_CACHE_ALWAYS for v9.6 through v13. It updated the InvalidateSystemCaches() call for CLOBBER_CACHE_RECURSIVELY, neglecting the one for CLOBBER_CACHE_ALWAYS.

pgsql: Fix back-patch of "Avoid race in RelationBuildDesc() ..."

2022-02-09 Thread Noah Misch
Fix back-patch of "Avoid race in RelationBuildDesc() ..." The back-patch of commit fdd965d074d46765c295223b119ca437dbcac973 broke CLOBBER_CACHE_ALWAYS for v9.6 through v13. It updated the InvalidateSystemCaches() call for CLOBBER_CACHE_RECURSIVELY, neglecting the one for CLOBBER_CACHE_ALWAYS.

pgsql: Use Test::Builder::todo_start(), replacing $::TODO.

2022-02-09 Thread Noah Misch
Use Test::Builder::todo_start(), replacing $::TODO. Some pre-2017 Test::More versions need perfect $Test::Builder::Level maintenance to find the variable. Buildfarm member snapper reported an overall failure that the file intended to hide via the TODO construct. That trouble was reachable in v11

pgsql: Use Test::Builder::todo_start(), replacing $::TODO.

2022-02-09 Thread Noah Misch
Use Test::Builder::todo_start(), replacing $::TODO. Some pre-2017 Test::More versions need perfect $Test::Builder::Level maintenance to find the variable. Buildfarm member snapper reported an overall failure that the file intended to hide via the TODO construct. That trouble was reachable in v11

pgsql: Use Test::Builder::todo_start(), replacing $::TODO.

2022-02-09 Thread Noah Misch
Use Test::Builder::todo_start(), replacing $::TODO. Some pre-2017 Test::More versions need perfect $Test::Builder::Level maintenance to find the variable. Buildfarm member snapper reported an overall failure that the file intended to hide via the TODO construct. That trouble was reachable in v11

pgsql: Fix typo in multixact.c

2022-02-09 Thread Michael Paquier
Fix typo in multixact.c Introduced in aa64f23. Author: Nathan Bossart Discussion: https://postgr.es/m/20220209175338.GB1627503@nathanxps13 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0147fc7c8c92ee22910f40b1740425f43382bc95 Modified Files --

pgsql: Reduce more the number of calls to GetMaxBackends()

2022-02-09 Thread Michael Paquier
Reduce more the number of calls to GetMaxBackends() Some of the code paths changed by aa64f23 can reduce the number of times GetMaxBackends() is called. The performance gain is marginal, but most of the code changed by this commit already did that. Hence, let's be clean and apply the same rule

pgsql: Further tweaks for psql's new tab-completion logic.

2022-02-09 Thread Tom Lane
Further tweaks for psql's new tab-completion logic. The behavior I proposed, of matching case only when only keywords are available to complete, turns out to be too cute. It adds about as many problems as it removes. Simplify down to ilmari's original proposal of just always matching case when

pgsql: Test honestly for .

2022-02-09 Thread Tom Lane
Test honestly for . Commit 6a2a70a02 supposed that any platform having would also have . It turns out there are still a few people using platforms where that's not so, so we'd better make a separate configure probe for it. But since it took this long to notice, I'm content with the decision to

pgsql: Test honestly for .

2022-02-09 Thread Tom Lane
Test honestly for . Commit 6a2a70a02 supposed that any platform having would also have . It turns out there are still a few people using platforms where that's not so, so we'd better make a separate configure probe for it. But since it took this long to notice, I'm content with the decision to

pgsql: Tag refs/tags/REL_10_20 was created

2022-02-09 Thread noreply
Tag refs/tags/REL_10_20 was created.

pgsql: Tag refs/tags/REL_11_15 was created

2022-02-09 Thread noreply
Tag refs/tags/REL_11_15 was created.

pgsql: Tag refs/tags/REL_13_6 was created

2022-02-09 Thread noreply
Tag refs/tags/REL_13_6 was created.

pgsql: Tag refs/tags/REL_12_10 was created

2022-02-09 Thread noreply
Tag refs/tags/REL_12_10 was created.

pgsql: Fix typo in archive modules docs

2022-02-09 Thread Daniel Gustafsson
Fix typo in archive modules docs Discussion: https://postgr.es/m/4f8e8d8f-45ca-4833-ab19-cc6105326...@yesql.se Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/f48385c1327f1eaef134ad41b382041a79c5200a Modified Files -- doc/src/sgml/archive-modules.sgml

pgsql: Free temporary memory when reading TOC

2022-02-09 Thread Daniel Gustafsson
Free temporary memory when reading TOC ReadStr returns allocated memory which the caller is responsible for freeing when done with the string. This commit ensures that memory is freed in one case which used ReadStr in a conditional. While the leak might not be too concerning, this makes the code