pgsql: Try to stabilize vacuum test.

2022-03-22 Thread Thomas Munro
Try to stabilize vacuum test. As commits b700f96c and 3414099c did for the reloptions test, make sure VACUUM can always truncate the table as expected. Back-patch to 12, where vacuum_truncate arrived. Discussion: https://postgr.es/m/CAD21AoCNoWjYkdEtr%2BVDoF9v__V905AedKZ9iF%3DArgCtrbxZqw%40mail

pgsql: Try to stabilize vacuum test.

2022-03-22 Thread Thomas Munro
Try to stabilize vacuum test. As commits b700f96c and 3414099c did for the reloptions test, make sure VACUUM can always truncate the table as expected. Back-patch to 12, where vacuum_truncate arrived. Discussion: https://postgr.es/m/CAD21AoCNoWjYkdEtr%2BVDoF9v__V905AedKZ9iF%3DArgCtrbxZqw%40mail

pgsql: Try to stabilize vacuum test.

2022-03-22 Thread Thomas Munro
Try to stabilize vacuum test. As commits b700f96c and 3414099c did for the reloptions test, make sure VACUUM can always truncate the table as expected. Back-patch to 12, where vacuum_truncate arrived. Discussion: https://postgr.es/m/CAD21AoCNoWjYkdEtr%2BVDoF9v__V905AedKZ9iF%3DArgCtrbxZqw%40mail

pgsql: Try to stabilize vacuum test.

2022-03-22 Thread Thomas Munro
Try to stabilize vacuum test. As commits b700f96c and 3414099c did for the reloptions test, make sure VACUUM can always truncate the table as expected. Back-patch to 12, where vacuum_truncate arrived. Discussion: https://postgr.es/m/CAD21AoCNoWjYkdEtr%2BVDoF9v__V905AedKZ9iF%3DArgCtrbxZqw%40mail

Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.

2022-03-22 Thread Amit Kapila
On Wed, Mar 23, 2022 at 5:29 AM Andres Freund wrote: > > Hi, > > On 2022-03-22 01:56:03 +, Amit Kapila wrote: > > Add ALTER SUBSCRIPTION ... SKIP. > > > > This feature allows skipping the transaction on subscriber nodes. > > > > If incoming change violates any constraint, logical replication s

pgsql: Temporarily disable installcheck for test_oat_hooks module

2022-03-22 Thread Andrew Dunstan
Temporarily disable installcheck for test_oat_hooks module Buildfarm members are encountering errors when the test is run under various locales/encodings. As the buildfarm only does this for installchecks, disable them for now. Discussion: https://postgr.es/m/6067945b-960a-ab04-d40f-06b006a1d...

Re: pgsql: Common SQL/JSON clauses

2022-03-22 Thread Tom Lane
Andrew Dunstan writes: > On 3/22/22 18:33, Andres Freund wrote: >> This currently triggers a number of warnings. I assume that's because of the >> following patches not being there yet? How far out are those? > Tomorrow, with the SQL/JSON constructors patch should resolve it. So > roughly 24 hour

Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.

2022-03-22 Thread Andres Freund
Hi, On 2022-03-22 01:56:03 +, Amit Kapila wrote: > Add ALTER SUBSCRIPTION ... SKIP. > > This feature allows skipping the transaction on subscriber nodes. > > If incoming change violates any constraint, logical replication stops > until it's resolved. Currently, users need to either manually

pgsql: Revert "Common SQL/JSON clauses"

2022-03-22 Thread Andrew Dunstan
Revert "Common SQL/JSON clauses" This reverts commit 865fe4d5df560a6f5353da652018ff876978ad2d. This has caused issues with a significant number of buildfarm members Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1460fc5942591fdb6bee0bc8342019ede31ff3b6 Modified F

pgsql: Add missing xlogdefs.h include to pg_subscription.h.

2022-03-22 Thread Andres Freund
Add missing xlogdefs.h include to pg_subscription.h. Missed in 208c5d65bbd. The missing include causes headerscheck to fail. Per buildfarm member crake. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3707e437c73920492cab0dd17432be6e89bafd76 Modified Files ---

Re: pgsql: Common SQL/JSON clauses

2022-03-22 Thread Andrew Dunstan
On 3/22/22 18:33, Andres Freund wrote: > Hi, > > On 2022-03-22 21:34:25 +, Andrew Dunstan wrote: >> Common SQL/JSON clauses >> >> This introduces some of the building blocks used by the SQL/JSON >> constructor and query functions. Specifically, it provides node >> executor and grammar support

Re: pgsql: Common SQL/JSON clauses

2022-03-22 Thread Andres Freund
Hi, On 2022-03-22 21:34:25 +, Andrew Dunstan wrote: > Common SQL/JSON clauses > > This introduces some of the building blocks used by the SQL/JSON > constructor and query functions. Specifically, it provides node > executor and grammar support for the FORMAT JSON [ENCODING foo] > clause, and

pgsql: Common SQL/JSON clauses

2022-03-22 Thread Andrew Dunstan
Common SQL/JSON clauses This introduces some of the building blocks used by the SQL/JSON constructor and query functions. Specifically, it provides node executor and grammar support for the FORMAT JSON [ENCODING foo] clause, and values decorated with it, and for the RETURNING clause. The followin

pgsql: Tidy up Object Access hooks tests

2022-03-22 Thread Andrew Dunstan
Tidy up Object Access hooks tests per gripelet from Tom Lane. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a3b071bbe050252b35c589a7f1a2ee2f7ee3e9d4 Modified Files -- src/test/modules/test_oat_hooks/Makefile| 5 + src/test/modul

pgsql: Fix new Object Access hooks test

2022-03-22 Thread Andrew Dunstan
Fix new Object Access hooks test Commit 90efa2f556 caused some issues with EXEC_BACKEND builds and with force_parallel_mode = regress setups. For the first issue we no longer test if the module has been preloaded, and in fact we don't preload it, but simply LOAD it in the test script. For the seco

pgsql: Add missing dependency of pg_dumpall to WIN32RES.

2022-03-22 Thread Andres Freund
Add missing dependency of pg_dumpall to WIN32RES. When cross-building to windows, or building with mingw on windows, the build could fail with x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director because pg_dumpall didn't depend on WIN32RES, but it's recipe references it. The buil

pgsql: Add missing dependency of pg_dumpall to WIN32RES.

2022-03-22 Thread Andres Freund
Add missing dependency of pg_dumpall to WIN32RES. When cross-building to windows, or building with mingw on windows, the build could fail with x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director because pg_dumpall didn't depend on WIN32RES, but it's recipe references it. The buil

pgsql: Add missing dependency of pg_dumpall to WIN32RES.

2022-03-22 Thread Andres Freund
Add missing dependency of pg_dumpall to WIN32RES. When cross-building to windows, or building with mingw on windows, the build could fail with x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director because pg_dumpall didn't depend on WIN32RES, but it's recipe references it. The buil

pgsql: Add missing dependency of pg_dumpall to WIN32RES.

2022-03-22 Thread Andres Freund
Add missing dependency of pg_dumpall to WIN32RES. When cross-building to windows, or building with mingw on windows, the build could fail with x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director because pg_dumpall didn't depend on WIN32RES, but it's recipe references it. The buil

pgsql: Add missing dependency of pg_dumpall to WIN32RES.

2022-03-22 Thread Andres Freund
Add missing dependency of pg_dumpall to WIN32RES. When cross-building to windows, or building with mingw on windows, the build could fail with x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director because pg_dumpall didn't depend on WIN32RES, but it's recipe references it. The buil

pgsql: Add missing dependency of pg_dumpall to WIN32RES.

2022-03-22 Thread Andres Freund
Add missing dependency of pg_dumpall to WIN32RES. When cross-building to windows, or building with mingw on windows, the build could fail with x86_64-w64-mingw32-gcc: error: win32ver.o: No such file or director because pg_dumpall didn't depend on WIN32RES, but it's recipe references it. The buil

pgsql: pgstat: fix function name in comment.

2022-03-22 Thread Andres Freund
pgstat: fix function name in comment. Introduced in 3fa17d37716. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ce8c978295a55912dc81f9fbcd4f9f6d35379224 Modified Files -- src/backend/postmaster/pgstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

pgsql: Add a test module for Object Access hooks

2022-03-22 Thread Andrew Dunstan
Add a test module for Object Access hooks This includes tests of both the newly added name type object access hooks and the older Oid type hooks, and provides a useful example of how to use the hooks. Mark Dilger, based on some code from Joshua Brindle. Discussion: https://postgr.es/m/47f87a0e-

pgsql: Add String object access hooks

2022-03-22 Thread Andrew Dunstan
Add String object access hooks This caters for cases where the access is to an object identified by name rather than Oid. The first user of these is the GUC access controls Joshua Brindle and Mark Dilger Discussion: https://postgr.es/m/47f87a0e-c0e5-43a6-89f6-d403f2b45...@enterprisedb.com Bra

pgsql: Revert "graceful shutdown" changes for Windows.

2022-03-22 Thread Tom Lane
Revert "graceful shutdown" changes for Windows. This reverts commits 6051857fc and ed52c3707 in HEAD (they were already reverted in the back branches). Further testing has shown that while those changes do fix some things, they also break others; in particular, it looks like walreceivers fail to

pgsql: Add support for security invoker views.

2022-03-22 Thread Dean Rasheed
Add support for security invoker views. A security invoker view checks permissions for accessing its underlying base relations using the privileges of the user of the view, rather than the privileges of the view owner. Additionally, if any of the base relations are tables with RLS enabled, the pol

pgsql: pgcrypto: Remove internal padding implementation

2022-03-22 Thread Peter Eisentraut
pgcrypto: Remove internal padding implementation Use the padding provided by OpenSSL instead of doing it ourselves. The internal implementation was once applicable to the non-OpenSSL code paths, but those have since been removed. The padding algorithm is still the same. The OpenSSL padding imple