pgsql: Wait for subscription to sync in t/031_column_list.sql

2022-03-26 Thread Tomas Vondra
Wait for subscription to sync in t/031_column_list.sql One of the TAP tests added in 923def9a53 did not wait after creating a subscription, and wait_for_catchup is not sufficient for this. So if the tablesync workers happen do not complete quickly enough, the test won't see the expected results.

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Daniel Gustafsson
> On 27 Mar 2022, at 00:19, Tom Lane wrote: > Not sure why I don't have it enabled on florican, will fix that. Thanks, much appreciated! -- Daniel Gustafsson https://vmware.com/

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Tom Lane
Daniel Gustafsson writes: > A semi-related comment, I wish more of the animals ran ssl-check and not just > compiled with OpenSSL, it would be nice to have the SSL test excercised more. FWIW, the following active animals seem to have that enabled: chipmunk crake drongo eelpout elver fairyw

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Daniel Gustafsson
> On 26 Mar 2022, at 23:19, Andrew Dunstan wrote: > On 3/26/22 18:15, Tom Lane wrote: >> Looks like crake has a hard-wired list of INC directories for this step, >> that now needs to be extended to include src/test/ssl/t/. > Exactly. New run is currently executing. Thanks, I'm keeping an eye on

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Andrew Dunstan
On 3/26/22 18:15, Tom Lane wrote: > Daniel Gustafsson writes: >> crake complained in the Perl check due to not being able to locate the new >> backend specific module: >> Mar 26 17:54:33 ./src/test/ssl/t/SSL/Backend/OpenSSL.pm syntax OK >> Mar 26 17:54:33 Can't locate SSL/Backend/OpenSSL.pm in @

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Tom Lane
Daniel Gustafsson writes: > crake complained in the Perl check due to not being able to locate the new > backend specific module: > Mar 26 17:54:33 ./src/test/ssl/t/SSL/Backend/OpenSSL.pm syntax OK > Mar 26 17:54:33 Can't locate SSL/Backend/OpenSSL.pm in @INC (you may need to > install the SSL::

Re: pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Daniel Gustafsson
> On 26 Mar 2022, at 22:06, Daniel Gustafsson > wrote: > > SSL TAP test backend library independence refactoring crake complained in the Perl check due to not being able to locate the new backend specific module: Mar 26 17:54:33 ./src/test/ssl/t/SSL/Backend/OpenSSL.pm syntax OK Mar 26 17:54:33

pgsql: SSL TAP test backend library independence refactoring

2022-03-26 Thread Daniel Gustafsson
SSL TAP test backend library independence refactoring The SSL TAP tests were tightly coupled to the OpenSSL implementation, making it hard to add support for additional SSL/TLS backends. This refactoring makes the test avoid depending on specific implementations The SSLServer Perl module is rena

pgsql: Suppress compiler warning in relptr_store().

2022-03-26 Thread Tom Lane
Suppress compiler warning in relptr_store(). clang 13 with -Wextra warns that "performing pointer subtraction with a null pointer has undefined behavior" in the places where freepage.c tries to set a relptr variable to constant NULL. This appears to be a compiler bug, but it's unlikely to get fix

pgsql: Suppress compiler warning in relptr_store().

2022-03-26 Thread Tom Lane
Suppress compiler warning in relptr_store(). clang 13 with -Wextra warns that "performing pointer subtraction with a null pointer has undefined behavior" in the places where freepage.c tries to set a relptr variable to constant NULL. This appears to be a compiler bug, but it's unlikely to get fix

pgsql: Suppress compiler warning in relptr_store().

2022-03-26 Thread Tom Lane
Suppress compiler warning in relptr_store(). clang 13 with -Wextra warns that "performing pointer subtraction with a null pointer has undefined behavior" in the places where freepage.c tries to set a relptr variable to constant NULL. This appears to be a compiler bug, but it's unlikely to get fix

pgsql: Suppress compiler warning in relptr_store().

2022-03-26 Thread Tom Lane
Suppress compiler warning in relptr_store(). clang 13 with -Wextra warns that "performing pointer subtraction with a null pointer has undefined behavior" in the places where freepage.c tries to set a relptr variable to constant NULL. This appears to be a compiler bug, but it's unlikely to get fix

pgsql: Suppress compiler warning in relptr_store().

2022-03-26 Thread Tom Lane
Suppress compiler warning in relptr_store(). clang 13 with -Wextra warns that "performing pointer subtraction with a null pointer has undefined behavior" in the places where freepage.c tries to set a relptr variable to constant NULL. This appears to be a compiler bug, but it's unlikely to get fix

pgsql: Suppress compiler warning in relptr_store().

2022-03-26 Thread Tom Lane
Suppress compiler warning in relptr_store(). clang 13 with -Wextra warns that "performing pointer subtraction with a null pointer has undefined behavior" in the places where freepage.c tries to set a relptr variable to constant NULL. This appears to be a compiler bug, but it's unlikely to get fix

pgsql: Move prattrs to the pg_publication_rel section in docs

2022-03-26 Thread Tomas Vondra
Move prattrs to the pg_publication_rel section in docs Commit 923def9a53 documented the prattrs to the pg_publication_namespace catalog, probably due to a rebase mistake. Move it to the section for the pg_publication_rel catalog. Author: Noriyoshi Shinoda Discussion: https://postgr.es/m/ph7pr84m

pgsql: Suppress compiler warning in pub_collist_to_bitmapset().

2022-03-26 Thread Tom Lane
Suppress compiler warning in pub_collist_to_bitmapset(). A fair percentage of the buildfarm doesn't recognize that oldcxt won't be used uninitialized; silence those warnings by initializing it. While here, upgrade the function's thoroughly inadequate header comment. Oversight in 923def9a5, per b