pgsql: Stabilize streaming tests in test_decoding.

2022-04-19 Thread Amit Kapila
Stabilize streaming tests in test_decoding. We have some streaming tests that rely on the size of changes which can fail if there are additional changes like invalidation messages by background activity like auto analyze. Avoid such failures by increasing autovacuum_naptime to a reasonably high va

pgsql: Stabilize streaming tests in test_decoding.

2022-04-19 Thread Amit Kapila
Stabilize streaming tests in test_decoding. We have some streaming tests that rely on the size of changes which can fail if there are additional changes like invalidation messages by background activity like auto analyze. Avoid such failures by increasing autovacuum_naptime to a reasonably high va

pgsql: Doc: use "an SQL" consistently rather than "a SQL"

2022-04-19 Thread David Rowley
Doc: use "an SQL" consistently rather than "a SQL" Similarly to what was done in 04539e73f, we standardized on SQL being pronounced "es-que-ell" rather than "sequel" in our documentation. Two inconsistencies have crept in during the v15 cycle. The others existed before but were missed in 04539e7

pgsql: Fix breakage in AlterFunction().

2022-04-19 Thread Tom Lane
Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I

pgsql: Fix breakage in AlterFunction().

2022-04-19 Thread Tom Lane
Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I

pgsql: Fix breakage in AlterFunction().

2022-04-19 Thread Tom Lane
Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I

pgsql: Fix breakage in AlterFunction().

2022-04-19 Thread Tom Lane
Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I

pgsql: Fix breakage in AlterFunction().

2022-04-19 Thread Tom Lane
Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I

pgsql: Fix breakage in AlterFunction().

2022-04-19 Thread Tom Lane
Fix breakage in AlterFunction(). An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4f2. (I

pgsql: Remove duplicated word in comment of basebackup.c

2022-04-19 Thread Michael Paquier
Remove duplicated word in comment of basebackup.c Oversight in 39969e2. Author: Martín Marqués Discussion: https://postgr.es/m/CABeG9LviA01oHC5h=ksLUuhMyXxmZR_tftRq6q3341CMT=j=4...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/83cca409edf276cfbd2f

pgsql: Fix extract epoch from interval calculation

2022-04-19 Thread Peter Eisentraut
Fix extract epoch from interval calculation The new numeric code for extract epoch from interval accidentally truncated the DAYS_PER_YEAR value to an integer, leading to results that mismatched the floating-point interval_part calculations. The commit a2da77cdb4661826482ebf2ddba1f953bc74afe4 that

pgsql: Fix extract epoch from interval calculation

2022-04-19 Thread Peter Eisentraut
Fix extract epoch from interval calculation The new numeric code for extract epoch from interval accidentally truncated the DAYS_PER_YEAR value to an integer, leading to results that mismatched the floating-point interval_part calculations. The commit a2da77cdb4661826482ebf2ddba1f953bc74afe4 that

Re: pgsql: Fix some trailing whitespace in documentation files

2022-04-19 Thread Bruce Momjian
On Tue, Apr 19, 2022 at 08:57:23PM +0200, Daniel Gustafsson wrote: > > On 19 Apr 2022, at 16:24, Tom Lane wrote: > > > It's bothered the neatnik in me for a long time, so I'm happy to > > make it happen if there are not objections. > > Mildly on-topic: Has the topic of a pgindent like process fo

Re: pgsql: Fix some trailing whitespace in documentation files

2022-04-19 Thread Daniel Gustafsson
> On 19 Apr 2022, at 16:24, Tom Lane wrote: > It's bothered the neatnik in me for a long time, so I'm happy to > make it happen if there are not objections. Mildly on-topic: Has the topic of a pgindent like process for docs been discussed at some point? The archives didn't turn up anything for m

Re: pgsql: Fix some trailing whitespace in documentation files

2022-04-19 Thread Tom Lane
Peter Eisentraut writes: > On 16.04.22 22:26, Tom Lane wrote: >> I'm not quite sure what's the point of retail fixes. I could >> get behind removing*all* these occurrences, and then adjusting >> .gitattributes so that git bleats about introducing new ones. >> Other folks might find that a little

Re: pgsql: Fix some trailing whitespace in documentation files

2022-04-19 Thread Peter Eisentraut
On 16.04.22 22:26, Tom Lane wrote: Hmm ... by my count there are still 245 lines with trailing spaces in the *.sgml files. (Most but not all are from copied-n-pasted psql output.) I'm not quite sure what's the point of retail fixes. I could get behind removing*all* these occurrences, and then

Re: pgsql: Fix some trailing whitespace in documentation files

2022-04-19 Thread Daniel Gustafsson
> On 16 Apr 2022, at 22:26, Tom Lane wrote: > I'm not quite sure what's the point of retail fixes. I could > get behind removing *all* these occurrences, and then adjusting > .gitattributes so that git bleats about introducing new ones. > Other folks might find that a little too obsessive-compul

pgsql: Fix aggregate logging of pgbench.

2022-04-19 Thread Tatsuo Ishii
Fix aggregate logging of pgbench. Remove meaningless "failures" column from the aggregate logging. It was just a sum of "serialization failures" and "deadlock failures". Pointed out by Tom Lane. Patch reviewed by Fabien COELHO. Discussion: https://postgr.es/m/4183048.1649536705%40sss.pgh.pa.us B