pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap.

2022-06-22 Thread Amit Kapila
Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we

pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap.

2022-06-22 Thread Amit Kapila
Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we

pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap.

2022-06-22 Thread Amit Kapila
Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we

pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap.

2022-06-22 Thread Amit Kapila
Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we

pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap.

2022-06-22 Thread Amit Kapila
Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we

pgsql: Fix memory leak due to LogicalRepRelMapEntry.attrmap.

2022-06-22 Thread Amit Kapila
Fix memory leak due to LogicalRepRelMapEntry.attrmap. When rebuilding the relation mapping on subscribers, we were not releasing the attribute mapping's memory which was no longer required. The attribute mapping used in logical tuple conversion was refactored in PG13 (by commit e1551f96e6) but we

pgsql: Fix two issues with HEADER MATCH in COPY

2022-06-22 Thread Michael Paquier
Fix two issues with HEADER MATCH in COPY 072132f0 used the attnum offset to access the raw_fields array when checking that the attribute names of the header and of the relation match, leading to incorrect results or even crashes if the attribute numbers of a relation are changed, like on a dropped

pgsql: pgstat: Mention pgstat_replslot.c in pgstat.c.

2022-06-22 Thread Andres Freund
pgstat: Mention pgstat_replslot.c in pgstat.c. Oversight, by me, in commit 5891c7a8ed8. Author: "Drouvot, Bertrand" Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eba331ae2aad781d498f

pgsql: doc: improve wording of plpgsql RAISE format text

2022-06-22 Thread Bruce Momjian
doc: improve wording of plpgsql RAISE format text Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0b135e4c2ec9b8db

pgsql: doc: improve wording of plpgsql RAISE format text

2022-06-22 Thread Bruce Momjian
doc: improve wording of plpgsql RAISE format text Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f1e3a7075

pgsql: doc: improve wording of plpgsql RAISE format text

2022-06-22 Thread Bruce Momjian
doc: improve wording of plpgsql RAISE format text Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d1ec8eaf7

pgsql: doc: improve wording of plpgsql RAISE format text

2022-06-22 Thread Bruce Momjian
doc: improve wording of plpgsql RAISE format text Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/5ad46aec8

pgsql: doc: improve wording of plpgsql RAISE format text

2022-06-22 Thread Bruce Momjian
doc: improve wording of plpgsql RAISE format text Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9adc4cd3d

pgsql: doc: improve wording of plpgsql RAISE format text

2022-06-22 Thread Bruce Momjian
doc: improve wording of plpgsql RAISE format text Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9c3e3d6bc

pgsql: doc: clarify wording about phantom reads

2022-06-22 Thread Bruce Momjian
doc: clarify wording about phantom reads Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/1463f22d42fddc620

pgsql: doc: clarify wording about phantom reads

2022-06-22 Thread Bruce Momjian
doc: clarify wording about phantom reads Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/c08b3e9413b745b00

pgsql: doc: clarify wording about phantom reads

2022-06-22 Thread Bruce Momjian
doc: clarify wording about phantom reads Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3485f8d03eb8cdaa1

pgsql: doc: clarify wording about phantom reads

2022-06-22 Thread Bruce Momjian
doc: clarify wording about phantom reads Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/f831a4b99ffda6d80

pgsql: doc: clarify wording about phantom reads

2022-06-22 Thread Bruce Momjian
doc: clarify wording about phantom reads Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/a9a230e623e551889b325bc5

pgsql: doc: clarify wording about phantom reads

2022-06-22 Thread Bruce Momjian
doc: clarify wording about phantom reads Reported-by: [email protected] Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4e594a42657e4a62e

pgsql: amcheck: Fix incorrect use of VARATT_IS_COMPRESSED.

2022-06-22 Thread Robert Haas
amcheck: Fix incorrect use of VARATT_IS_COMPRESSED. The macro is being applied to a TOAST pointer, not a varlena header. Therefore the use of VARATT_IS_COMPRESSED() is wrong. We can check VARATT_EXTERNAL_IS_COMPRESSED(), but then we don't need the length check that follows. Report and fix by Kyot

pgsql: Fix SPI's handling of errors during transaction commit.

2022-06-22 Thread Tom Lane
Fix SPI's handling of errors during transaction commit. SPI_commit previously left it up to the caller to recover from any error occurring during commit. Since that's complicated and requires use of low-level xact.c facilities, it's not too surprising that no caller got it right. Let's move the

pgsql: Fix SPI's handling of errors during transaction commit.

2022-06-22 Thread Tom Lane
Fix SPI's handling of errors during transaction commit. SPI_commit previously left it up to the caller to recover from any error occurring during commit. Since that's complicated and requires use of low-level xact.c facilities, it's not too surprising that no caller got it right. Let's move the

pgsql: Fix SPI's handling of errors during transaction commit.

2022-06-22 Thread Tom Lane
Fix SPI's handling of errors during transaction commit. SPI_commit previously left it up to the caller to recover from any error occurring during commit. Since that's complicated and requires use of low-level xact.c facilities, it's not too surprising that no caller got it right. Let's move the

pgsql: Fix SPI's handling of errors during transaction commit.

2022-06-22 Thread Tom Lane
Fix SPI's handling of errors during transaction commit. SPI_commit previously left it up to the caller to recover from any error occurring during commit. Since that's complicated and requires use of low-level xact.c facilities, it's not too surprising that no caller got it right. Let's move the

pgsql: doc: Clean up title case use

2022-06-22 Thread Peter Eisentraut
doc: Clean up title case use Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9f0b953457012a41321ab62cffa6aeabcb6e99b2 Modified Files -- doc/src/sgml/config.sgml | 2 +- doc/src/sgml/ref/pgbench.sgml | 4 ++-- 2 files changed, 3 insertions(+), 3 deleti