Re: pgsql: Fix out-of-bounds read in json_lex_string

2022-07-11 Thread Tom Lane
I wrote: > John Naylor writes: >> ld: error: unable to find library -lldap_r > Agreed, that looks like some unrelated platform change. Larry? Upon further thought, this looks like fallout from an upgrade to OpenLDAP 2.5, which eliminated libldap_r. That should be fine, but you might need to bl

Re: pgsql: Fix out-of-bounds read in json_lex_string

2022-07-11 Thread Tom Lane
John Naylor writes: > On Tue, Jul 12, 2022 at 11:27 AM John Naylor > wrote: >> Fix out-of-bounds read in json_lex_string > The failure on peripatus (FreeBSD HEAD) seems completely unrelated to > the changes in the commit: > ld: error: unable to find library -lldap_r Agreed, that looks like som

Re: pgsql: Fix out-of-bounds read in json_lex_string

2022-07-11 Thread John Naylor
On Tue, Jul 12, 2022 at 11:27 AM John Naylor wrote: > > Fix out-of-bounds read in json_lex_string The failure on peripatus (FreeBSD HEAD) seems completely unrelated to the changes in the commit: ld: error: unable to find library -lldap_r clang: error: linker command failed with exit code 1 (use

pgsql: Fix out-of-bounds read in json_lex_string

2022-07-11 Thread John Naylor
Fix out-of-bounds read in json_lex_string Commit 3838fa269 added a lookahead loop to allow building strings multiple bytes at a time. This loop could exit because it reached the end of input, yet did not check for that before checking if we reached the end of a valid string. To fix, put the end of

Re: pgsql: Build de-escaped JSON strings in larger chunks during lexing

2022-07-11 Thread John Naylor
On Tue, Jul 12, 2022 at 5:15 AM Tom Lane wrote: > > It looks like this broke buildfarm member skink (valgrind). Looking... -- John Naylor EDB: http://www.enterprisedb.com

pgsql: Support TRUNCATE triggers on foreign tables.

2022-07-11 Thread Fujii Masao
Support TRUNCATE triggers on foreign tables. Now some foreign data wrappers support TRUNCATE command. So it's useful to support TRUNCATE triggers on foreign tables for audit logging or for preventing undesired truncation. Author: Yugo Nagata Reviewed-by: Fujii Masao, Ian Lawrence Barwick Discussi

pgsql: Doc: Acknowledge historically supported CPUs and OSes.

2022-07-11 Thread Thomas Munro
Doc: Acknowledge historically supported CPUs and OSes. PostgreSQL/POSTGRES has run on a huge range of CPUs and OSes. As we're dropping some of the earliest systems the project was founded on, let's provide a place to remember them. Discussion: https://postgr.es/m/959917.1657522169%40sss.pgh.pa.u

pgsql: Further tidy-up for old CPU architectures.

2022-07-11 Thread Thomas Munro
Further tidy-up for old CPU architectures. Further to commit 92d70b77, let's drop the code we carry for the following untested architectures: M68K, M88K, M32R, SuperH. We have no idea if anything actually works there, and surely as vintage hardware and microcontrollers they would be underpowered

Re: pgsql: Build de-escaped JSON strings in larger chunks during lexing

2022-07-11 Thread Tom Lane
John Naylor writes: > Build de-escaped JSON strings in larger chunks during lexing It looks like this broke buildfarm member skink (valgrind). regards, tom lane

pgsql: Provide log_status_format(), useful for an emit_log_hook.

2022-07-11 Thread Jeff Davis
Provide log_status_format(), useful for an emit_log_hook. Refactor so that log_line_prefix() is a thin wrapper over a new function log_status_format(), and move the implementation to the latter. Export log_status_format() so that it can be used by an emit_log_hook. Discussion: https://postgr.es/

pgsql: relnotes: updates "cumulative statistics system" mention

2022-07-11 Thread Bruce Momjian
relnotes: updates "cumulative statistics system" mention Also add "the". Reported-by: Justin Pryzby Discussion: https://postgr.es/m/[email protected] Backpatch-through: 15 only Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d8759a40bfc

pgsql: Rationalize order of input files for gen_node_support.pl.

2022-07-11 Thread Tom Lane
Rationalize order of input files for gen_node_support.pl. Per a question from Andres Freund. While here, also make the list of nodetag-only files easier to compare to the full list of input files. Discussion: https://postgr.es/m/[email protected] Branch --

pgsql: Fix mistake in comment.

2022-07-11 Thread Robert Haas
Fix mistake in comment. Kyotaro Horiguchi Discussion: http://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b2d5b4c6e09b2a505ced098d2cb1e7b015bfc50d Modified Files -- src/backend/