pgsql: Fix inconsistent parameter names between prototype and declarati

2022-07-14 Thread David Rowley
Fix inconsistent parameter names between prototype and declaration Noticed while working in this area. This code was introduced in PG15, which is still in beta, so backpatch to there for consistency. Backpatch-through: 15 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/p

pgsql: Fix inconsistent parameter names between prototype and declarati

2022-07-14 Thread David Rowley
Fix inconsistent parameter names between prototype and declaration Noticed while working in this area. This code was introduced in PG15, which is still in beta, so backpatch to there for consistency. Backpatch-through: 15 Branch -- master Details --- https://git.postgresql.org/pg/commi

pgsql: Clarify that pg_dump takes ACCESS SHARE lock

2022-07-14 Thread John Naylor
Clarify that pg_dump takes ACCESS SHARE lock Add link to the description of lock levels to avoid confusing "shared locks" with SHARE locks. Florin Irion Reviewed-by: Álvaro Herrera, Tom Lane, and Nathan Bossart Discussion: https://www.postgresql.org/message-id/flat/d0f30cc2-3c76-1d43-f291-7c4b2

pgsql: Clarify that pg_dump takes ACCESS SHARE lock

2022-07-14 Thread John Naylor
Clarify that pg_dump takes ACCESS SHARE lock Add link to the description of lock levels to avoid confusing "shared locks" with SHARE locks. Florin Irion Reviewed-by: Álvaro Herrera, Tom Lane, and Nathan Bossart Discussion: https://www.postgresql.org/message-id/flat/d0f30cc2-3c76-1d43-f291-7c4b2

pgsql: docs: make monitoring "phases" table titles consistent

2022-07-14 Thread Bruce Momjian
docs: make monitoring "phases" table titles consistent Reported-by: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWbmTHwHKC2PERH0CCaFVPoxrtLeS8=wnuoge94qdsp...@mail.gmail.com Author: Nitin Jadhav Backpatch-through: 13 Branch -- REL_15_STABLE Details --- https://git.postgresql.o

pgsql: docs: make monitoring "phases" table titles consistent

2022-07-14 Thread Bruce Momjian
docs: make monitoring "phases" table titles consistent Reported-by: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWbmTHwHKC2PERH0CCaFVPoxrtLeS8=wnuoge94qdsp...@mail.gmail.com Author: Nitin Jadhav Backpatch-through: 13 Branch -- REL_14_STABLE Details --- https://git.postgresql.o

pgsql: docs: make monitoring "phases" table titles consistent

2022-07-14 Thread Bruce Momjian
docs: make monitoring "phases" table titles consistent Reported-by: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWbmTHwHKC2PERH0CCaFVPoxrtLeS8=wnuoge94qdsp...@mail.gmail.com Author: Nitin Jadhav Backpatch-through: 13 Branch -- master Details --- https://git.postgresql.org/pg/c

pgsql: docs: make monitoring "phases" table titles consistent

2022-07-14 Thread Bruce Momjian
docs: make monitoring "phases" table titles consistent Reported-by: Nitin Jadhav Discussion: https://postgr.es/m/CAMm1aWbmTHwHKC2PERH0CCaFVPoxrtLeS8=wnuoge94qdsp...@mail.gmail.com Author: Nitin Jadhav Backpatch-through: 13 Branch -- REL_13_STABLE Details --- https://git.postgresql.o

pgsql: doc: clarify how dropping of extensions affects dependent objs.

2022-07-14 Thread Bruce Momjian
doc: clarify how dropping of extensions affects dependent objs. Clarify that functions/procedures are dropped when any extension that depends on them is dropped. Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwbPSHMDGkisRUmewopweC1bFvytVqB=a=X4GFg=4zw...@mail.gmail.com B

pgsql: doc: clarify how dropping of extensions affects dependent objs.

2022-07-14 Thread Bruce Momjian
doc: clarify how dropping of extensions affects dependent objs. Clarify that functions/procedures are dropped when any extension that depends on them is dropped. Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwbPSHMDGkisRUmewopweC1bFvytVqB=a=X4GFg=4zw...@mail.gmail.com B

pgsql: doc: clarify how dropping of extensions affects dependent objs.

2022-07-14 Thread Bruce Momjian
doc: clarify how dropping of extensions affects dependent objs. Clarify that functions/procedures are dropped when any extension that depends on them is dropped. Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwbPSHMDGkisRUmewopweC1bFvytVqB=a=X4GFg=4zw...@mail.gmail.com B

pgsql: doc: clarify how dropping of extensions affects dependent objs.

2022-07-14 Thread Bruce Momjian
doc: clarify how dropping of extensions affects dependent objs. Clarify that functions/procedures are dropped when any extension that depends on them is dropped. Reported-by: David G. Johnston Discussion: https://postgr.es/m/CAKFQuwbPSHMDGkisRUmewopweC1bFvytVqB=a=X4GFg=4zw...@mail.gmail.com B

pgsql: pg_upgrade doc: mention that replication slots must be recreated

2022-07-14 Thread Bruce Momjian
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/47

pgsql: pg_upgrade doc: mention that replication slots must be recreated

2022-07-14 Thread Bruce Momjian
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commit

pgsql: pg_upgrade doc: mention that replication slots must be recreated

2022-07-14 Thread Bruce Momjian
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commit

pgsql: pg_upgrade doc: mention that replication slots must be recreated

2022-07-14 Thread Bruce Momjian
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commit

pgsql: pg_upgrade doc: mention that replication slots must be recreated

2022-07-14 Thread Bruce Momjian
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commit

pgsql: pg_upgrade doc: mention that replication slots must be recreated

2022-07-14 Thread Bruce Momjian
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commit

pgsql: pg_upgrade doc: mention that replication slots must be recreated

2022-07-14 Thread Bruce Momjian
pg_upgrade doc: mention that replication slots must be recreated Reported-by: Nikhil Shetty Discussion: https://postgr.es/m/CAFpL5Vxastip0Jei-K-=7cKXTg=5sahSe5g=om=x68nox8+...@mail.gmail.com Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commit

pgsql: doc: add documentation about ecpg Oracle-compatibility mode

2022-07-14 Thread Bruce Momjian
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_11_STABLE Details --- https://git.postgresql.org

pgsql: doc: add documentation about ecpg Oracle-compatibility mode

2022-07-14 Thread Bruce Momjian
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_12_STABLE Details --- https://git.postgresql.org

pgsql: doc: add documentation about ecpg Oracle-compatibility mode

2022-07-14 Thread Bruce Momjian
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_14_STABLE Details --- https://git.postgresql.org

pgsql: doc: add documentation about ecpg Oracle-compatibility mode

2022-07-14 Thread Bruce Momjian
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_15_STABLE Details --- https://git.postgresql.org

pgsql: doc: add documentation about ecpg Oracle-compatibility mode

2022-07-14 Thread Bruce Momjian
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- master Details --- https://git.postgresql.org/pg/com

pgsql: doc: add documentation about ecpg Oracle-compatibility mode

2022-07-14 Thread Bruce Momjian
doc: add documentation about ecpg Oracle-compatibility mode Reported-by: Takeshi Ideriha Discussion: https://postgr.es/m/tycpr01mb7041a157067208327d8daaf9ea...@tycpr01mb7041.jpnprd01.prod.outlook.com Backpatch-through: 11 Branch -- REL_13_STABLE Details --- https://git.postgresql.org

pgsql: doc: move system views section to its own chapter

2022-07-14 Thread Bruce Momjian
doc: move system views section to its own chapter Previously it was inside the system catalogs chapter. Reported-by: Peter Smith Discussion: https://postgr.es/m/cahut+psmc18qp60d+l0hjboxrlqt5m88yvacdyxlq34gfph...@mail.gmail.com Backpatch-through: 15 Branch -- REL_15_STABLE Details -

pgsql: doc: move system views section to its own chapter

2022-07-14 Thread Bruce Momjian
doc: move system views section to its own chapter Previously it was inside the system catalogs chapter. Reported-by: Peter Smith Discussion: https://postgr.es/m/cahut+psmc18qp60d+l0hjboxrlqt5m88yvacdyxlq34gfph...@mail.gmail.com Backpatch-through: 15 Branch -- master Details --- http

pgsql: doc: clarify the behavior of identically-named savepoints

2022-07-14 Thread Bruce Momjian
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_14_STABLE Details ---

pgsql: doc: clarify the behavior of identically-named savepoints

2022-07-14 Thread Bruce Momjian
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_15_STABLE Details ---

pgsql: doc: clarify the behavior of identically-named savepoints

2022-07-14 Thread Bruce Momjian
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- master Details --- https:/

pgsql: doc: clarify the behavior of identically-named savepoints

2022-07-14 Thread Bruce Momjian
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_10_STABLE Details ---

pgsql: doc: clarify the behavior of identically-named savepoints

2022-07-14 Thread Bruce Momjian
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_13_STABLE Details ---

pgsql: doc: clarify the behavior of identically-named savepoints

2022-07-14 Thread Bruce Momjian
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_11_STABLE Details ---

pgsql: doc: clarify the behavior of identically-named savepoints

2022-07-14 Thread Bruce Momjian
doc: clarify the behavior of identically-named savepoints Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwyqcxssusl18skcwg8qhfswoj3hjovhsozue346i4o...@mail.gmail.com Backpatch-through: 10 Branch -- REL_12_STABLE Details ---

pgsql: doc: clarify that "excluded" ON CONFLICT is a single row

2022-07-14 Thread Bruce Momjian
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_10_STABLE Details --- h

pgsql: doc: clarify that "excluded" ON CONFLICT is a single row

2022-07-14 Thread Bruce Momjian
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_14_STABLE Details --- h

pgsql: doc: clarify that "excluded" ON CONFLICT is a single row

2022-07-14 Thread Bruce Momjian
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_11_STABLE Details --- h

pgsql: doc: clarify that "excluded" ON CONFLICT is a single row

2022-07-14 Thread Bruce Momjian
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- master Details --- https://

pgsql: doc: clarify that "excluded" ON CONFLICT is a single row

2022-07-14 Thread Bruce Momjian
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_15_STABLE Details --- h

pgsql: doc: clarify that "excluded" ON CONFLICT is a single row

2022-07-14 Thread Bruce Momjian
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_13_STABLE Details --- h

pgsql: doc: clarify that "excluded" ON CONFLICT is a single row

2022-07-14 Thread Bruce Momjian
doc: clarify that "excluded" ON CONFLICT is a single row Original patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwa4j0+wuo7kw1plbjoevzpn+q_j+p2bxxnnclaszy7...@mail.gmail.com Backpatch-through: 10 Branch -- REL_12_STABLE Details --- h

pgsql: doc: mention that INSERT can block because of unique indexes

2022-07-14 Thread Bruce Momjian
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_10_STABLE Details --

pgsql: doc: mention that INSERT can block because of unique indexes

2022-07-14 Thread Bruce Momjian
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_13_STABLE Details --

pgsql: doc: mention that INSERT can block because of unique indexes

2022-07-14 Thread Bruce Momjian
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_11_STABLE Details --

pgsql: doc: mention that INSERT can block because of unique indexes

2022-07-14 Thread Bruce Momjian
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_14_STABLE Details --

pgsql: doc: mention that INSERT can block because of unique indexes

2022-07-14 Thread Bruce Momjian
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_15_STABLE Details --

pgsql: doc: mention that INSERT can block because of unique indexes

2022-07-14 Thread Bruce Momjian
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- master Details --- https

pgsql: doc: mention that INSERT can block because of unique indexes

2022-07-14 Thread Bruce Momjian
doc: mention that INSERT can block because of unique indexes Initial patch by David G. Johnston. Reported-by: David G. Johnston Discussion: https://postgr.es/m/cakfquwzpbdzceo41ve-xt1xh8rwrrfgoptak1wl9ehco0am...@mail.gmail.com Backpatch-through: 10 Branch -- REL_12_STABLE Details --

pgsql: doc: mention the pg_locks lock names in parentheses

2022-07-14 Thread Bruce Momjian
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_12_STABLE Details --- https://git.postgresql.org/pg/commitdiff/64695a3ce646a

pgsql: doc: mention the pg_locks lock names in parentheses

2022-07-14 Thread Bruce Momjian
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_11_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9d352c4448e98

pgsql: doc: mention the pg_locks lock names in parentheses

2022-07-14 Thread Bruce Momjian
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/8db5026d0a085

pgsql: doc: mention the pg_locks lock names in parentheses

2022-07-14 Thread Bruce Momjian
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/6396ab3d14278

pgsql: doc: mention the pg_locks lock names in parentheses

2022-07-14 Thread Bruce Momjian
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3e071b2cf584052b0799

pgsql: doc: mention the pg_locks lock names in parentheses

2022-07-14 Thread Bruce Momjian
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/3336b3de34e1b

pgsql: doc: mention the pg_locks lock names in parentheses

2022-07-14 Thread Bruce Momjian
doc: mention the pg_locks lock names in parentheses Reported-by: Troy Frericks Discussion: https://postgr.es/m/[email protected] Backpatch-through: 10 Branch -- REL_10_STABLE Details --- https://git.postgresql.org/pg/commitdiff/88580b63ebe45

Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.

2022-07-14 Thread Tom Lane
Peter Eisentraut writes: > It seems that -fkeep-inline-functions is more demanding than what wrasse > is running on. I need the attached patch to get it to build cleanly. Interesting. I'm not entirely clear on which external references cause wrasse to spit up. > I think this would be good to

Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.

2022-07-14 Thread Peter Eisentraut
On 14.07.22 12:05, Peter Eisentraut wrote: On 13.07.22 20:24, Tom Lane wrote: Peter Eisentraut writes: What platforms did this fail on?  How can one observe the failure locally? wrasse at least: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17

pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.

2022-07-14 Thread Thomas Munro
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask

pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.

2022-07-14 Thread Thomas Munro
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask

pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.

2022-07-14 Thread Thomas Munro
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask

pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.

2022-07-14 Thread Thomas Munro
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask

pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.

2022-07-14 Thread Thomas Munro
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask

pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.

2022-07-14 Thread Thomas Munro
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask

pgsql: Don't clobber postmaster sigmask in dsm_impl_resize.

2022-07-14 Thread Thomas Munro
Don't clobber postmaster sigmask in dsm_impl_resize. Commit 4518c798 intended to block signals in regular backends that allocate DSM segments, but dsm_impl_resize() is also reached by dsm_postmaster_startup(). It's not OK to clobber the postmaster's signal mask, so only manipulate the signal mask

pgsql: Tighten up parsing logic in gen_node_support.pl.

2022-07-14 Thread Tom Lane
Tighten up parsing logic in gen_node_support.pl. Teach this script to handle function pointer fields honestly. Previously they were just silently ignored, but that's not likely to be a behavior we can accept indefinitely. This mostly entails fixing it so that a field declaration spanning multiple

pgsql: Avoid shadowing a variable in sync.c.

2022-07-14 Thread Thomas Munro
Avoid shadowing a variable in sync.c. It was confusing to reuse the variable name 'entry' in two scopes. Use distinct variable names. Reported-by: Ranier Vilela Reported-by: Tom Lane Reported-by: Kyotaro Horiguchi Discussion: https://postgr.es/m/CAEudQArDrFyQ15Am3rgWBunGBVZFDb90onTS8SRiFAWHei

pgsql: Block signals while allocating DSM memory.

2022-07-14 Thread Thomas Munro
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd

pgsql: Block signals while allocating DSM memory.

2022-07-14 Thread Thomas Munro
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd

pgsql: Block signals while allocating DSM memory.

2022-07-14 Thread Thomas Munro
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd

pgsql: Block signals while allocating DSM memory.

2022-07-14 Thread Thomas Munro
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd

pgsql: Block signals while allocating DSM memory.

2022-07-14 Thread Thomas Munro
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd

pgsql: Block signals while allocating DSM memory.

2022-07-14 Thread Thomas Munro
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd

pgsql: Block signals while allocating DSM memory.

2022-07-14 Thread Thomas Munro
Block signals while allocating DSM memory. On Linux, we call posix_fallocate() on shm_open()'d memory to avoid later potential SIGBUS (see commit 899bd785). Based on field reports of systems stuck in an EINTR retry loop there, there, we made it possible to break out of that loop via slightly odd

pgsql: Remove redundant ftruncate() for POSIX DSM memory.

2022-07-14 Thread Thomas Munro
Remove redundant ftruncate() for POSIX DSM memory. In early releases of the DSM infrastructure, it was possible to resize segments. That was removed in release 12 by commit 3c60d0fa. Now the ftruncate() + posix_fallocate() sequence during DSM segment creation has a redundant step: we're always e

pgsql: Create a distinct wait event for POSIX DSM allocation.

2022-07-14 Thread Thomas Munro
Create a distinct wait event for POSIX DSM allocation. Previously we displayed "DSMFillZeroWrite" while in posix_fallocate(), because we shared the same wait event for "mmap" and "posix" DSM types. Let's introduce a new wait event "DSMAllocate", to be more accurate. Reported-by: Andres Freund Di

Re: pgsql: Avoid unsatisfied-external-reference errors in static inlines.

2022-07-14 Thread Peter Eisentraut
On 13.07.22 20:24, Tom Lane wrote: Peter Eisentraut writes: What platforms did this fail on? How can one observe the failure locally? wrasse at least: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=wrasse&dt=2022-07-13%2014%3A49%3A17 I think possibly you could duplicate the proble