Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Tom Lane
Justin Pryzby writes: > I think this is still failing > https://cirrus-ci.com/task/6142528721256448 Sigh ... misleading formatting led me to see one log_like as belonging to a connect_ok test, when it belongs to a connect_fails. Fixed, thanks. regards, tom lane

pgsql: Disable unstable test cases in src/test/ssl/t/001_ssltests.pl.

2022-07-16 Thread Tom Lane
Disable unstable test cases in src/test/ssl/t/001_ssltests.pl. Missed one in 55828a6b6084724b08675615a4e911ad4d421cd1 :-( Discussion: https://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/e993166d71878a11a177b3

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Justin Pryzby
On Sat, Jul 16, 2022 at 06:26:57PM -0400, Tom Lane wrote: > Andres Freund writes: > > On 2022-07-16 17:33:47 -0400, Tom Lane wrote: > >> Anyway, if Peter doesn't answer pretty soon I'll go do that. > > > It's about midnight in Germany, so unlikely to come soon... > > Done now. I think this is s

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Tom Lane
Andres Freund writes: > On 2022-07-16 17:33:47 -0400, Tom Lane wrote: >> Anyway, if Peter doesn't answer pretty soon I'll go do that. > It's about midnight in Germany, so unlikely to come soon... Done now. regards, tom lane

pgsql: Disable unstable test cases in src/test/ssl/t/001_ssltests.pl.

2022-07-16 Thread Tom Lane
Disable unstable test cases in src/test/ssl/t/001_ssltests.pl. Some of the test cases added by commit 3a0e38504 are failing intermittently in CI testing. It looks like, when a connection attempt fails, it's possible for psql to exit and the test script to slurp up the postmaster's log file before

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Andres Freund
Hi, On 2022-07-16 17:33:47 -0400, Tom Lane wrote: > Andres Freund writes: > > Yea, it's quite annoying. I think it might be worth to not wait for Peter to > > chime in, but to just add a skip to the test for now? > > I was thinking of commenting out the log_like parts of the affected > tests. M

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Tom Lane
Andres Freund writes: > On 2022-07-16 10:45:29 -0400, Tom Lane wrote: >> Looking at the cfbot, an annoyingly large percentage of current runs >> are being broken by this. I think we need to do this as a stopgap: >>> (2) abandon attempting to test this particular behavior. > Yea, it's quite annoy

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Andres Freund
Hi, On 2022-07-16 10:45:29 -0400, Tom Lane wrote: > > Justin Pryzby writes: > >> It failed for me just now: https://cirrus-ci.com/task/6502388730167296 > > Looking at the cfbot, an annoyingly large percentage of current runs > are being broken by this. I think we need to do this as a stopgap: >

pgsql: Remove postmaster.c's reset_shared() wrapper function.

2022-07-16 Thread Tom Lane
Remove postmaster.c's reset_shared() wrapper function. reset_shared just invokes CreateSharedMemoryAndSemaphores, so let's get rid of it and invoke that directly. This removes a confusing seeming-inconsistency between the postmaster's startup sequence and the startup sequence used in standalone m

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Tom Lane
> Justin Pryzby writes: >> It failed for me just now: https://cirrus-ci.com/task/6502388730167296 Looking at the cfbot, an annoyingly large percentage of current runs are being broken by this. I think we need to do this as a stopgap: > (2) abandon attempting to test this particular behavior. I

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Tom Lane
Justin Pryzby writes: > On Sat, Jul 16, 2022 at 01:57:25PM +0200, Peter Eisentraut wrote: >> Isn't the cfbot using the same thing? > It's using the same thing, so I suppose the failure is intermittent. > It failed for me just now: https://cirrus-ci.com/task/6502388730167296 It looks like a timin

pgsql: Attempt to fix compiler warning on old compiler

2022-07-16 Thread Peter Eisentraut
Attempt to fix compiler warning on old compiler A couple more like b449afb582bb9015bfbb85abc10ce122aef9ec70, per complaints from lapwing. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/506428d091760650971433f6bc083531c307b368 Modified Files -- contrib/

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Justin Pryzby
On Sat, Jul 16, 2022 at 01:57:25PM +0200, Peter Eisentraut wrote: > On 16.07.22 13:37, Justin Pryzby wrote: > > On Fri, Jul 15, 2022 at 03:35:28PM +, Peter Eisentraut wrote: > > > Log details for client certificate failures > > > > This seems to be causing cfbot/linux to fail since yesterday.

Re: pgsql: Replace many MemSet calls with struct initialization

2022-07-16 Thread Justin Pryzby
On Sat, Jul 16, 2022 at 06:53:16AM +, Peter Eisentraut wrote: > Replace many MemSet calls with struct initialization This failed https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2022-07-16%2008%3A40%3A14 It avoids the warning here to use {{0}}. But it doesn't seem worth it t

pgsql: Attempt to fix compiler warning on old compiler

2022-07-16 Thread Peter Eisentraut
Attempt to fix compiler warning on old compiler Build farm member lapwing (using gcc 4.7.2) didn't like one part of 9fd45870c1436b477264c0c82eb195df52bc0919, raising a compiler warning. Revert that for now. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/b449afb582b

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Peter Eisentraut
On 16.07.22 13:37, Justin Pryzby wrote: On Fri, Jul 15, 2022 at 03:35:28PM +, Peter Eisentraut wrote: Log details for client certificate failures This seems to be causing cfbot/linux to fail since yesterday. Hmm, the Cirrus CI build works for me: https://cirrus-ci.com/task/6520112718020

Re: pgsql: Log details for client certificate failures

2022-07-16 Thread Justin Pryzby
On Fri, Jul 15, 2022 at 03:35:28PM +, Peter Eisentraut wrote: > Log details for client certificate failures This seems to be causing cfbot/linux to fail since yesterday. -- Justin