pgsql: ci: remove minor version from freebsd image name

2022-07-31 Thread Andres Freund
ci: remove minor version from freebsd image name This way .cirrus.yml does not need to be changed just because freebsd releases a new minor version. Discussion: https://postgr.es/m/[email protected] Backpatch: 15-, just like the CI support Branch -- REL_15_ST

pgsql: ci: remove minor version from freebsd image name

2022-07-31 Thread Andres Freund
ci: remove minor version from freebsd image name This way .cirrus.yml does not need to be changed just because freebsd releases a new minor version. Discussion: https://postgr.es/m/[email protected] Backpatch: 15-, just like the CI support Branch -- master D

pgsql: Append -X to direct invocation of psql in new test for BASE_BACK

2022-07-31 Thread Michael Paquier
Append -X to direct invocation of psql in new test for BASE_BACKUP Per buildfarm member wrasse, that looks to open a transaction when it loads its .psqlrc, causing the test to fail. Oversight in ad34146. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/7ff358b76a106

pgsql: Add more TAP tests with BASE_BACKUP and pg_backup_start/stop

2022-07-31 Thread Michael Paquier
Add more TAP tests with BASE_BACKUP and pg_backup_start/stop This commit adds some test coverage for ee79647 (prevent BASE_BACKUP from running in the middle of another base backup) and b24b2be (BASE_BACKUP cancellation followed by pg_backup_start), caused by the interactions of replication and SQL

pgsql: Remove test_oat_hooks.c's nodetag_to_string().

2022-07-31 Thread Tom Lane
Remove test_oat_hooks.c's nodetag_to_string(). In the short time this function has existed, it's already proven to be a nontrivial maintenance burden, since it has to be updated whenever a node tag is added or removed. Although in principle we could now automate that, I see little justification f

pgsql: Remove test_oat_hooks.c's nodetag_to_string().

2022-07-31 Thread Tom Lane
Remove test_oat_hooks.c's nodetag_to_string(). In the short time this function has existed, it's already proven to be a nontrivial maintenance burden, since it has to be updated whenever a node tag is added or removed. Although in principle we could now automate that, I see little justification f

pgsql: Add --schema and --exclude-schema options to vacuumdb.

2022-07-31 Thread Andrew Dunstan
Add --schema and --exclude-schema options to vacuumdb. These two new options can be used to either process all tables in specific schemas or to skip processing all tables in specific schemas. This change also refactors the handling of invalid combinations of command-line options to a new helper f

pgsql: ci: switch to freebsd 13.1

2022-07-31 Thread Andres Freund
ci: switch to freebsd 13.1 freebsd 13.0 is out of support, switch to 13.1. It might be a good idea to remove the minor version number from the image name, but there's not been a response to that so far... Discussion: https://postgr.es/m/[email protected] Backpatch

pgsql: ci: switch to freebsd 13.1

2022-07-31 Thread Andres Freund
ci: switch to freebsd 13.1 freebsd 13.0 is out of support, switch to 13.1. It might be a good idea to remove the minor version number from the image name, but there's not been a response to that so far... Discussion: https://postgr.es/m/[email protected] Backpatch

pgsql: Fix trim_array() for zero-dimensional array argument.

2022-07-31 Thread Tom Lane
Fix trim_array() for zero-dimensional array argument. The code tried to access ARR_DIMS(v)[0] and ARR_LBOUND(v)[0] whether or not those values exist. This made the range check on the "n" argument unstable --- it might or might not fail, and if it did it would report garbage for the allowed upper

pgsql: Fix trim_array() for zero-dimensional array argument.

2022-07-31 Thread Tom Lane
Fix trim_array() for zero-dimensional array argument. The code tried to access ARR_DIMS(v)[0] and ARR_LBOUND(v)[0] whether or not those values exist. This made the range check on the "n" argument unstable --- it might or might not fail, and if it did it would report garbage for the allowed upper

pgsql: Fix trim_array() for zero-dimensional array argument.

2022-07-31 Thread Tom Lane
Fix trim_array() for zero-dimensional array argument. The code tried to access ARR_DIMS(v)[0] and ARR_LBOUND(v)[0] whether or not those values exist. This made the range check on the "n" argument unstable --- it might or might not fail, and if it did it would report garbage for the allowed upper

pgsql: Make new auto_explain test safe for log_error_verbosity = verbos

2022-07-31 Thread Tom Lane
Make new auto_explain test safe for log_error_verbosity = verbose. Allow for the possible presence of a SQLSTATE code in the expected warning message, similarly to b998196bb and 19408aae7 (although here I see no need to allow more than one specific SQLSTATE). Per gripe from Andrew Dunstan. Discus

pgsql: Make new auto_explain test safe for log_error_verbosity = verbos

2022-07-31 Thread Tom Lane
Make new auto_explain test safe for log_error_verbosity = verbose. Allow for the possible presence of a SQLSTATE code in the expected warning message, similarly to b998196bb and 19408aae7 (although here I see no need to allow more than one specific SQLSTATE). Per gripe from Andrew Dunstan. Discus