pgsql: doc: fix wrong tag used in create sequence manual.

2022-08-15 Thread Tatsuo Ishii
doc: fix wrong tag used in create sequence manual. In ref/create_sequence.sgml tag was used for nextval function name. This should have been tag. Author: Noboru Saito Discussion: https://postgr.es/m/CAAM3qnJTDFFfRf5JHJ4AYrNcqXgMmj0pbH0%2Bvm%3DYva%2BpJyGymA%40mail.gmail.com Backpatch-through: 1

pgsql: doc: fix wrong tag used in create sequence manual.

2022-08-15 Thread Tatsuo Ishii
doc: fix wrong tag used in create sequence manual. In ref/create_sequence.sgml tag was used for nextval function name. This should have been tag. Author: Noboru Saito Discussion: https://postgr.es/m/CAAM3qnJTDFFfRf5JHJ4AYrNcqXgMmj0pbH0%2Bvm%3DYva%2BpJyGymA%40mail.gmail.com Backpatch-through: 1

pgsql: doc: fix wrong tag used in create sequence manual.

2022-08-15 Thread Tatsuo Ishii
doc: fix wrong tag used in create sequence manual. In ref/create_sequence.sgml tag was used for nextval function name. This should have been tag. Author: Noboru Saito Discussion: https://postgr.es/m/CAAM3qnJTDFFfRf5JHJ4AYrNcqXgMmj0pbH0%2Bvm%3DYva%2BpJyGymA%40mail.gmail.com Backpatch-through: 1

pgsql: doc: fix wrong tag used in create sequence manual.

2022-08-15 Thread Tatsuo Ishii
doc: fix wrong tag used in create sequence manual. In ref/create_sequence.sgml tag was used for nextval function name. This should have been tag. Author: Noboru Saito Discussion: https://postgr.es/m/CAAM3qnJTDFFfRf5JHJ4AYrNcqXgMmj0pbH0%2Bvm%3DYva%2BpJyGymA%40mail.gmail.com Backpatch-through: 1

pgsql: doc: fix wrong tag used in create sequence manual.

2022-08-15 Thread Tatsuo Ishii
doc: fix wrong tag used in create sequence manual. In ref/create_sequence.sgml tag was used for nextval function name. This should have been tag. Author: Noboru Saito Discussion: https://postgr.es/m/CAAM3qnJTDFFfRf5JHJ4AYrNcqXgMmj0pbH0%2Bvm%3DYva%2BpJyGymA%40mail.gmail.com Backpatch-through: 1

pgsql: doc: fix wrong tag used in create sequence manual.

2022-08-15 Thread Tatsuo Ishii
doc: fix wrong tag used in create sequence manual. In ref/create_sequence.sgml tag was used for nextval function name. This should have been tag. Author: Noboru Saito Discussion: https://postgr.es/m/CAAM3qnJTDFFfRf5JHJ4AYrNcqXgMmj0pbH0%2Bvm%3DYva%2BpJyGymA%40mail.gmail.com Backpatch-through: 1

pgsql: doc: fix wrong tag used in create sequence manual.

2022-08-15 Thread Tatsuo Ishii
doc: fix wrong tag used in create sequence manual. In ref/create_sequence.sgml tag was used for nextval function name. This should have been tag. Author: Noboru Saito Discussion: https://postgr.es/m/CAAM3qnJTDFFfRf5JHJ4AYrNcqXgMmj0pbH0%2Bvm%3DYva%2BpJyGymA%40mail.gmail.com Backpatch-through: 1

pgsql: Fix headerscheck and cpluspluscheck's exit codes.

2022-08-15 Thread Thomas Munro
Fix headerscheck and cpluspluscheck's exit codes. For the benefit of CI, which started running these header check scripts in its CompilerWarnings task in commit 81b9f23c9c8, they should report failure if any individual header failed to compile. Reviewed-by: Andrew Dunstan Reviewed-by: Andres Fre

pgsql: doc: Add unit to pg_shmem_allocations attributes

2022-08-15 Thread Daniel Gustafsson
doc: Add unit to pg_shmem_allocations attributes The unit of size and allocated_size was not documented. Speciyfing the unit is in line with how many other (but not all) system view attributes are documented so fixing by adding the unit which is "bytes". Author: Euler Taveira Reviewed-by: Masah

pgsql: Add missing bad-PGconn guards in libpq entry points.

2022-08-15 Thread Tom Lane
Add missing bad-PGconn guards in libpq entry points. There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSL

pgsql: Add missing bad-PGconn guards in libpq entry points.

2022-08-15 Thread Tom Lane
Add missing bad-PGconn guards in libpq entry points. There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSL

pgsql: Add missing bad-PGconn guards in libpq entry points.

2022-08-15 Thread Tom Lane
Add missing bad-PGconn guards in libpq entry points. There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSL

pgsql: Add missing bad-PGconn guards in libpq entry points.

2022-08-15 Thread Tom Lane
Add missing bad-PGconn guards in libpq entry points. There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSL

pgsql: Add missing bad-PGconn guards in libpq entry points.

2022-08-15 Thread Tom Lane
Add missing bad-PGconn guards in libpq entry points. There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSL

pgsql: Add missing bad-PGconn guards in libpq entry points.

2022-08-15 Thread Tom Lane
Add missing bad-PGconn guards in libpq entry points. There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSL

pgsql: Add missing bad-PGconn guards in libpq entry points.

2022-08-15 Thread Tom Lane
Add missing bad-PGconn guards in libpq entry points. There's a convention that externally-visible libpq functions should check for a NULL PGconn pointer, and fail gracefully instead of crashing. PQflush() and PQisnonblocking() didn't get that memo though. Also add a similar check to PQdefaultSSL

pgsql: Remove redundant spaces in _outA_Expr() output

2022-08-15 Thread Peter Eisentraut
Remove redundant spaces in _outA_Expr() output Since WRITE_NODE_FIELD() output always starts with a space, we don't need to go out of our way to print another space right before it. This change is only for visual appearance; the tokenizer on the reading side would read it the same way (but there