pgsql: Fix macro problem with gai_strerror on Windows.

2022-08-17 Thread Thomas Munro
Fix macro problem with gai_strerror on Windows. Commit 5579388d was confused about why gai_strerror() didn't work, and used gai_strerrorA(). It turns out that we had explicitly undefined Windows' own macro for that somewhere else. Get rid of all that, and use the system headers' definition of ga

pgsql: Remove dead ifaddr.c fallback code.

2022-08-17 Thread Thomas Munro
Remove dead ifaddr.c fallback code. We carried a special implementation of pg_foreach_ifaddr() using Solaris's ioctl(SIOCGLIFCONF), but Solaris 11 and illumos adopted getifaddrs() more than a decade ago, and we prefer to use that. Solaris 10 is EOL'd. Remove the dead code. Adjust comment about

pgsql: mstcpip.h is not missing on MinGW.

2022-08-17 Thread Thomas Munro
mstcpip.h is not missing on MinGW. Remove a small difference between MinGW and MSVC builds which isn't needed for modern MinGW, noticed in passing. Discussion: https://postgr.es/m/ca+hukgkernfhmvb_h0upremp4lpzgn06yr2_0tyikjzb-2e...@mail.gmail.com Branch -- master Details --- https://gi

pgsql: Remove configure probe for netinet/tcp.h.

2022-08-17 Thread Thomas Munro
Remove configure probe for netinet/tcp.h. is in SUSv3 and all targeted Unix systems have it. For Windows, we can provide a stub include file, to avoid some #ifdef noise. Discussion: https://postgr.es/m/ca+hukgkernfhmvb_h0upremp4lpzgn06yr2_0tyikjzb-2e...@mail.gmail.com Branch -- master Det

pgsql: Remove configure probe for sys/sockio.h.

2022-08-17 Thread Thomas Munro
Remove configure probe for sys/sockio.h. On BSD-family systems, header defines socket ioctl numbers like SIOCGIFCONF. Only AIX is using those now, but it defines them in anyway. Supposing some PostgreSQL hacker wants to test that AIX-only code path on a more common development system by preten

pgsql: Remove configure probe for net/if.h.

2022-08-17 Thread Thomas Munro
Remove configure probe for net/if.h. is in SUSv3 and all targeted Unixes have it. It's used in a region that is already ifdef'd out for Windows. We're not using it for any standard definitions, but it's where AIX defines conventional socket ioctl numbers. Discussion: https://postgr.es/m/ca+hu

pgsql: Update comment in gramparse.h

2022-08-17 Thread John Naylor
Update comment in gramparse.h src/common/keywords.c hasn't included this header since afb0d0712. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3f5dbcb5fe0bd68df7e5de5e95e10b3b892c43b2 Modified Files -- src/include/parser/gramparse.h | 2 +- 1 file chan

Re: pgsql: Fix assorted doc typos

2022-08-17 Thread Justin Pryzby
Thanks for taking care of these On Thu, Aug 04, 2022 at 09:11:48AM +, John Naylor wrote: > Fix assorted doc typos > > Erik Rijkers and Justin Pryzby > > Backpatch to v14 > > Discussion: > https://www.postgresql.org/message-id/b79bfeff-d0e3-29a3-2576-0e325848dede%40xs4all.nl > > Branch > -

pgsql: Refer to replication origin roident as "ID" in user facing messa

2022-08-17 Thread John Naylor
Refer to replication origin roident as "ID" in user facing messages and docs The table column that stores this is of type oid, but is actually limited to uint16 and has a different path for creating new values. Some of the documentation already referred to it as an ID, so let's standardize on that

pgsql: Refer to replication origin roident as "ID" in user facing messa

2022-08-17 Thread John Naylor
Refer to replication origin roident as "ID" in user facing messages and docs The table column that stores this is of type oid, but is actually limited to uint16 and has a different path for creating new values. Some of the documentation already referred to it as an ID, so let's standardize on that

pgsql: Fix hypothetical problem passing the wrong GROUP BY pathkeys

2022-08-17 Thread David Rowley
Fix hypothetical problem passing the wrong GROUP BY pathkeys 1349d2790 changed things to make the planner request that the query_pathkeys contain pathkeys for any ORDER BY / DISTINCT aggregates. Some code added prior to that commit in db0d67db2 made it so the order that the pathkeys appear in the

pgsql: doc: Add a note on PO editors

2022-08-17 Thread Daniel Gustafsson
doc: Add a note on PO editors While PO files can be edited in any text editor, specialized tools for translation editing can be quite helpful with automating tasks etc. Add a small note about PO editors to encourage new translators to research which tool works best for them. Reviewed-by: Bruce Mo

pgsql: Refactor addition of PlaceHolderVars to joinrel targetlists.

2022-08-17 Thread Tom Lane
Refactor addition of PlaceHolderVars to joinrel targetlists. Make build_joinrel_tlist() responsible for adding PHVs that were already computed in one or the other input relation, and therefore change add_placeholders_to_joinrel() to only add PHVs that will be newly computed in this joinrel's outpu

pgsql: Use an explicit state flag to control PlaceHolderInfo creation.

2022-08-17 Thread Tom Lane
Use an explicit state flag to control PlaceHolderInfo creation. Up to now, callers of find_placeholder_info() were required to pass a flag indicating if it's OK to make a new PlaceHolderInfo. That'd be fine if the callers had free choice, but they do not. Once we begin deconstruct_jointree() it'

pgsql: Make PlaceHolderInfo lookup O(1).

2022-08-17 Thread Tom Lane
Make PlaceHolderInfo lookup O(1). Up to now we've just searched the placeholder_list when we want to find the PlaceHolderInfo with a given ID. While there's no evidence of that being a problem in the field, an upcoming patch will add find_placeholder_info() calls in build_joinrel_tlist(), which s

pgsql: Avoid using list_length() to test for empty list.

2022-08-17 Thread Tom Lane
Avoid using list_length() to test for empty list. The standard way to check for list emptiness is to compare the List pointer to NIL; our list code goes out of its way to ensure that that is the only representation of an empty list. (An acceptable alternative is a plain boolean test for non-null

pgsql: doc: Consistently spell case-insensitive

2022-08-17 Thread Daniel Gustafsson
doc: Consistently spell case-insensitive While almost all occurrences of "case-insensitive{ly}" were spelled with a dash, a few were using "case insensitive{ly}" with a space instead. Fix by changing these to use a dash to be consistent. Discussion: https://postgr.es/m/7657edee-5ee2-4aab-ba95-47b

pgsql: doc: Document pg_trgm being case-insensitive by default

2022-08-17 Thread Daniel Gustafsson
doc: Document pg_trgm being case-insensitive by default pg_trgm is by default operating case-insensitively but the docs didn't mention that at all. Author: Erik Rijkers Reviewed-by: Tom Lane Reviewed-by: Daniel Gustafsson Reported-by: [email protected] Discussion: https://postgr.es/m