Re: pgsql: Refer to replication origin roident as "ID" in user facing messa

2022-08-18 Thread John Naylor
On Thu, Aug 18, 2022 at 4:49 PM Peter Eisentraut wrote: > > On 18.08.22 04:10, John Naylor wrote: > > While at it, most format strings already use %u, so for consintency > > change the remaining stragglers using %d. > > This is incorrect. Replication origin IDs are of type uint16, which > gets pr

pgsql: doc: Improve some markups and some wording around archiving modu

2022-08-18 Thread Michael Paquier
doc: Improve some markups and some wording around archiving modules This commit adds or fixes used markups in a couple of places in the docs (for , and ). While on it, clarify some of the documentation added recently for archiving modules with archive_command, that would still be used as default

pgsql: doc: Improve some markups and some wording around archiving modu

2022-08-18 Thread Michael Paquier
doc: Improve some markups and some wording around archiving modules This commit adds or fixes markups used in a couple of places in the docs (for , and ). While on it, this clarifies some of the documentation added recently for archiving modules with archive_command, that would still be used as

pgsql: Initialize index stats during parallel VACUUM.

2022-08-18 Thread Peter Geoghegan
Initialize index stats during parallel VACUUM. Initialize shared memory allocated for index stats to avoid a hard crash. This was possible when parallel VACUUM became confused about the current phase of index processing. Oversight in commit 8e1fae1938, which refactored parallel VACUUM. Author:

pgsql: Initialize index stats during parallel VACUUM.

2022-08-18 Thread Peter Geoghegan
Initialize index stats during parallel VACUUM. Initialize shared memory allocated for index stats to avoid a hard crash. This was possible when parallel VACUUM became confused about the current phase of index processing. Oversight in commit 8e1fae1938, which refactored parallel VACUUM. Author:

pgsql: Bump catversion for 6566133c5f52771198aca07ed18f84519fac1be7

2022-08-18 Thread Robert Haas
Bump catversion for 6566133c5f52771198aca07ed18f84519fac1be7 Omission noted by Tom Lane. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9288c2e6f8e6bb523f309dd413af1344962ebc6e Modified Files -- src/include/catalog/catversion.h | 2 +- 1 file changed, 1

Re: pgsql: Ensure that pg_auth_members.grantor is always valid.

2022-08-18 Thread Robert Haas
On Thu, Aug 18, 2022 at 2:22 PM Tom Lane wrote: > Robert Haas writes: > > Ensure that pg_auth_members.grantor is always valid. > > Surely this requires a catversion bump. Ugh, sorry. -- Robert Haas EDB: http://www.enterprisedb.com

Re: pgsql: Ensure that pg_auth_members.grantor is always valid.

2022-08-18 Thread Tom Lane
Robert Haas writes: > Ensure that pg_auth_members.grantor is always valid. Surely this requires a catversion bump. regards, tom lane

pgsql: Don't add HAVE_LDAP_H HAVE_WINLDAP_H to pg_config.h

2022-08-18 Thread Andres Freund
Don't add HAVE_LDAP_H HAVE_WINLDAP_H to pg_config.h They're not referenced, so we don't need them in in pg_config.h. Reviewed-by: Peter Eisentraut Discussion: http://postgr.es/m/[email protected] Branch -- master Details --- https://git.postgresql.o

pgsql: Ensure that pg_auth_members.grantor is always valid.

2022-08-18 Thread Robert Haas
Ensure that pg_auth_members.grantor is always valid. Previously, "GRANT foo TO bar" or "GRANT foo TO bar GRANTED BY baz" would record the OID of the grantor in pg_auth_members.grantor, but that role could later be dropped without modifying or removing the pg_auth_members record. That's not great,

pgsql: Improve performance of adjust_appendrel_attrs_multilevel.

2022-08-18 Thread Tom Lane
Improve performance of adjust_appendrel_attrs_multilevel. The present implementations of adjust_appendrel_attrs_multilevel and its sibling adjust_child_relids_multilevel are very messy, because they work by reconstructing the relids of the child's immediate parent and then seeing if that's bms_equ

pgsql: Adjust assertion in XLogDecodeNextRecord.

2022-08-18 Thread Robert Haas
Adjust assertion in XLogDecodeNextRecord. As written, if you use XLogBeginRead() to position an xlogreader at the beginning of a WAL page and then try to read WAL, this assertion will fail. However, the header comment for XLogBeginRead() claims that positioning an xlogreader at the beginning of a

pgsql: Fix subtly-incorrect matching of parent and child partitioned in

2022-08-18 Thread Tom Lane
Fix subtly-incorrect matching of parent and child partitioned indexes. When creating a partitioned index, DefineIndex tries to identify any existing indexes on the partitions that match the partitioned index, so that it can absorb those as child indexes instead of building new ones. Part of the m

pgsql: Fix subtly-incorrect matching of parent and child partitioned in

2022-08-18 Thread Tom Lane
Fix subtly-incorrect matching of parent and child partitioned indexes. When creating a partitioned index, DefineIndex tries to identify any existing indexes on the partitions that match the partitioned index, so that it can absorb those as child indexes instead of building new ones. Part of the m

pgsql: Fix subtly-incorrect matching of parent and child partitioned in

2022-08-18 Thread Tom Lane
Fix subtly-incorrect matching of parent and child partitioned indexes. When creating a partitioned index, DefineIndex tries to identify any existing indexes on the partitions that match the partitioned index, so that it can absorb those as child indexes instead of building new ones. Part of the m

pgsql: Fix subtly-incorrect matching of parent and child partitioned in

2022-08-18 Thread Tom Lane
Fix subtly-incorrect matching of parent and child partitioned indexes. When creating a partitioned index, DefineIndex tries to identify any existing indexes on the partitions that match the partitioned index, so that it can absorb those as child indexes instead of building new ones. Part of the m

pgsql: Fix subtly-incorrect matching of parent and child partitioned in

2022-08-18 Thread Tom Lane
Fix subtly-incorrect matching of parent and child partitioned indexes. When creating a partitioned index, DefineIndex tries to identify any existing indexes on the partitions that match the partitioned index, so that it can absorb those as child indexes instead of building new ones. Part of the m

pgsql: Fix subtly-incorrect matching of parent and child partitioned in

2022-08-18 Thread Tom Lane
Fix subtly-incorrect matching of parent and child partitioned indexes. When creating a partitioned index, DefineIndex tries to identify any existing indexes on the partitions that match the partitioned index, so that it can absorb those as child indexes instead of building new ones. Part of the m

pgsql: When using the WAL-logged CREATE DATABASE strategy, bulk extend.

2022-08-18 Thread Robert Haas
When using the WAL-logged CREATE DATABASE strategy, bulk extend. This should improve performance, and was suggested by Andres Freund. Back-patch to v15 to keep the code consistent across branches. Dilip Kumar Discussion: http://postgr.es/m/[email protected] Discuss

pgsql: When using the WAL-logged CREATE DATABASE strategy, bulk extend.

2022-08-18 Thread Robert Haas
When using the WAL-logged CREATE DATABASE strategy, bulk extend. This should improve performance, and was suggested by Andres Freund. Back-patch to v15 to keep the code consistent across branches. Dilip Kumar Discussion: http://postgr.es/m/[email protected] Discuss

pgsql: Remove unused configure variable.

2022-08-18 Thread Tom Lane
Remove unused configure variable. configure extracts TCL_SHLIB_LD_LIBS from tclConfig.sh, and puts the value into Makefile.global, but then we never use it anywhere. It looks like I removed the only usage in cd75f94da, but didn't notice that it was the only usage. Might as well mop this up while

pgsql: Simplify and clarify an error message

2022-08-18 Thread Peter Eisentraut
Simplify and clarify an error message Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9c4c22fdfeab86a65fdba9d2fe63879c034001ae Modified Files -- src/backend/commands/copyfromparse.c | 2 +- src/test/regress/expected/copy.out | 8 2 files

pgsql: Simplify and clarify an error message

2022-08-18 Thread Peter Eisentraut
Simplify and clarify an error message Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/08909e3aee6182a988da5bf5c1b543910ee096c7 Modified Files -- src/backend/commands/copyfromparse.c | 2 +- src/test/regress/expected/copy.out | 8 2 files changed

Re: pgsql: Refer to replication origin roident as "ID" in user facing messa

2022-08-18 Thread Peter Eisentraut
On 18.08.22 04:10, John Naylor wrote: While at it, most format strings already use %u, so for consintency change the remaining stragglers using %d. This is incorrect. Replication origin IDs are of type uint16, which gets promoted to int in a variable arguments list, so %d is the correct plac