Hi,
On 2022-09-15 10:52:31 +0700, John Naylor wrote:
> On Thu, Sep 15, 2022 at 4:04 AM Andres Freund wrote:
> >
> > The most general solution I can see would be
> >
> > diff --git i/src/backend/common.mk w/src/backend/common.mk
> > index fa96a82b1a0..61861f5c7eb 100644
> > --- i/src/backend/commo
Bharath Rupireddy writes:
> We seem to be maintaining old code in pg_upgrade to not break it, see
> [3]. I can think of a fix [4] or just [5], it may not be great to do
> these kinds of fixes for all the pg_resetwal output changes. Since the
> changes we make to the output formats of controlfile o
Fix grammar in error message
While at it, make ellipses formatting consistent when describing SQL statements.
Ekaterina Kiryanova and Alexander Lakhin
Reviewed by myself and Álvaro Herrera
Discussion:
https://www.postgresql.org/message-id/eed5cec0-a542-53da-6a5e-7789c6ed9817%40postgrespro.ru
Ba
Fix grammar in error message
While at it, make ellipses formatting consistent when describing SQL statements.
Ekaterina Kiryanova and Alexander Lakhin
Reviewed by myself and Álvaro Herrera
Discussion:
https://www.postgresql.org/message-id/eed5cec0-a542-53da-6a5e-7789c6ed9817%40postgrespro.ru
Ba
On Thu, Sep 15, 2022 at 7:08 AM Tom Lane wrote:
>
> Andrew Dunstan writes:
> > The pg_upgrade part of this seems seriously awry (see buildfarm animal
> > crake). We can't assume that the upgrade source is using the new wording.
>
> Ugh. I'll look into a fix tomorrow --- but my first instinct is
Blind attempt to fix LLVM dependency in the backend
Commit ecaf7c5df5 removed gram.h from the backend's generated-headers
target. In LLVM builds, this leads to loss of dependency information
when generating .bc files. To fix, add a rule that mirrors ad-hoc .o
dependencies for .bc files as well.
P
On Thu, Sep 15, 2022 at 4:04 AM Andres Freund wrote:
>
> The most general solution I can see would be
>
> diff --git i/src/backend/common.mk w/src/backend/common.mk
> index fa96a82b1a0..61861f5c7eb 100644
> --- i/src/backend/common.mk
> +++ w/src/backend/common.mk
> @@ -23,6 +23,7 @@ objfiles.txt:
Andrew Dunstan writes:
> The pg_upgrade part of this seems seriously awry (see buildfarm animal
> crake). We can't assume that the upgrade source is using the new wording.
Ugh. I'll look into a fix tomorrow --- but my first instinct is
that pg_upgrade shouldn't be so dependent on the exact wordi
On 2022-09-14 We 18:41, Tom Lane wrote:
> Use the terminology "WAL file" not "log file" more consistently.
>
> Referring to the WAL as just "log" invites confusion with the
> postmaster log, so avoid doing that in docs and error messages.
> Also shorten "WAL segment file" to just "WAL file" in va
Use the terminology "WAL file" not "log file" more consistently.
Referring to the WAL as just "log" invites confusion with the
postmaster log, so avoid doing that in docs and error messages.
Also shorten "WAL segment file" to just "WAL file" in various
places.
Bharath Rupireddy, reviewed by Natha
Fix outdated convert_saop_to_hashed_saop comment
In 29f45e299, we added support for optimizing the execution of NOT
IN(values) by using a hash table instead of a linear search over the
array. That commit neglected to update the header comment for
convert_saop_to_hashed_saop() to mention this fact
Fix outdated convert_saop_to_hashed_saop comment
In 29f45e299, we added support for optimizing the execution of NOT
IN(values) by using a hash table instead of a linear search over the
array. That commit neglected to update the header comment for
convert_saop_to_hashed_saop() to mention this fact
Hi,
On 2022-09-14 13:57:15 -0700, Andres Freund wrote:
> On 2022-09-14 15:37:06 -0400, Tom Lane wrote:
> > John Naylor writes:
> > > Move gramparse.h to src/backend/parser
> >
> > The cfbot is unhappy since this commit; some but not all tests fail with
> >
> > [09:33:13.793] In file included from
Small wording improvements
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/111d954024c8f4e6d8d273d8e7c1d64d14435bf5
Modified Files
--
doc/src/sgml/config.sgml| 2 +-
src/backend/utils/misc/guc_tables.c | 2 +-
2 files changed, 2 insertions(+),
Small wording improvements
Branch
--
REL_15_STABLE
Details
---
https://git.postgresql.org/pg/commitdiff/12a5214df4b784e793958c931c07836606efac9b
Modified Files
--
doc/src/sgml/config.sgml | 2 +-
src/backend/utils/misc/guc.c | 2 +-
2 files changed, 2 insertions(+), 2 delet
Hi,
On 2022-09-14 15:37:06 -0400, Tom Lane wrote:
> John Naylor writes:
> > Move gramparse.h to src/backend/parser
>
> The cfbot is unhappy since this commit; some but not all tests fail with
>
> [09:33:13.793] In file included from scan.c:39:
> [09:33:13.793] ./gramparse.h:29:10: fatal error:
On Wed, Sep 14, 2022 at 1:20 PM Peter Eisentraut
wrote:
> According to the surrounding math in each case, this means that the new
> %u is larger by %d than the previous value.
>
> The use of "ahead of" had confused me here, since I needed to think
> three times about which direction is meant. I s
Doc: add some doco about using the libpq_pipeline test module.
The README file here was barely a stub. Try to make it useful.
Jelte Fennema, with some further work by me
Discussion:
https://postgr.es/m/am5pr83mb0178d3b31ca1b6ec4a8ecc42f7...@am5pr83mb0178.eurprd83.prod.outlook.com
Branch
-
On 12.02.22 01:49, Peter Geoghegan wrote:
Add VACUUM instrumentation for scanned pages, relfrozenxid.
This patch introduced the log messages
"new relfrozenxid: %u, which is %d XIDs ahead of previous value\n"
"new relminmxid: %u, which is %d MXIDs ahead of previous value\n"
According
pgcrypto: Remove unused code
The mbuf_tell, mbuf_rewind and pgp_get_cipher_name functions were
introduced in commit e94dd6ab91, but were never used, so remove.
Reviewed-by: Aleksander Alekseev
Discussion: https://postgr.es/m/fcf3f14e-17d5-41f2-ac58-0a97b3411...@yesql.se
Branch
--
master
De
Update .gitignore
Add entry for ab393528fa4b2486237ee7aa51fac67f82fee824. Remove one
obsolete entry.
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/5f84647ee1b25532cf5ea06801a4f36706a0cb96
Modified Files
--
doc/src/sgml/.gitignore | 2 +-
1 file change
John Naylor writes:
> Move gramparse.h to src/backend/parser
The cfbot is unhappy since this commit; some but not all tests fail with
[09:33:13.793] In file included from scan.c:39:
[09:33:13.793] ./gramparse.h:29:10: fatal error: 'gram.h' file not found
[09:33:13.794] #include "gram.h"
[09:33:1
Use SIGNAL_ARGS consistently to declare signal handlers.
Various bits of code were declaring signal handlers manually,
using "int signum" or variants of that. We evidently have no
platforms where that's actually wrong, but let's use our
SIGNAL_ARGS macro everywhere anyway. If nothing else, it's
> On 14 Sep 2022, at 17:37, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> On 14 Sep 2022, at 17:06, Tom Lane wrote:
>>> barring objection,
>>> I'm going to run around and fix those.
>
>> No objections, unless you have better things to do and wan't me to clean up
>> then I'll take care of it
Run xmllint validation only once
Before, each documentation target that built something from
postgres.sgml ran xmllint first to validate the input. Here, we
change it so that the validation only runs once and produces an output
file, and all the other targets build from that output file. This
av
On 14.09.22 06:49, Andres Freund wrote:
I don't see any mention of the --check option in the postgres man page.
That should be added.
IIRC we discussed that at some point and considered it a sufficiently
internal option that documenting it in user facing docs doesn't seem useful.
Ok, I s
Daniel Gustafsson writes:
> On 14 Sep 2022, at 17:06, Tom Lane wrote:
>> barring objection,
>> I'm going to run around and fix those.
> No objections, unless you have better things to do and wan't me to clean up
> then I'll take care of it.
Nah, not your bug. There are a bunch of these, I'm fi
> On 14 Sep 2022, at 17:06, Tom Lane wrote:
>
> Daniel Gustafsson writes:
>> Since pg_recvlogical is also supposed to run as a daemon, teach it about
>> SIGTERM as well and update the documentation to match. While in there,
>> change pg_receivewal's time_to_stop to be sig_atomic_t like it is in
Daniel Gustafsson writes:
> Since pg_recvlogical is also supposed to run as a daemon, teach it about
> SIGTERM as well and update the documentation to match. While in there,
> change pg_receivewal's time_to_stop to be sig_atomic_t like it is in
> pg_recvlogical.
While looking at this commit, I w
Handle SIGTERM in pg_receivewal and pg_recvlogical
In pg_receivewal, compressed output is only flushed on clean exits. The
reason to support SIGTERM as well as SIGINT (which is currently handled)
is that pg_receivewal might well be running as a daemon, and systemd's
default KillSignal is SIGTERM.
Add subxid-overflow "isolation" test
This test covers a few lines of subxid-overflow-handling code in various
part of the backend, which are otherwise uncovered.
Author: Simon Riggs
Reviewed-by: Dilip Kumar
Discussion:
https://postgr.es/m/canbhv-h8ov5+ncmbyqfkho+uzjjrfgy_orimwr3rhs4+x44...@mai
Remove duplicate initialization
This appears to be a merge mistake in 96ef3237bf74. We could put it
back the way it was before JSON_TABLE and it'd be two lines shorter, but
it's likely that JSON_TABLE will be back and will prefer things this
way. It makes no other difference in practice.
Backpa
Remove duplicate initialization
This appears to be a merge mistake in 96ef3237bf74. We could put it
back the way it was before JSON_TABLE and it'd be two lines shorter, but
it's likely that JSON_TABLE will be back and will prefer things this
way. It makes no other difference in practice.
Backpa
postgres_fdw: Avoid 'variable not found in subplan target list' error.
The tlist of the EvalPlanQual outer plan for a ForeignScan node is
adjusted to produce a tuple whose descriptor matches the scan tuple slot
for the ForeignScan node. But in the case where the outer plan contains
an extra Sort
postgres_fdw: Avoid 'variable not found in subplan target list' error.
The tlist of the EvalPlanQual outer plan for a ForeignScan node is
adjusted to produce a tuple whose descriptor matches the scan tuple slot
for the ForeignScan node. But in the case where the outer plan contains
an extra Sort
postgres_fdw: Avoid 'variable not found in subplan target list' error.
The tlist of the EvalPlanQual outer plan for a ForeignScan node is
adjusted to produce a tuple whose descriptor matches the scan tuple slot
for the ForeignScan node. But in the case where the outer plan contains
an extra Sort
postgres_fdw: Avoid 'variable not found in subplan target list' error.
The tlist of the EvalPlanQual outer plan for a ForeignScan node is
adjusted to produce a tuple whose descriptor matches the scan tuple slot
for the ForeignScan node. But in the case where the outer plan contains
an extra Sort
postgres_fdw: Avoid 'variable not found in subplan target list' error.
The tlist of the EvalPlanQual outer plan for a ForeignScan node is
adjusted to produce a tuple whose descriptor matches the scan tuple slot
for the ForeignScan node. But in the case where the outer plan contains
an extra Sort
postgres_fdw: Avoid 'variable not found in subplan target list' error.
The tlist of the EvalPlanQual outer plan for a ForeignScan node is
adjusted to produce a tuple whose descriptor matches the scan tuple slot
for the ForeignScan node. But in the case where the outer plan contains
an extra Sort
postgres_fdw: Avoid 'variable not found in subplan target list' error.
The tlist of the EvalPlanQual outer plan for a ForeignScan node is
adjusted to produce a tuple whose descriptor matches the scan tuple slot
for the ForeignScan node. But in the case where the outer plan contains
an extra Sort
Fix failure to build gramparse.h standalone in vpath builds
Add include directory in a similar fashion as 829906fb6c.
Per buildfarm animal crake
Branch
--
master
Details
---
https://git.postgresql.org/pg/commitdiff/b0526d271d16d54064666d30bbfa53d4f335c66d
Modified Files
--
41 matches
Mail list logo
