Detect format-string mistakes in the libpq_pipeline test module.
I happened to notice that libpq_pipeline's private implementation
of pg_fatal lacked any pg_attribute_printf decoration. Indeed,
adding that turned up a mistake! We'd likely never have noticed
because the error exits in this code a
Detect format-string mistakes in the libpq_pipeline test module.
I happened to notice that libpq_pipeline's private implementation
of pg_fatal lacked any pg_attribute_printf decoration. Indeed,
adding that turned up a mistake! We'd likely never have noticed
because the error exits in this code a
Detect format-string mistakes in the libpq_pipeline test module.
I happened to notice that libpq_pipeline's private implementation
of pg_fatal lacked any pg_attribute_printf decoration. Indeed,
adding that turned up a mistake! We'd likely never have noticed
because the error exits in this code a
Hi,
On 2022-09-15 16:48:04 -0400, Tom Lane wrote:
> Andres Freund writes:
> > On 2022-09-13 22:45:46 -0400, Tom Lane wrote:
> >> A three-line patch doesn't seem like an unreasonable thing to carry,
> >> at least till these systems go out of support. We've jumped through
> >> much higher hoops in
Andres Freund writes:
> On 2022-09-13 22:45:46 -0400, Tom Lane wrote:
>> A three-line patch doesn't seem like an unreasonable thing to carry,
>> at least till these systems go out of support. We've jumped through
>> much higher hoops in the past to support niche platforms.
> xlc 12.1 *is* out of
Andres Freund writes:
> pgstat: add/extend tests for resetting various kinds of stats.
crake just failed [1] with what appears to be a race condition in
a test case added by this commit:
diff -U3 /home/andrew/bf/root/HEAD/pgsql/src/test/regress/expected/stats.out
/home/andrew/bf/root/HEAD/pgsql
Hi,
On 2022-09-13 22:45:46 -0400, Tom Lane wrote:
> Andres Freund writes:
> > So we could work around the xlc 12.1 issue with something like the attached
> > patch. It passes at some of the tests, with both 32 and 64bit xlc 12.1, will
> > have to wait a while to see more
>
> Shouldn't that be mor
In back branches, fix conditions for pullup of FROM-less subqueries.
In branches before commit 4be058fe9, we have to prevent flattening
of subqueries with empty jointrees if the subqueries' output
columns might need to be wrapped in PlaceHolderVars. That's
because the empty jointree would result
In back branches, fix conditions for pullup of FROM-less subqueries.
In branches before commit 4be058fe9, we have to prevent flattening
of subqueries with empty jointrees if the subqueries' output
columns might need to be wrapped in PlaceHolderVars. That's
because the empty jointree would result
Copy-edit docs for logical replication column lists
There was a excessive structure, leading to somewhat disorganized
presentation of the information. Remove a few tags and reorder
paragraphs to make the text flow more easily. Also, reword some of it
to be more concise.
The bit about column list
Copy-edit docs for logical replication column lists
There was a excessive structure, leading to somewhat disorganized
presentation of the information. Remove a few tags and reorder
paragraphs to make the text flow more easily. Also, reword some of it
to be more concise.
The bit about column list
Revert ill-considered change in pg_resetwal output.
Commit 31dcfae83 changed one pg_resetwal output string, and a
corresponding test in pg_upgrade, without sufficient thought for
the consequences. We can't change that output without creating
hazards for cross-version upgrades, since pg_upgrade ne
Bharath Rupireddy writes:
> Thanks for pointing it out. It seems like a good idea IMO. I think
> pg_resetwal also needs the --machine approach. As --machine approach
> needs a good amount of refactoring and discussion, I still think we
> can make buildfarm happy by fixing a proposed solution [1].
Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit.
After commit cc2c7d65fc27e877c9f407587b0b92d46cd6dd16 added this flag,
failure to reset it caused assertion failures. In non-assert builds, it
made the system fail to achieve the objectives listed in that commit;
chiefly, w
Reset InstallXLogFileSegmentActive after walreceiver self-initiated exit.
After commit cc2c7d65fc27e877c9f407587b0b92d46cd6dd16 added this flag,
failure to reset it caused assertion failures. In non-assert builds, it
made the system fail to achieve the objectives listed in that commit;
chiefly, w
On Thu, Sep 15, 2022 at 2:54 PM Alvaro Herrera wrote:
>
> On 2022-Sep-15, Tom Lane wrote:
>
> > Yeah, the lowest-tech solution is to accept either spelling of
> > the description string. But I'm not very happy with the whole
> > approach right now. We should have an implementation that isn't
> >
On 9/15/22 05:24, Alvaro Herrera wrote:
On 2022-Sep-15, Tom Lane wrote:
Yeah, the lowest-tech solution is to accept either spelling of
the description string. But I'm not very happy with the whole
approach right now. We should have an implementation that isn't
dependent on how user-friendly s
On 2022-Sep-15, Tom Lane wrote:
> Yeah, the lowest-tech solution is to accept either spelling of
> the description string. But I'm not very happy with the whole
> approach right now. We should have an implementation that isn't
> dependent on how user-friendly strings are spelled.
We already dis
18 matches
Mail list logo