pgsql: Fix some comments of do_pg_backup_start() and do_pg_backup_stop(

2022-09-27 Thread Michael Paquier
Fix some comments of do_pg_backup_start() and do_pg_backup_stop() Both functions referred to an incorrect variable name, so make the whole more consistent. Oversight in 7d70809. Author: Kyotaro Horiguchi, Bharath Rupireddy Discussion:

pgsql: Tag refs/tags/REL_15_RC1 was created

2022-09-27 Thread noreply
Tag refs/tags/REL_15_RC1 was created.

pgsql: In BufTagGetForkNum, cast to the correct type.

2022-09-27 Thread Robert Haas
In BufTagGetForkNum, cast to the correct type. Another defect in 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c. Per CI, via Justin Pryzby. Discussion: http://postgr.es/m/20220927200712.gh6...@telsasoft.com Branch -- master Details ---

pgsql: Update pg_buffercache's meson.build.

2022-09-27 Thread Robert Haas
Update pg_buffercache's meson.build. Commit 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c needed to do this, but didn't. Per Justin Pryzby. Discussion: 20220927191710.gg6...@telsasoft.com Branch -- master Details ---

pgsql: Fix typos in commit 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c.

2022-09-27 Thread Robert Haas
Fix typos in commit 05d4cbf9b6ba708858984b01ca0fc56d59d4ec7c. Reported by Justin Pryzby. Discussion: http://postgr.es/m/20220927185121.ge6...@telsasoft.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/4667d97ca624b257f690e8d369b242b380f53a09 Modified Files

pgsql: Convert *GetDatum() and DatumGet*() macros to inline functions

2022-09-27 Thread Peter Eisentraut
Convert *GetDatum() and DatumGet*() macros to inline functions The previous macro implementations just cast the argument to a target type but did not check whether the input type was appropriate. The function implementation can do better type checking of the input type. For the *GetDatumFast()

Re: pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits.

2022-09-27 Thread Justin Pryzby
This seems to be breaking cfbot: https://cirrus-ci.com/github/postgresql-cfbot/postgresql For example: https://cirrus-ci.com/task/6720256776339456 Some other minor issues: thais is only used during => this + elog(ERROR, "unexpected relnumber " UINT64_FORMAT "that is

pgsql: Include common/relpath.h in utils/relfilenumbermap.h

2022-09-27 Thread Robert Haas
Include common/relpath.h in utils/relfilenumbermap.h Buildfarm member crake ran headerscheck, which complained about a missing include here. Defect introduced by commit 2f47715cc8649f854b1df28dfc338af9801db217. Branch -- master Details ---

pgsql: Increase width of RelFileNumbers from 32 bits to 56 bits.

2022-09-27 Thread Robert Haas
Increase width of RelFileNumbers from 32 bits to 56 bits. RelFileNumbers are now assigned using a separate counter, instead of being assigned from the OID counter. This counter never wraps around: if all 2^56 possible RelFileNumbers are used, an internal error occurs. As the cluster is limited to

pgsql: Move RelFileNumber declarations to common/relpath.h.

2022-09-27 Thread Robert Haas
Move RelFileNumber declarations to common/relpath.h. Previously, these were declared in postgres_ext.h, but they are not needed nearly so widely as the OID declarations, so that doesn't necessarily make sense. Also, because postgres_ext.h is included before most of c.h has been processed, the

pgsql: Introduce GUC_NO_RESET flag.

2022-09-27 Thread Tom Lane
Introduce GUC_NO_RESET flag. Previously, the transaction-property GUCs such as transaction_isolation could be reset after starting a transaction, because we marked them as GUC_NO_RESET_ALL but still allowed a targeted RESET. That leads to assertion failures or worse, because those properties

pgsql: Renumber GUC flags for a bit more sanity.

2022-09-27 Thread Tom Lane
Renumber GUC flags for a bit more sanity. Push the units fields over to the left so that all the single-bit flags can be together. I considered rearranging the single-bit flags to try to group flags with similar purposes, but eventually decided that that involved too many judgment calls.

Re: pgsql: Improve some publication-related error messages

2022-09-27 Thread Tom Lane
Alvaro Herrera writes: > My mistake. I thought I had seen the tag -committers message go by, but > I must have been confused with the stamp one. Nope, the 24-hour window for packager complaints still has 7 or so hours to run. BTW, maybe you know something about this --- lately, it seems like

Re: pgsql: Improve some publication-related error messages

2022-09-27 Thread Alvaro Herrera
On 2022-Sep-27, Tom Lane wrote: > Alvaro Herrera writes: > > Improve some publication-related error messages > > This is really not the sort of stuff to be pushing during a release > freeze. My mistake. I thought I had seen the tag -committers message go by, but I must have been confused with

Re: pgsql: Improve some publication-related error messages

2022-09-27 Thread Tom Lane
Alvaro Herrera writes: > Improve some publication-related error messages This is really not the sort of stuff to be pushing during a release freeze. regards, tom lane

pgsql: Improve some publication-related error messages

2022-09-27 Thread Alvaro Herrera
Improve some publication-related error messages While at it, remove an unused queryString parameter from CheckPubRelationColumnList() and make other minor stylistic changes. Backpatch to 15. Reported by Kyotaro Horiguchi Co-authored-by: Hou zj Discussion:

pgsql: Improve some publication-related error messages

2022-09-27 Thread Alvaro Herrera
Improve some publication-related error messages While at it, remove an unused queryString parameter from CheckPubRelationColumnList() and make other minor stylistic changes. Backpatch to 15. Reported by Kyotaro Horiguchi Co-authored-by: Hou zj Discussion:

pgsql: Fix pg_stat_statements for MERGE

2022-09-27 Thread Alvaro Herrera
Fix pg_stat_statements for MERGE We weren't jumbling the merge action list, so wildly different commands would be considered to use the same query ID. Add that, mention it in the docs, and some test lines. Backpatch to 15. Author: Tatsu Reviewed-by: Julien Rouhaud Discussion:

pgsql: Fix pg_stat_statements for MERGE

2022-09-27 Thread Alvaro Herrera
Fix pg_stat_statements for MERGE We weren't jumbling the merge action list, so wildly different commands would be considered to use the same query ID. Add that, mention it in the docs, and some test lines. Backpatch to 15. Author: Tatsu Reviewed-by: Julien Rouhaud Discussion: