pgsql: autoconf: Rely on ar supporting index creation

2022-10-07 Thread Andres Freund
autoconf: Rely on ar supporting index creation This way we don't need RANLIB anymore, making it a bit simpler for the meson build to generate Makefile.global for PGXS compatibility. FreeBSD, NetBSD, OpenBSD, the only platforms where we didn't use AROPT=crs, all have supported the 's' option for a

Re: pgsql: Remove unnecessary uses of Abs()

2022-10-07 Thread Tom Lane
Peter Eisentraut writes: > fsec is of type fsec_t, which is int32. So these expressions are > integer all the way through. Ah, okay. My instincts were leftover from a time when it could have been float8. Sorry for the noise. regards, tom lane

Re: pgsql: Remove unnecessary uses of Abs()

2022-10-07 Thread Peter Eisentraut
On 07.10.22 16:38, Tom Lane wrote: Peter Eisentraut writes: Remove unnecessary uses of Abs() Re-reading this, I noticed something that's probably not good: in ecpg/pgtypeslib/interval.c you did - sprintf(cp, "%02d.%0*d", abs(sec), precision, (int) Abs(fsec)); + sprintf(cp

pgsql: Fix self-referencing foreign keys with partitioned tables

2022-10-07 Thread Alvaro Herrera
Fix self-referencing foreign keys with partitioned tables There are a number of bugs in this area. Two of them are fixed here, namely: 1. get_relation_idx_constraint_oid does not restrict the type of constraint that's returned, so with sufficient bad luck it can return the OID of a foreign

pgsql: Fix self-referencing foreign keys with partitioned tables

2022-10-07 Thread Alvaro Herrera
Fix self-referencing foreign keys with partitioned tables There are a number of bugs in this area. Two of them are fixed here, namely: 1. get_relation_idx_constraint_oid does not restrict the type of constraint that's returned, so with sufficient bad luck it can return the OID of a foreign

pgsql: Fix self-referencing foreign keys with partitioned tables

2022-10-07 Thread Alvaro Herrera
Fix self-referencing foreign keys with partitioned tables There are a number of bugs in this area. Two of them are fixed here, namely: 1. get_relation_idx_constraint_oid does not restrict the type of constraint that's returned, so with sufficient bad luck it can return the OID of a foreign

pgsql: Fix self-referencing foreign keys with partitioned tables

2022-10-07 Thread Alvaro Herrera
Fix self-referencing foreign keys with partitioned tables There are a number of bugs in this area. Two of them are fixed here, namely: 1. get_relation_idx_constraint_oid does not restrict the type of constraint that's returned, so with sufficient bad luck it can return the OID of a foreign

pgsql: Fix self-referencing foreign keys with partitioned tables

2022-10-07 Thread Alvaro Herrera
Fix self-referencing foreign keys with partitioned tables There are a number of bugs in this area. Two of them are fixed here, namely: 1. get_relation_idx_constraint_oid does not restrict the type of constraint that's returned, so with sufficient bad luck it can return the OID of a foreign

Re: pgsql: Remove unnecessary uses of Abs()

2022-10-07 Thread Tom Lane
Peter Eisentraut writes: > Remove unnecessary uses of Abs() Re-reading this, I noticed something that's probably not good: in ecpg/pgtypeslib/interval.c you did - sprintf(cp, "%02d.%0*d", abs(sec), precision, (int) Abs(fsec)); + sprintf(cp, "%02d.%0*d", abs(sec), precision, a

pgsql: Convert macros to static inline functions (rel.h)

2022-10-07 Thread Peter Eisentraut
Convert macros to static inline functions (rel.h) Reviewed-by: Amul Sul Discussion: https://www.postgresql.org/message-id/flat/5b558da8-99fb-0a99-83dd-f72f05388517%40enterprisedb.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/3edc71ec043865c735cc7cd67df1c0e21

pgsql: Remove unnecessary uses of Abs()

2022-10-07 Thread Peter Eisentraut
Remove unnecessary uses of Abs() Use C standard abs() or fabs() instead. Reviewed-by: Zhang Mingli Reviewed-by: Tom Lane Discussion: https://www.postgresql.org/message-id/flat/4beb42b5-216b-bce8-d452-d924d5794c63%40enterprisedb.com Branch -- master Details --- https://git.postgresql.