pgsql: Remove unneeded include in test_slru.c

2022-11-16 Thread Michael Paquier
Remove unneeded include in test_slru.c As introduced in 006b69f, the order of the headers was incorrect. However, it happens that lwlock.h can just be dropped from the list, so let's be clean and remove it, fixing the order of the listed headers. Branch -- master Details --- https://git.

pgsql: Export with_icu when running src/bin/scripts tests with meson

2022-11-16 Thread Peter Eisentraut
Export with_icu when running src/bin/scripts tests with meson Author: Marina Polyakova Discussion: https://www.postgresql.org/message-id/flat/[email protected] Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/1d87037ac84606a5bd0c2cd95e

pgsql: Update some more ObjectType switch statements to not have defaul

2022-11-16 Thread Peter Eisentraut
Update some more ObjectType switch statements to not have default This allows the compiler to complain if a case has been missed. In these instances, the tradeoff of having to list a few unneeded cases to silence the compiler seems better than the risk of actually missing one. Discussion: https

pgsql: Improve ruleutils' printout of LATERAL references within subplan

2022-11-16 Thread Tom Lane
Improve ruleutils' printout of LATERAL references within subplans. Commit 1cc29fe7c, which taught EXPLAIN to print PARAM_EXEC Params as the referenced expressions, included some checks to prevent matching Params found in SubPlans or InitPlans to NestLoopParams of upper query levels. At the time,

pgsql: Fix slowdown in TAP tests due to recent walreceiver change.

2022-11-16 Thread Thomas Munro
Fix slowdown in TAP tests due to recent walreceiver change. Commit 05a7be93 changed the timing of the first reply sent by a walreceiver, which caused a few TAP tests that call wait_for_catchup() when they haven't actually streamed anything yet to wait ~10 seconds (wal_receiver_status_interval). B

pgsql: Invent "multibitmapsets", and use them to speed up antijoin dete

2022-11-16 Thread Tom Lane
Invent "multibitmapsets", and use them to speed up antijoin detection. Implement a data structure that is a List of Bitmapsets, which is essentially a 2-D boolean array except that the rows need not all be the same width. Operations such as union and intersection are meaningful for these, just as

pgsql: Add missing object classes to object_address test

2022-11-16 Thread Peter Eisentraut
Add missing object classes to object_address test Per the comment, fill in classes mentioned in getObjectIdentityParts() but not in the test. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/90e4f308b42b12bd66262c52fc4845bd0443c6e0 Modified Files -- src/

pgsql: Shave some cycles off subscription/t/100_bugs.pl tests.

2022-11-16 Thread Tom Lane
Shave some cycles off subscription/t/100_bugs.pl tests. We can re-use the clusters set up for this test script's first test, instead of generating new ones. On my machine this is good for about a 20% reduction in this script's runtime, from ~6.5 sec to ~5.2 sec. This idea could be taken further,

pgsql: Variable renaming in preparation for refactoring

2022-11-16 Thread Peter Eisentraut
Variable renaming in preparation for refactoring Rename page -> block and dp -> page where appropriate. The old naming mixed up block and page in confusing ways. Author: Melanie Plageman Discussion: https://www.postgresql.org/message-id/flat/caakru_ysonhksdyfcqjsktbsrd32dp-jjxmv7hl0bpd-z0t...@

pgsql: Remove useless casts

2022-11-16 Thread Peter Eisentraut
Remove useless casts Maybe these are left from when PageGetItem() was a macro, but now they are clearly useless. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d1cb4e9f92c3db5c8fb52ccd1d502c73ffcc47e0 Modified Files -- src/backend/access/heap/heapam.c

pgsql: Turn HeapKeyTest macro into inline function

2022-11-16 Thread Peter Eisentraut
Turn HeapKeyTest macro into inline function It is easier to read as a function. Author: Melanie Plageman Reviewed-by: Andres Freund Discussion: https://www.postgresql.org/message-id/flat/caakru_ysonhksdyfcqjsktbsrd32dp-jjxmv7hl0bpd-z0t...@mail.gmail.com Branch -- master Details --- h

pgsql: Remove unused include

2022-11-16 Thread Peter Eisentraut
Remove unused include Author: Melanie Plageman Discussion: https://www.postgresql.org/message-id/flat/caakru_ysonhksdyfcqjsktbsrd32dp-jjxmv7hl0bpd-z0t...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/c0f1e51ac79efd4d8c07374405d9035356b30621 Modif

pgsql: doc: update metacpan.org links to avoid redirects

2022-11-16 Thread Daniel Gustafsson
doc: update metacpan.org links to avoid redirects The /release/ links are redirected to /dist/ and /pod/release/ to /release/../view/, so update our links accordingly to avoid 301 redirects. Discussion: https://postgr.es/m/[email protected] Branch -- master Detai

pgsql: doc: document the TAP test environment variables

2022-11-16 Thread Daniel Gustafsson
doc: document the TAP test environment variables The TAP tests can, to some degree, be controlled by a set of environment variables. These were however only documented in a README and not in the main documentation. This adds documentation of these variables, as well as changes one CPAN reference